Re: [Openvpn-devel] [PATCH 2/4] Merge getaddr_multi and getaddr6 into one function

2012-08-06 Thread Gert Doering
Hi, On Mon, Aug 06, 2012 at 07:39:38PM +0200, Gert Doering wrote: > Mon Aug 6 19:49:06 2012 Attempting to establish TCP connection with > [AF_INET6]2607:fc50:1001:5200:::51194 [nonblock] > > This is buggy already, because "conn-test-server" is "2607:fc50:1001:5200::4", > and the ":4" got

Re: [Openvpn-devel] [PATCH 2/4] Merge getaddr_multi and getaddr6 into one function

2012-08-06 Thread Gert Doering
Hi, On Wed, Aug 01, 2012 at 06:11:08PM +0200, Arne Schwabe wrote: > the getaddr6 and getaddr_mutli functions are duplicates of each other. Since > we always require getaddrinfo to be present both function are merge into one > openvpn_getaddrinfo. > > This functions also returns a standard

[Openvpn-devel] [PATCH] get IPv4 default route on Linux via rtnetlink

2012-08-06 Thread Heiko Hund
The file /proc/net/route only contains routes from the main routing table. When a default route is set in the "default" table, openvpn cannot find it by parsing that file. Using the routing netlink socket removes this limitation. While getting the IPv6 default route would be possible with

Re: [Openvpn-devel] [PATCH 3/4] Merge almost identical create_socket_tcp and create_socket_tcp6

2012-08-06 Thread David Sommerseth
On 02/08/12 15:36, Arne Schwabe wrote: > Signed-off-by: Arne Schwabe > --- > src/openvpn/manage.c |4 ++-- > src/openvpn/socket.c | 53 > +++--- > src/openvpn/socket.h |2 +- > 3 files changed, 10 insertions(+), 49

Re: [Openvpn-devel] [PATCH 1/4] Fixes error: --key fails with EXTERNAL_PRIVATE_KEY: No such file or directory if --management-external-key is used

2012-08-06 Thread David Sommerseth
On 02/08/12 15:37, Arne Schwabe wrote: > Warn if both options are used at the same time. > > Signed-off-by: Arne Schwabe > --- > src/openvpn/options.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/src/openvpn/options.c

Re: [Openvpn-devel] [PATCH 1/2] add x_msg_va() log function

2012-08-06 Thread David Sommerseth
On 01/08/12 13:37, Heiko Hund wrote: > This change allows other functions to access the functionality in x_msg(). > Needed for the plug-in logging API. > > Signed-off-by: Heiko Hund > --- > src/openvpn/error.c | 11 --- > src/openvpn/error.h |2 ++ > 2 files