Re: [Openvpn-devel] [PATCHv2] grow route lists dynamically

2014-02-18 Thread Arne Schwabe
Am 18.02.14 18:59, schrieb Heiko Hund: > This removes the need for the --max-routes option. Instead of > allocating a fixed size array for the route(-option)s they are > managed in linked lists instead. > ACK. Arne signature.asc Description: OpenPGP digital signature

[Openvpn-devel] [PATCHv2] grow route lists dynamically

2014-02-18 Thread Heiko Hund
This removes the need for the --max-routes option. Instead of allocating a fixed size array for the route(-option)s they are managed in linked lists instead. Signed-off-by: Heiko Hund --- src/openvpn/init.c| 4 +- src/openvpn/options.c | 33 ++- src/openvpn/options.h | 3 +- src/ope

Re: [Openvpn-devel] ECDH support

2014-02-18 Thread pietrek --
On 02/18/14 12:50, Gert Doering wrote: Hi, On Tue, Feb 18, 2014 at 12:15:16PM +0100, pietrek -- wrote: Which parts of the key handshake does it cover? Signature/Certificates, or *only* DH? Handshake only, EC certificates worked for me without doing anything. Also, DH didn't work with EC certi

Re: [Openvpn-devel] [PATCH] grow route lists dynamically

2014-02-18 Thread Heiko Hund
Hi Arne On Monday 17 February 2014 19:49:49 Arne Schwabe wrote: > ACK but with two changes > > - adding a comment to the copy method that this does a shallow copy with > two lists with the same tail > - struct route* next should be struct route_ipv4 *next in the route_ipv4 > struct. Thanks for t

Re: [Openvpn-devel] Remove from list

2014-02-18 Thread Eric Crist
You'll need to remove yourself. - Eric F Crist On Feb 18, 2014, at 07:53:45, Jeffrey Malkoff wrote: > Please remove me from the distribution list. Thank you! > > -- > Managing the Performance of Cloud-Based Appl

[Openvpn-devel] Remove from list

2014-02-18 Thread Jeffrey Malkoff
Please remove me from the distribution list. Thank you!

Re: [Openvpn-devel] ECDH support

2014-02-18 Thread pietrek --
Hi again, I forget about freeing key after init. I added a line with it to my patch. Piotr Jarosz diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 9e21d5a..c8581e3 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -578,6 +578,7 @@ static const char usage_message[

Re: [Openvpn-devel] ECDH support

2014-02-18 Thread Gert Doering
Hi, On Tue, Feb 18, 2014 at 12:15:16PM +0100, pietrek -- wrote: > > Which parts of the key handshake does it cover? Signature/Certificates, > > or *only* DH? > Handshake only, EC certificates worked for me without doing anything. > Also, DH didn't work with EC certificates( no such cipher ). I s

Re: [Openvpn-devel] ECDH support

2014-02-18 Thread pietrek --
Hi, Could you describe in a bit more detail what your patch does? I don't really understand the openssl innards well enough, but am curious. *If* I understand it correctly, what it does is provide keying material (ECDH) to support EC for the TLS handshake, right? And there isn't actually anyt

Re: [Openvpn-devel] ECDH support

2014-02-18 Thread Steffan Karger
Hi Piotr, On 18-02-14 01:35, pietrek -- wrote: > It's my first contribution, so I could make some mistakes ;) Thank you! > In attached patch I added ECDH support to openvpn with openssl. > Eliptic Curves generation is, in contrast to Diffie-Hellman very fast, > so I do it on every server initial

Re: [Openvpn-devel] ECDH support

2014-02-18 Thread Gert Doering
Hiya, On Tue, Feb 18, 2014 at 01:35:40AM +0100, pietrek -- wrote: > It's my first contribution, so I could make some mistakes ;) > In attached patch I added ECDH support to openvpn with openssl. > Eliptic Curves generation is, in contrast to Diffie-Hellman very fast, > so I do it on every server

Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-02-18 Thread Gert Doering
Hi, On Tue, Feb 18, 2014 at 07:16:17AM +0100, Tore Anderson wrote: > > Could you run my test program to see whether that gets it right? > > It doesn't: Meh! > This is 64-bit Linux, yes: I'll re-test. I *did* test it on mine... Linux gentoo 3.3.8-gentoo #1 SMP Fri Jun 29 14:10:01 CEST 2012 x8

Re: [Openvpn-devel] git master proto udp6+multihome is broken

2014-02-18 Thread Tore Anderson
Hi Gert, > Could you run my test program to see whether that gets it right? It doesn't: server$ mhome AF_INET6/IPV6_RECVPKTINFO enabled setsockopt(IPV6_V6ONLY=0) Socket bound to local address [AF_INET6][undef]:50001 -- CMSG_NXTHDR=(nil), level=41, type=50 IPV6_PKTINFO read: fromlen=28, r_len=5

[Openvpn-devel] ECDH support

2014-02-18 Thread pietrek --
Hi all, It's my first contribution, so I could make some mistakes ;) In attached patch I added ECDH support to openvpn with openssl. Eliptic Curves generation is, in contrast to Diffie-Hellman very fast, so I do it on every server initialization. Piotr Jarosz diff --git a/src/openvpn/op