[Openvpn-devel] [PATCH applied] Re: Fix regression with password protected private keys (polarssl)

2014-10-24 Thread Gert Doering
ACK, verifying against the polarssl commit. Your patch has been applied to the release/2.3 branch. commit f056c8eadc4d5fcda5d1e861425802f503587f16 Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Sep 19 06:43:48 2014 +0200 Fix regression with password protec

[Openvpn-devel] [PATCH applied] Re: Fix regression with password protected private keys (polarssl)

2014-10-24 Thread Gert Doering
ACK, verifying against the polarssl commit. Your patch has been applied to the master branch. commit 4b9eaa1ee40648f101deb4ebf07a04cd5b5400e9 Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Sep 19 06:19:13 2014 +0200 Fix regression with password protected p

[Openvpn-devel] [PATCH applied] Re: Modification to address bug where OpenVPN enters state where it is unresponsive and cannot be terminated. Log output is continuous spew of code=995 errors.

2014-10-24 Thread Gert Doering
Your patch has been applied to the master and release/2.3 branches. Since the second patch basically undoes everything the first one does and uses a different approach, I've merged them into one patch to make the net change more explicit - and fixed a bit of spurious whitespace. Also, I've taken

Re: [Openvpn-devel] session-id implementation

2014-10-24 Thread David Sommerseth
On 24/10/14 15:20, Gert Doering wrote: [...snip...] > ... please don't do whitespace changes in places where no code changes > (as it makes it harder to see where changes happened) [...snip...] > Here's an escaped tab-to-space conversion or so, but "just whitespace > change" nonetheless. [...snip.

Re: [Openvpn-devel] session-id implementation

2014-10-24 Thread Gert Doering
Hi, On Fri, Oct 24, 2014 at 02:23:48PM +0300, Lev Stipakov wrote: > As discussed on IRC meeting, we replace session-id with peer-id. > > So, waiting for review and code-ACK :) A few bits of review on the "non-critical" parts - so, most of it is style, but nevertheless: >/* Decrypt packe

Re: [Openvpn-devel] session-id implementation

2014-10-24 Thread Lev Stipakov
Hello, As discussed on IRC meeting, we replace session-id with peer-id. So, waiting for review and code-ACK :) -Lev 2014-10-23 17:07 GMT+03:00 Lev Stipakov : > Hi Steffan, > > Patch attached. > > -Lev > > 2014-10-23 10:52 GMT+03:00 Steffan Karger : >> Hi Lev, >> >> On 10/21/2014 09:33 AM, Lev S

Re: [Openvpn-devel] man page and options.c contradict

2014-10-24 Thread Steffan Karger
On 10/24/2014 11:41 AM, Arne Schwabe wrote: > Am 24.10.14 11:15, schrieb Gert Doering: > And an important distinction is that the p2p mode does not use Diffie > Hellman, meaning that it provides no Perferct Forward Security. No, I think there's another distinction. There's 'static key mode' (--sec

Re: [Openvpn-devel] man page and options.c contradict

2014-10-24 Thread Arne Schwabe
Am 24.10.14 11:15, schrieb Gert Doering: > Hi, > > On Fri, Oct 24, 2014 at 01:04:17AM -0600, Reinoud Koornstra wrote: >> I understood the term mode wrong. >> So the main mode can be p2p or server to denote the openvpn protocol inside >> tcp or udp(stateless) session. Initially I thought the term mo

Re: [Openvpn-devel] man page and options.c contradict

2014-10-24 Thread Gert Doering
Hi, On Fri, Oct 24, 2014 at 01:04:17AM -0600, Reinoud Koornstra wrote: > I understood the term mode wrong. > So the main mode can be p2p or server to denote the openvpn protocol inside > tcp or udp(stateless) session. Initially I thought the term mode is used to > denote server, client or udp. Op

[Openvpn-devel] FW: [PATCH] Fix regression with password protected private keys (polarssl)

2014-10-24 Thread Steffan Karger
Attempt 2, see below. It seems that somehow my previous mail has disappeared from the interwebs, I can't find it in the archives. -Original Message- From: Steffan Karger [mailto:steffan.kar...@fox-it.com] Sent: maandag 6 oktober 2014 21:11 To: openvpn-devel@lists.sourceforge.net Subject:

Re: [Openvpn-devel] man page and options.c contradict

2014-10-24 Thread Reinoud Koornstra
Ok, Thanks. I understood the term mode wrong. So the main mode can be p2p or server to denote the openvpn protocol inside tcp or udp(stateless) session. Initially I thought the term mode is used to denote server, client or udp. Hi, On Thu, Oct 23, 2014 at 03:42:54PM -0600, Reinoud Koornstra wrote:

Re: [Openvpn-devel] man page and options.c contradict

2014-10-24 Thread Gert Doering
Hi, On Thu, Oct 23, 2014 at 03:42:54PM -0600, Reinoud Koornstra wrote: > Ok, clear, to TCP cannot be used in point to point mode (p2p) then, because > in case of tcp we must have a client and a server? Please READ what I write, so I don't have to repeat it. TCP imposes an imbalance between the p