Re: [Openvpn-devel] [PATCH for gui] Do not disconnect on suspend by default

2015-11-09 Thread Selva Nair
Hi, >> Requires the installer to update the registry during an upgrade of exisitng >> installations, or notify the end user of the change in the default value of >> disconnect_on_suspend (0). > > What does this patch *do*? Is this the "set up registry key on first > start" part (so we set the

Re: [Openvpn-devel] Topics for today's (Monday, 9th Nov 2015) community meeting

2015-11-09 Thread Samuli Seppänen
Hi, Here's the summary of today's IRC meeting. --- COMMUNITY MEETING Place: #openvpn-devel on irc.freenode.net List-Post: openvpn-devel@lists.sourceforge.net Date: Monday 9th Nov 2015 Time: 20:00 CET (19:00 UTC) Planned meeting topics for this meeting were here:

Re: [Openvpn-devel] [PATCH] Fix a few typos in the Russian localization

2015-11-09 Thread Роман Донченко
Oh, OK then. I didn't know about the fork. ValdikSS писал в своём письме Mon, 09 Nov 2015 22:28:52 +0300: Thanks for the patch but all these and another typos are already fixed in the mattock's repository

Re: [Openvpn-devel] [PATCH for gui] Do not disconnect on suspend by default

2015-11-09 Thread Gert Doering
Hi, On Mon, Nov 09, 2015 at 03:35:23PM -0500, Selva Nair wrote: > With commit ea66a2b5c.. openvpn restarts instead of terminate on suspend. > This conflicts with the stop/restart logic in the gui during windows power > state change events. Here we change the default behaviour so that SIGTERM > is

[Openvpn-devel] [PATCH for gui] Do not disconnect on suspend by default

2015-11-09 Thread Selva Nair
With commit ea66a2b5c.. openvpn restarts instead of terminate on suspend. This conflicts with the stop/restart logic in the gui during windows power state change events. Here we change the default behaviour so that SIGTERM is not triggered during windows suspend. Requires the installer to update

Re: [Openvpn-devel] [PATCH] Fix a few typos in the Russian localization

2015-11-09 Thread ValdikSS
Thanks for the patch but all these and another typos are already fixed in the mattock's repository https://github.com/mattock/openvpn-gui/commit/b5b00c272674233c5c951c0e473f2341065a9fc4 and would be included in next release. On 09.11.2015 21:32, Роман Донченко wrote: > --- >

Re: [Openvpn-devel] Adding a ctrl-C handler in windows

2015-11-09 Thread Selva Nair
Hi, On Mon, Nov 9, 2015 at 1:04 PM, James Yonan wrote: >>> I plan to add a control-C handler in win32.c. The handler will simply >>> map it to SIGTERM. Is there any particular reason why control-C is not >>> currently handled? >> >> Hi, >> >> I forwarded this email to James -

[Openvpn-devel] [PATCH] Fix a few typos in the Russian localization

2015-11-09 Thread Роман Донченко
--- res/openvpn-gui-res-ru.rc | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/res/openvpn-gui-res-ru.rc b/res/openvpn-gui-res-ru.rc index a9f8f48..08e7f97 100644 --- a/res/openvpn-gui-res-ru.rc +++ b/res/openvpn-gui-res-ru.rc @@ -123,12 +123,12 @@ FONT 8, "Microsoft

Re: [Openvpn-devel] Adding a ctrl-C handler in windows

2015-11-09 Thread James Yonan
On 09/11/2015 00:38, Samuli Seppänen wrote: Hi, I plan to add a control-C handler in win32.c. The handler will simply map it to SIGTERM. Is there any particular reason why control-C is not currently handled? Hi, I forwarded this email to James - he might have a clue. Currently the

[Openvpn-devel] [PATCH applied] Re: polarssl: add --verify-client-cert optional support

2015-11-09 Thread Gert Doering
Your patch has been applied to the master branch. commit f107c62051ebbf4a2b661fcba8703fe26485c7af Author: Steffan Karger List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Oct 16 00:43:15 2015 +0200 polarssl: add --verify-client-cert optional support Signed-off-by: Steffan

[Openvpn-devel] [PATCH applied] Re: Author: Jan Just Keijser <janj...@nikhef.nl>

2015-11-09 Thread Gert Doering
Your patch has been applied to the master branch. commit b8cdb213d4fa5a56074115faceb2e0da373bab8f Author: Jan Just Keijser List-Post: openvpn-devel@lists.sourceforge.net Date: Fri Oct 9 11:39:19 2015 +0200 Author: Jan Just Keijser Signed-off-by: Jan Just Keijser

Re: [Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-11-09 Thread Gert Doering
Hi, On Mon, Nov 09, 2015 at 04:35:09PM +0200, Lev Stipakov wrote: > v2: > * Remove netsh call which uses adapter name. After thoughtful testing > turns out that "adapter name" code branch is never used. Not there yet :-) - but thanks for picking this up. As I said for v1, if we change this for

[Openvpn-devel] [PATCH v2] Use adapter index instead of name

2015-11-09 Thread Lev Stipakov
v2: * Remove netsh call which uses adapter name. After thoughtful testing turns out that "adapter name" code branch is never used. Some windows machines get weird issues with netsh when using adapter name on "netsh.exe interface ipv6 set address" command. Changed logic to get adapter index and

Re: [Openvpn-devel] [PATCH 2/2] polarssl: add --verify-client-cert optional support

2015-11-09 Thread Jan Just Keijser
Ack to this patch (but remember to apply my patch first :)) JJK Steffan Karger wrote: This adds support for the --verify-client-cert optional option in PolarSSL builds, as was earlier added for OpenSSL builds by Jan-Just Keijser. This patch also adds an additional sanity check that this

[Openvpn-devel] Topics for today's (Monday, 9th Nov 2015) community meeting

2015-11-09 Thread Samuli Seppänen
Hi, We're going to have an IRC meeting today starting at 20:00 CET (19:00 UTC) on #openvpn-meeting irc.freenode.net. Note that the meeting channel has changed and that you do _not_ have to be logged in to Freenode to join the channel. Current topic list along with basic information is

Re: [Openvpn-devel] [PATCH applied] Re: Fix termination when windows suspends/sleeps

2015-11-09 Thread Samuli Seppänen
Hi, On Fri, Nov 6, 2015 at 4:12 PM, Gert Doering wrote: On Fri, Nov 06, 2015 at 10:08:59PM +0100, Gert Doering wrote: ACK. Explanation makes sense, logs and testers demonstrate that it indeed fixes a significant problem, and the code is sane :-) - thanks. Your patch

Re: [Openvpn-devel] Adding a ctrl-C handler in windows

2015-11-09 Thread Samuli Seppänen
Hi, I plan to add a control-C handler in win32.c. The handler will simply map it to SIGTERM. Is there any particular reason why control-C is not currently handled? Hi, I forwarded this email to James - he might have a clue. Samuli