Re: [Openvpn-devel] XP broken (wrt IPv6 in 2.3.9)

2015-12-20 Thread ValdikSS
I don't like the idea with additional win32-route option, it really should just use interface name on XP and index on Vista+. On 12/20/2015 09:19 PM, Gert Doering wrote: > Hi, > > On Sun, Dec 20, 2015 at 07:32:56PM +0200, Lev Stipakov wrote: > The usual problem of "attached you'll find... (nothi

[Openvpn-devel] [PATCH v3] cleanup: get rid of httpdigest.c type warnings

2015-12-20 Thread Steffan Karger
When I compile with --enable-strict, I only want to see warnings that are relevant. So, change httpdigest.c to make the casts explicit. This commit should not change behaviour. v2: as discussed on #openvpn-devel, make colon a const uint8_t *, instead of uint8_t. v3: as further discussed on #

[Openvpn-devel] Testing challenge-response

2015-12-20 Thread Selva Nair
Hi, To test the challenge-response handling, I had setup a test server. Will keep running it for a while, so if anyone wants to use it for testing, a config is available at https://s3.amazonaws.com/selva-temp/cr-test.conf It uses the sample keys and certs, and the server will only provide limited

Re: [Openvpn-devel] [PATCH v2] Make assert_failed() print the failed condition

2015-12-20 Thread Arne Schwabe
On 20.12.2015 11:44, Steffan Karger wrote: > Easy change to make logging output more useful. > > v2: don't print the failed condition if ENABLE_SMALL is defined. > ACK. Thanks. Arne

[Openvpn-devel] [PATCH] Support reading the challenge-response from console

2015-12-20 Thread Selva Nair
Trying to keep the footrpint small, this patch adds to the convoluted code-flow in get_user_pass_cr(). Cleanup left for later. -8<- Currently prompting for a response to static-challenge gets skipped when the username and passowrd are read from a file. Further, dynamic challenge gets wrong

Re: [Openvpn-devel] XP broken (wrt IPv6 in 2.3.9)

2015-12-20 Thread Gert Doering
Hi, On Sun, Dec 20, 2015 at 07:32:56PM +0200, Lev Stipakov wrote: > Screenshot seems to be lost in transmission. The usual problem of "attached you'll find... (nothing)". Resend :-) > Moving to openvpn-devel. > > We could probably detect XP only (or technically "less then Vista") by > checkin

Re: [Openvpn-devel] XP broken

2015-12-20 Thread Lev Stipakov
Hi, Screenshot seems to be lost in transmission. Moving to openvpn-devel. We could probably detect XP only (or technically "less then Vista") by checking that IsWindowsVistaOrGreater() == false which seems to be simpler. It should fix the problem. However I like the idea that server will be abl

[Openvpn-devel] [PATCH] Add Travis CI config for automatic builds and static analysis

2015-12-20 Thread Steffan Karger
Adding a .travis.yml file with config for automated builds enables travis-ci to perform some basic continuous integration. This does not replace our existing build and test infrastructure, since that tests many more combinations and platforms. When added to the repository, this enables automated

[Openvpn-devel] [PATCH applied] Re: Make assert_failed() print the failed condition

2015-12-20 Thread Gert Doering
ACK (Arne's ACK for v2 taken from IRC, did not make it to the list yet). Your patch has been applied to the master and release/2.3 branch. commit 9b36bd40d393620cce83392f4a56392ba391fb7c (master) commit 87e555aea146ec69007ff25ce66e63ad94ae9f7d (release/2.3) Author: Steffan Karger List-Post: open

[Openvpn-devel] [PATCH v2] cleanup: get rid of httpdigest.c type warnings

2015-12-20 Thread Steffan Karger
When I compile with --enable-strict, I only want to see warnings that are relevant. So, change httpdigest.c to use the correct type when possible and make any remaining casts explicit. This commit should not change behaviour. v2: as discussed on #openvpn-devel, make colon a const uint8_t *, inst

[Openvpn-devel] [PATCH v2] Make assert_failed() print the failed condition

2015-12-20 Thread Steffan Karger
Easy change to make logging output more useful. v2: don't print the failed condition if ENABLE_SMALL is defined. Signed-off-by: Steffan Karger --- src/openvpn/error.c | 7 +-- src/openvpn/error.h | 9 +++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/openvpn/erro

Re: [Openvpn-devel] [PATCH] Make assert_failed() print the failed condition

2015-12-20 Thread Arne Schwabe
On 20.12.2015 10:10, Steffan Karger wrote: > Easy change to make logging output more useful. > ACK. BUt I think if we keep the minimal build option, this should be disabled int that option since the extra strings will increase code size. Arne

[Openvpn-devel] [PATCH] Make assert_failed() print the failed condition

2015-12-20 Thread Steffan Karger
Easy change to make logging output more useful. Signed-off-by: Steffan Karger --- src/openvpn/error.c | 4 ++-- src/openvpn/error.h | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/openvpn/error.c b/src/openvpn/error.c index 66f37f3..6daf465 100644 --- a/src/openvpn/