[Openvpn-devel] travis-ci (smoke testing)

Hello, I was impressed by unit testing efforts, so I suggest to implement something like that https://travis-ci.org/chipitsine/openvpn/builds/135318558 ( https://github.com/OpenVPN/openvpn/pull/52 ) we can use Linux, Mac OSX, gcc, clang, various configure options. (unfortunately, ssl cert at

[Openvpn-devel] [PATCH master-only] Set WFP engine handle to NULL in win_wfp_uninit()

This was missed by commit 6a33a34dee8f3 Signed-off-by: Selva Nair --- src/openvpn/win32.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/openvpn/win32.c b/src/openvpn/win32.c index f4d3237..8a2f957 100644 --- a/src/openvpn/win32.c +++ b/src/openvpn/win32.c @@ -1192,6 +1192,7 @@ win_w

[Openvpn-devel] [PATCH master] Make block-outside-dns work with persist-tun

- Remove and recreate WFP filters during restart even when tun/tap is not re-opened. This is needed for resolving the remote. Patch same as for v2.3 except for passing 'msg_channel'. See also: http://article.gmane.org/gmane.network.openvpn.user/36990 Signed-off-by: Selva Nair --- src/openvp

[Openvpn-devel] [PATCH release/2.3] Make block-outside-dns work with persist-tun

- Remove and recreate WFP filters during restart even when tun/tap is not re-opened. This is needed for resolving the remote. See also: http://article.gmane.org/gmane.network.openvpn.user/36990 Signed-off-by: Selva Nair --- src/openvpn/init.c | 18 ++ 1 file changed, 18 inse

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

… > IMO, the unit testing patches shouldn't have been merged into the release > branch I agree. This patch was in retrospective clearly not ready for a release branch. A lot of people spend time to hot fix a broken build. My root cause analysis boils down to: Developers cannot detect multi

Re: [Openvpn-devel] [PATCH] Fix the comparison of pull options hash on restart

On Sat, Jun 4, 2016 at 6:57 AM, Selva Nair wrote: > Signed-off-by: Selva Nair > --- > src/openvpn/init.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/init.c b/src/openvpn/init.c > index 42baf97..4b044f4 100644 > --- a/src/openvpn/init.c > +++ b/src/open

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

On Fri, Jun 3, 2016 at 2:37 PM, Selva Nair wrote: > > On Fri, Jun 3, 2016 at 2:14 PM, Gert Doering wrote: > >> On Fri, Jun 03, 2016 at 07:49:23PM +0200, David Sommerseth wrote: >> > From: David Sommerseth >> > >> > Continuing to fix breakage caused by commit 40cb4cfc5d011102. >> [..] >> >> Not

[Openvpn-devel] [PATCH] Fix the comparison of pull options hash on restart

Signed-off-by: Selva Nair --- src/openvpn/init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 42baf97..4b044f4 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -1717,7 +1717,7 @@ options_hash_changed_or_zero(const