Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

> >> IMO, the unit testing patches shouldn't have been merged into the release >> branch > > I have discussed this with David (after the fact, meh) and we couldn't > really come to an conclusion on this - but since you and Jens now both > argue that way (and especially Jens as the original auth

[Openvpn-devel] [PATCH 1/2 v2] Add an option to filter options received from server

v2 changes: - Add the flag "ignore" and have "reject" trigger a restart. - Unlimited number of filters: yes, going against the consensus, but the code looks simpler and cleaner this way. - New commit message to reflect the changes. Usage: --pull-filter accept|ignore|reject "option" Permit a

[Openvpn-devel] [PATCH 2/2] Save exit-notify timer during a restart

When exit-notify is specified, SIGTERM could be lost if a SIGUSR1/SIGHUP restart happens during the exit notification interval. This is particularly apparent when pull-filter reject causes a repeated SIGUSR1 restart cycle. - Save the explicit_exit_notification_interval and time_wait across resta

Re: [Openvpn-devel] [PATCH] Add an option to filter options received from server

Hi, Version 2 of the patch is in the next email. There is also an accompanying patch that addresses the restart/SIGTERM issue raised in my previous email and Trac 687. I'm posting itinto this thread as the first would benefit from the second. That said, I.m not sure this is the best/correct way

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

Hi, On Sat, Jun 04, 2016 at 01:17:25AM -0400, Selva Nair wrote: > The joy was short-lived. mingw cross-compile from release/2.3 tarball is > also broken: > > error: cannot find input file: `vendor/Makefile.in' > > Thankfully, cherry-pick 41ab12f06253c fixes it. I have cherry-picked 41ab12f0

[Openvpn-devel] [PATCH applied] Re: Make block-outside-dns work with persist-tun

ACK. Same thing as for the master patch - fixes an obvious issue :-) Your patch has been applied to the release/2.3 branch. commit 1aa9d281052d45f20aaa9ff28255d19faee88eb9 Author: Selva Nair List-Post: openvpn-devel@lists.sourceforge.net Date: Sat Jun 4 11:54:08 2016 -0400 Make block-out

[Openvpn-devel] [PATCH applied] Re: Make block-outside-dns work with persist-tun

Your patch has been applied to the master branch. commit 451d2177d762e93677cad52bb2360a8dfb389ac7 Author: Selva Nair List-Post: openvpn-devel@lists.sourceforge.net Date: Sat Jun 4 11:57:13 2016 -0400 Make block-outside-dns work with persist-tun Signed-off-by: Selva Nair Acked-b

[Openvpn-devel] [PATCH applied] Re: Set WFP engine handle to NULL in win_wfp_uninit()

ACK, making engine state explicit is good style - and it protects against crashes if calling win_wfp_uninit() twice without opening it in between again. Your patch has been applied to the master branch. commit 895d75cf99bf8f3b95b01d6e19df30208cec27a9 Author: Selva Nair List-Post: openvpn-devel@li

Re: [Openvpn-devel] [PATCH master] Make block-outside-dns work with persist-tun

Hi, On Sat, Jun 04, 2016 at 11:57:13AM -0400, Selva Nair wrote: > - Remove and recreate WFP filters during restart even when > tun/tap is not re-opened. This is needed for resolving the remote. > Patch same as for v2.3 except for passing 'msg_channel'. > > See also: http://article.gmane.org/g

[Openvpn-devel] [PATCH applied] Re: Fix the comparison of pull options hash on restart

Your patch has been applied to the master branch. commit 1899393543caa3cd5191c96176e8ecaa8e690eeb Author: Selva Nair List-Post: openvpn-devel@lists.sourceforge.net Date: Sat Jun 4 00:57:43 2016 -0400 Fix the comparison of pull options hash on restart Signed-off-by: Selva Nair A

Re: [Openvpn-devel] travis-ci (smoke testing)

I am very fascinated - Travis is super cool :-) I building and even running / testing (qemu userland emulation) quite complex build matrix. clang/gcc several OSX/Version + multiple sdk version, Win32/64, Linux + sdk on many architectures. Actually building my kbuild build system fork on x86_32, x

Re: [Openvpn-devel] travis-ci (smoke testing)

воскресенье, 5 июня 2016 г. пользователь Steffan Karger написал: > Hi, > > On Sun, Jun 5, 2016 at 12:21 AM, Илья Шипицин > wrote: > > I was impressed by unit testing efforts, so I suggest to implement > something > > like that > > > > https://travis-ci.org/chipitsine/openvpn/builds/135318558 > >

Re: [Openvpn-devel] travis-ci (smoke testing)

Hi, On Sun, Jun 5, 2016 at 12:21 AM, Илья Шипицин wrote: > I was impressed by unit testing efforts, so I suggest to implement something > like that > > https://travis-ci.org/chipitsine/openvpn/builds/135318558 > > ( https://github.com/OpenVPN/openvpn/pull/52 ) > > we can use Linux, Mac OSX, gcc,

Re: [Openvpn-devel] clang static analysis

Hi, On Sun, Jun 5, 2016 at 9:33 AM, Илья Шипицин wrote: > I performed the following steps > > 1) cloned master branch of https://github.com/openvpn/openvpn > 2) autoreconf -iv > 3) ./configure > 4) scan-build make > > (scan-build is clang tool for static analysis) > > > report is here: http://ch

Re: [Openvpn-devel] travis-ci (smoke testing)

it is because of SNI 2016-06-05 12:25 GMT+05:00 Steffan Karger : > On Sun, Jun 5, 2016 at 2:16 AM, Jens Neuhalfen > wrote: > >> (unfortunately, ssl cert at mbed tls website was expired and Xcode7.3 > does > >> not compile openvpn with openssl) > > > > Very strange, the cert is valid till 2017. >

[Openvpn-devel] clang static analysis

Hello, I performed the following steps 1) cloned master branch of https://github.com/openvpn/openvpn 2) autoreconf -iv 3) ./configure 4) scan-build make (scan-build is clang tool for static analysis) report is here: http://chipitsine.github.io/openvpn-clang-scan/ I think we should take care

Re: [Openvpn-devel] travis-ci (smoke testing)

I marked xcode6.4 as failures for a while (I've no idea what's wrong there, time is correct, certificate is correct, I'll dive into that later) as for Mac OS X, we can choose build matrix as wide as we want to, I do not insist on using xcode6.4 image, it is just as example. we can pick any combin

Re: [Openvpn-devel] travis-ci (smoke testing)

On Sun, Jun 5, 2016 at 2:16 AM, Jens Neuhalfen wrote: >> (unfortunately, ssl cert at mbed tls website was expired and Xcode7.3 does >> not compile openvpn with openssl) > > Very strange, the cert is valid till 2017. There seems to be some load balancing / CDN going om at mbed.org. My browser als

Re: [Openvpn-devel] travis-ci (smoke testing)

Hi > > Hello, > > I was impressed by unit testing efforts, so I suggest to implement something > like that > > https://travis-ci.org/chipitsine/openvpn/builds/135318558 > > > ( https://github.com/OpenVPN/openvpn/pull/52 >