Re: [Openvpn-devel] [PATCH] systemd: Move the READY=1 signalling to an earlier point

2017-01-24 Thread Gert Doering
Hi, On Wed, Jan 25, 2017 at 12:23:44AM +0100, David Sommerseth wrote: > The approach this patch takes is to consider OpenVPN ready once > all the initial preparations and configurations have happened - but > before a connection to a remote side have been attempted. This > also removes the need

[Openvpn-devel] [PATCH] systemd: Move the READY=1 signalling to an earlier point

2017-01-24 Thread David Sommerseth
Currently, OpenVPN will first tell systemd it is ready once the log will be appended with "Initialization Sequence Completed". This turns out to cause some issues several places. First, it adds challenges if --chroot is used in the configuration; this we already fixed. Secondly, it will cause

[Openvpn-devel] [PATCH] Allow changing cipher from a ccd file

2017-01-24 Thread Steffan Karger
As described in msg <374a7eb7-f539-5231-623b-41f208ed8...@belkam.com> on openvpn-devel@lists.sourceforge.net, clients that are compiled with --disable-occ (included in --enable-small) won't send an options string. Without the options string, the 2.4 server doesn't know which cipher to use for

Re: [Openvpn-devel] [PATCH] Resolving several travis-ci issues:

2017-01-24 Thread Илья Шипицин
can we apply it ? seems nobody minds 2017-01-10 13:04 GMT+05:00 Ilya Shipitsin : > * moving LD_LIBRARY_PATH as far as possible (otherwise "wget" picks it, > which is not desirable) > * split LD_LIBRARY_PATH into LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending > on operating

Re: [Openvpn-devel] [PATCH 2/2] do not race on RuntimeDirectory

2017-01-24 Thread David Sommerseth
Just a very quick comment before I review and test the rest. On 24/01/17 15:39, Christian Hesse wrote: [...snip...] > @@ -20,6 +21,11 @@ if ENABLE_SYSTEMD > systemdunit_DATA = \ > openvpn-client@.service \ > openvpn-server@.service > +tmpfiles_DATA = \ > + tmpfiles-openvpn.conf

Re: [Openvpn-devel] [PATCH 2/2] do not race on RuntimeDirectory

2017-01-24 Thread David Sommerseth
On 24/01/17 15:36, Christian Hesse wrote: > David Sommerseth on Fri, 2017/01/20 21:55: >> On 27/12/16 23:15, Christian Hesse wrote: >>> From: Christian Hesse >>> >>> Different unit instances create and destroy the same RuntimeDirectory. >>> This

[Openvpn-devel] [PATCH 1/2] use automake tools to install systemd files

2017-01-24 Thread Christian Hesse
From: Christian Hesse If systemd is enabled we install unit files to $libdir/systemd/system (or the path specified by SYSTEMD_UNIT_DIR). The unit files are generated on the fly with matching $sbindir. Signed-off-by: Christian Hesse --- .gitignore

[Openvpn-devel] [PATCH 2/2] do not race on RuntimeDirectory

2017-01-24 Thread Christian Hesse
From: Christian Hesse Different unit instances create and destroy the same RuntimeDirectory. This leads to running instances where the status file (and possibly more runtime data) is no longer accessible. So do not handle this in unit files but provide a tmpfiles.d configuration

Re: [Openvpn-devel] [PATCH 2/2] do not race on RuntimeDirectory

2017-01-24 Thread Christian Hesse
David Sommerseth on Fri, 2017/01/20 21:55: > On 27/12/16 23:15, Christian Hesse wrote: > > From: Christian Hesse > > > > Different unit instances create and destroy the same RuntimeDirectory. > > This leads to running instances where the status

Re: [Openvpn-devel] [PATCH 1/2] use automake tools to install systemd files

2017-01-24 Thread Christian Hesse
David Sommerseth on Fri, 2017/01/20 21:39: > On 27/12/16 23:15, Christian Hesse wrote: > > From: Christian Hesse > > > > If systemd is enabled we install unit files to $libdir/systemd/system > > (or the path specified by SYSTEMD_UNIT_DIR). > >