Re: [Openvpn-devel] [PATCH applied] Clean up plugin path handling

2017-01-25 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ACK. This have been through enough rounds, and I currently don't see a better approach to the openvpn-plugin.h generation either. If we find better ways later on, lets fix it then. I've tested this using gdb and investigating which code paths are

[Openvpn-devel] [PATCH] dev-tools: Simple tool wihch automates rebasing LZ4 compat library

2017-01-25 Thread David Sommerseth
This tool depends on a cloned upstream LZ4 git repository and a checked out release tag. Then run the script like this: $ ./dev-tools/lz4-rebaser.sh /path/to/lz4.git To see the result before committing, use: git diff --cached Signed-off-by: David Sommerseth ---

[Openvpn-devel] [PATCH v5 1/1] Clean up plugin path handling

2017-01-25 Thread Christian Hesse
From: Christian Hesse Drop --with-plugindir, instead use an environment variable PLUGINDIR to specify the plugin directory. This puts a define into include/openvpn-plugin.h.in which has the plugin directory. The configure script does not know about the final plugin path. Thus we

[Openvpn-devel] [PATCH v4 1/1] Clean up plugin path handling

2017-01-25 Thread Christian Hesse
From: Christian Hesse Drop --with-plugindir, instead use an environment variable PLUGINDIR to specify the plugin directory. This makes src/openvpn/plugin.h a template (moved the file to src/openvpn/plugin.h.in). The real header file is generated on the fly, including a define for

Re: [Openvpn-devel] [PATCH] Resolving several travis-ci issues:

2017-01-25 Thread David Sommerseth
On 10/01/17 09:04, Ilya Shipitsin wrote: > * moving LD_LIBRARY_PATH as far as possible (otherwise "wget" picks it, which > is not desirable) > * split LD_LIBRARY_PATH into LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on > operating system > * removed MBEDTLS_VERSION, OPENSSL_VERSION (the last

Re: [Openvpn-devel] [PATCH v3 1/1] Clean up plugin path handling

2017-01-25 Thread Christian Hesse
David Sommerseth on Wed, 2017/01/25 18:06: > On 25/01/17 17:04, Christian Hesse wrote: > > From: Christian Hesse > > > > Drop --with-plugindir, instead use an environment variable PLUGINDIR > > to specify the plugin directory. > > > > This

Re: [Openvpn-devel] [PATCH applied] systemd: Add more security feature for systemd units

2017-01-25 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ACK. Tested this lightly with both server and client profiles, and this seems to work very well. Users having keys under /home will probably complain. But I do not think system wide configurations should depend on keys in users' home directories.

Re: [Openvpn-devel] [PATCH applied] systemd: Do not race on RuntimeDirectory

2017-01-25 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ACK. I've tested this a bit, and it is very reasonable. Your patch has been applied to the following branches commit 3de7be7b17de879a78eea4afe4c918c6104c635d (master) commit e549a9ae5d31d69cc9e5cb57dc094cda556e (release/2.4) Author: Christian

Re: [Openvpn-devel] [PATCH applied] systemd: Use automake tools to install unit files

2017-01-25 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ACK. This works wonderfully, and I've tested a few different approaches. I slightly modified the commit subject line, so it is clearer this is related to systemd. Your patch has been applied to the following branches commit

Re: [Openvpn-devel] [PATCH applied] systemd: Move the READY=1 signalling to an earlier point

2017-01-25 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I took the liberty to improve the commit message a little bit, to make a few things clearer. Your patch has been applied to the following branches commit e83a8684f0a0d944e9d53cdad2b543cfd1b6fbae (master) commit

Re: [Openvpn-devel] [PATCH v3 1/1] Clean up plugin path handling

2017-01-25 Thread Gert Doering
Hi, On Wed, Jan 25, 2017 at 06:06:19PM +0100, David Sommerseth wrote: > But I am wondering about the rationale of adding another header file > (plugindir.h). Why not just add this information to > openvpn-plugin.h.in, which results into openvpn-plugin.h ... and which > plugin.c already includes

Re: [Openvpn-devel] [PATCH] Feedback wanted: proof-of-concept recvmmsg() support

2017-01-25 Thread David Sommerseth
On 24/12/16 14:22, Steffan Karger wrote: > This patch is not done, but I would like to get some early feedback > because I'm not very familiar with this part of the code, nor with the > APIs involved. So I expect to have made some rooky mistakes. > > A while back, I experimented a bit with

Re: [Openvpn-devel] [PATCH v3 1/1] Clean up plugin path handling

2017-01-25 Thread David Sommerseth
On 25/01/17 17:04, Christian Hesse wrote: > From: Christian Hesse > > Drop --with-plugindir, instead use an environment variable PLUGINDIR > to specify the plugin directory. > > This generates a header file src/openvpn/plugindir.h which contains a > define file the plugindir. >

[Openvpn-devel] [PATCH v3 1/1] Clean up plugin path handling

2017-01-25 Thread Christian Hesse
From: Christian Hesse Drop --with-plugindir, instead use an environment variable PLUGINDIR to specify the plugin directory. This generates a header file src/openvpn/plugindir.h which contains a define file the plugindir. v2: The configure script can not evaluate the final

Re: [Openvpn-devel] [PATCH] Allow to specify bind interface for outbound/inbound connections

2017-01-25 Thread Arne Schwabe
A quick from me. > This has been in production use for some time now and there don't seem > to be any problems :) > > Can I motivate anyone on commenting on or applying this? :) > > Best > Max > > > commit 1baa7e6782b39ed664eedb9b006728d31e22c07e > Author: Maximilian Wilhelm >

Re: [Openvpn-devel] [PATCH] Allow to specify bind interface for outbound/inbound connections

2017-01-25 Thread Maximilian Wilhelm
Anno domini 2016 Gert Doering scripsit: Hi Gert, * > On Sun, Oct 30, 2016 at 02:48:25PM +0100, Maximilian Wilhelm wrote: > > Can I motivate anyone on commenting on or applying this? :) > > You're keeping me busy on multiple fronts :-9 - and since this is networking, > it's mostly me who gets to