Re: [Openvpn-devel] [PATCH] Resolving several travis-ci issues:

2017-01-27 Thread David Sommerseth
On 27/01/17 17:58, Selva Nair wrote: > > On Fri, Jan 27, 2017 at 10:08 AM, David Sommerseth > > wrote: > > On 27/01/17 14:56, Илья Шипицин wrote: > > > > > > > may I ask you something in turn ? >

Re: [Openvpn-devel] [PATCH] Resolving several travis-ci issues:

2017-01-27 Thread Selva Nair
On Fri, Jan 27, 2017 at 10:08 AM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > On 27/01/17 14:56, Илья Шипицин wrote: > > > > > > > may I ask you something in turn ? > > I cannot read other people thoughts, if there's something wrong with my > > patch, there's no other known

Re: [Openvpn-devel] [PATCH] Resolving several travis-ci issues:

2017-01-27 Thread David Sommerseth
On 27/01/17 14:56, Илья Шипицин wrote: > > > Basically a patch with commit message consists of three parts: Problem > description, Why and How. The patch diff is the How. These two others > belong to the commit message and often also worthy a comment line or two > in modified

Re: [Openvpn-devel] [PATCH applied] plugin: Remove GNUism in openvpn-plugin.h generation

2017-01-27 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I reworded the commit message slightly, as this isn't strictly bound to out-of-tree builds (which the original commit message stated), but related to GNU extensions in the Makefile which fails on non-GNU Make. Your patch has been applied to the

Re: [Openvpn-devel] [PATCH] Resolve several travis-ci issues

2017-01-27 Thread Илья Шипицин
please, ignore it. I will send v2 soon Пт, 27 янв. 2017 г. в 18:53, Ilya Shipitsin : > MBEDTLS_VERSION, OPENSSL_VERSION were defined twice - in both > .travis.yml and .travis/build-deps.sh files, the last one > defined OPENSSL_VERSION via nonexistent OPENSSL_VERION >

[Openvpn-devel] [PATCH] plugin: Improve the handling of default plug-in directory

2017-01-27 Thread David Sommerseth
OpenVPN uses a default plug-in directore, set using PLUGINDIR when running ./configure. If this is set, it will use $LIBDIR/openvpn/plugin. When using --plugin, OpenVPN will load plug-ins from this directory with the only exception if the plug-in filename is based on an absolute path. Any other

Re: [Openvpn-devel] [PATCH] Resolving several travis-ci issues:

2017-01-27 Thread Илья Шипицин
2017-01-26 0:21 GMT+05:00 David Sommerseth < open...@sf.lists.topphemmelig.net>: > On 10/01/17 09:04, Ilya Shipitsin wrote: > > * moving LD_LIBRARY_PATH as far as possible (otherwise "wget" picks it, > which is not desirable) > > * split LD_LIBRARY_PATH into LD_LIBRARY_PATH/DYLD_LIBRARY_PATH >

[Openvpn-devel] [PATCH] Resolve several travis-ci issues

2017-01-27 Thread Ilya Shipitsin
MBEDTLS_VERSION, OPENSSL_VERSION were defined twice - in both .travis.yml and .travis/build-deps.sh files, the last one defined OPENSSL_VERSION via nonexistent OPENSSL_VERION variable, which lead us to use openssl-1.0.1 instead of openssl-1.0.2, I removed variable definition from build-deps.sh

Re: [Openvpn-devel] [PATCH 1/1] remove GNUism and fix out-of-tree build

2017-01-27 Thread Gert Doering
Hi, On Fri, Jan 27, 2017 at 09:49:27AM +0100, Christian Hesse wrote: > From: Christian Hesse > > The plugin path handling cleanup (4590c383) introduced GNUism and broke > out-of-tree builds. > > Revert back to let configure generate the header file. Instead let make > add an

[Openvpn-devel] [PATCH 1/1] remove GNUism and fix out-of-tree build

2017-01-27 Thread Christian Hesse
From: Christian Hesse The plugin path handling cleanup (4590c383) introduced GNUism and broke out-of-tree builds. Revert back to let configure generate the header file. Instead let make add an extra CFLAG that defines PLUGIN_LIBDIR. Signed-off-by: Christian Hesse