Hello Steffan, 2017-02-10 22:20 GMT+01:00 Steffan Karger <stef...@karger.me>: > > The code change looks good to me, so ACK to that.
Thanks! > The commit does need a better commit message though, and somewhere in > the process the newlines got mangled. I think the commit message of > your initial patch is okay, it just missed the Signed-off-by line. To > smoothen the patch application process, could you create a commit with > the above change, and send it to the list using git send-email? The > command line would be something like: > > git send-email --to=openvpn-devel@lists.sourceforge.net HEAD~1 > > Otherwise, Gert or David will have to wrestle a commit together from you > various messages, and that will likely take more time before it gets > applied. Sure, I'm sorry the patch got messed up and seems GMail also added the message I was responding to at the bottom :-/ I'll be sending the patch with "git format-patch" + "git send-email" as I have three commits and I'm not sure how to send a single patch with only "git send-email" Best Regards, Olivier ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel