[Openvpn-devel] [PATCH applied] Re: Fix non-C99-compliant builds: don't use const size_t as array length

2017-03-16 Thread Gert Doering
ACK, thanks ("stared at code, ran my test suite"). Your patch has been applied to the master and release/2.4 branch. Hopefully this should build with MSVC now :-) commit db1b4d96bfe7e744a0dec8f86cb041c32fb87964 (master) commit ce40258ddd0170df60633baab2c3d17f2c104671 (release/2.4) Author: Steffa

[Openvpn-devel] [PATCH] Fix non-C99-compliant builds: don't use const size_t as array length

2017-03-16 Thread Steffan Karger
Signed-off-by: Steffan Karger --- src/openvpn/crypto_openssl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c index 5f28391..9139480 100644 --- a/src/openvpn/crypto_openssl.c +++ b/src/openvpn/crypto_openssl.c @

[Openvpn-devel] [PATCH applied] Re: CRL: use time_t instead of struct timespec to store last mtime

2017-03-16 Thread Gert Doering
ACK, thanks. Tested on FreeBSD, unsurprisingly no problems. Your patch has been applied to the master and release/2.4 branch. commit f3705dd1e711ee9f8546b841e4b18e9e9a224975 (master) commit 633138564d611b5abeff232c89dccb1b86def449 (release/2.4) Author: Antonio Quartulli Date: Thu Mar 16 16:21:

[Openvpn-devel] [PATCH] CRL: use time_t instead of struct timespec to store last mtime

2017-03-16 Thread Antonio Quartulli
As of now, we store the last mtime for the CRL file in a timespec object. However we store seconds only and we ignore the subsecond field (this came into being because not all platforms have nanoseconds precision in timespec). Given the above, we can safely replace the timespec object with a simpl

Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

2017-03-16 Thread Gert Doering
Hi, On Thu, Mar 16, 2017 at 03:35:35PM +0800, Antonio Quartulli wrote: > If there is no objection, I'll send a patch for this. Please do. We only check seconds today anyway - plus file size(!), so I'm not really seeing a scenario where a CRL file gets refreshed more than once per second but the

[Openvpn-devel] [PATCH applied] Re: Fix Building Using MSVC

2017-03-16 Thread Gert Doering
ACK, thanks. Your patch has been applied to the master and release/2.4 branch. I've taken the commit message from v1 so there's a bit more explanation. Also, I had to fix quite a bit of whitespace changes - lines in the config-msvc-version.h patch got wrapped, and all context lines got a extra b

Re: [Openvpn-devel] [PATCH] Fix Building Using MSVC

2017-03-16 Thread Antonio Quartulli
On Wed, Mar 15, 2017 at 10:00:47PM +0100, Gert Doering wrote: > > diff --git a/src/openvpn/ssl_openssl.h b/src/openvpn/ssl_openssl.h > > index c64c65f..a974e7e 100644 > > --- a/src/openvpn/ssl_openssl.h > > +++ b/src/openvpn/ssl_openssl.h > > @@ -49,7 +49,11 @@ > >*/ > > struct tls_root_ctx {