[Openvpn-devel] [PATCH applied] Re: Undo cipher push in client options state if cipher is rejected

2017-06-29 Thread Gert Doering
ACK. Counting in Arne's ACK as well, as v2 is basically the same actual code change, and the "const" change does not have any further effect ("options" is not const in the callers). Your patch has been applied to the master and release/2.4 branch. commit

[Openvpn-devel] [PATCH applied] Re: OpenSSL: remove EVP_CIPHER_CTX_free() from the compat layer

2017-06-29 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch. commit 7ee9a94fcbbde941bfed167229a64df0f7cdae0b (master) commit ebb5c70bf6acede8d941687ae0e40d827003fb2e (release/2.4) Author: Emmanuel Deloget Date: Thu Jun 29 16:21:19 2017 +0200 OpenSSL: remove EVP_CIPHER_CTX_free() from

[Openvpn-devel] [PATCH applied] Re: doc: The CRL processing is not a deprecated feature

2017-06-29 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch. commit f9ebfe1b5a011e55fb87a5026b1897c8ffb8f75e (master) commit 67e3f0280937757ce716211829c82c3795d21ad1 (release/2.4) Author: David Sommerseth Date: Wed Jun 28 21:15:38 2017 +0200 doc: The CRL processing is not a

[Openvpn-devel] [PATCH applied] Re: OpenSSL: remove EVP_CIPHER_CTX_new() from the compat layer

2017-06-29 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch. commit a72d21a56a0223b8a50d05d88af64abcda0fc5dc (master) commit 0f9575852bc981e75884d1a75b2e7c1f9af091f4 (release/2.4) Author: Emmanuel Deloget Date: Thu Jun 29 16:21:18 2017 +0200 OpenSSL: remove EVP_CIPHER_CTX_new() from

Re: [Openvpn-devel] [PATCH] show the right string for key-direction

2017-06-29 Thread Steffan Karger
On 28-06-17 23:05, Arne Schwabe wrote: > --- > src/openvpn/options.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/options.c b/src/openvpn/options.c > index 61af6e3a..d8049e76 100644 > --- a/src/openvpn/options.c > +++ b/src/openvpn/options.c > @@ -1697,7

Re: [Openvpn-devel] [PATCH 1/2] OpenSSL: remove EVP_CIPHER_CTX_new() from the compat layer

2017-06-29 Thread Steffan Karger
Hi, On 29-06-17 16:21, Emmanuel Deloget wrote: > For unknown reason, the write of the compat layer seemed to think that > this function was only present in OpenSSL 1.1. This is not the case at > all, since it has been introduced in OpenSSL before version 0.9.8. > > Thus, there is no need to add

Re: [Openvpn-devel] [PATCH 1/2] OpenSSL: remove EVP_CIPHER_CTX_new() from the compat layer

2017-06-29 Thread Emmanuel Deloget
Hi, For the two patches in this series, I failed to correctly write "writer", which I spelled "write", sorry for that. And sorry to said writer for the gratuitous attack (but then, I'm me, and I'm pretty sure I'll be able to handle that). And I forgot to mention that the EVP_CIPHER_CTX_free()

[Openvpn-devel] [PATCH 2/2] OpenSSL: remove EVP_CIPHER_CTX_free() from the compat layer

2017-06-29 Thread Emmanuel Deloget
For unknown reason, the write of the compat layer seemed to think that this function was only present in OpenSSL 1.1. This is not the case at all, since it has been introduced in OpenSSL before version 0.9.8. Thus, there is no need to add this function to the compat layer, and it can be safely

[Openvpn-devel] [PATCH 1/2] OpenSSL: remove EVP_CIPHER_CTX_new() from the compat layer

2017-06-29 Thread Emmanuel Deloget
For unknown reason, the write of the compat layer seemed to think that this function was only present in OpenSSL 1.1. This is not the case at all, since it has been introduced in OpenSSL before version 0.9.8. Thus, there is no need to add this function to the compat layer, and it can be safely