Re: [Openvpn-devel] [PATCH] fix compilation for --disable-multi

2017-07-12 Thread Илья Шипицин
2017-07-13 11:46 GMT+05:00 Antonio Quartulli : > > > On 13/07/17 14:45, Antonio Quartulli wrote: > > $ git tag --contains eed9b8eec911a26a952f07ad18d4397c334ac089 > > v2.3.10 > > v2.3.11 > > v2.3.12 > > v2.3.13 > > v2.3.14 > > v2.3.15 > > v2.3.16 > > v2.3.17 > > v2.3.2 > > v2.3.3 > > v2.3.4 > > v2

Re: [Openvpn-devel] [PATCH] fix compilation for --disable-multi

2017-07-12 Thread Antonio Quartulli
On 13/07/17 14:45, Antonio Quartulli wrote: > $ git tag --contains eed9b8eec911a26a952f07ad18d4397c334ac089 > v2.3.10 > v2.3.11 > v2.3.12 > v2.3.13 > v2.3.14 > v2.3.15 > v2.3.16 > v2.3.17 > v2.3.2 > v2.3.3 > v2.3.4 > v2.3.5 > v2.3.6 > v2.3.7 > v2.3.8 > v2.3.9 > > > Hence, 2.3 is broken starting

Re: [Openvpn-devel] [PATCH] fix compilation for --disable-multi

2017-07-12 Thread Antonio Quartulli
On 13/07/17 14:34, Илья Шипицин wrote: > 2017-07-13 11:16 GMT+05:00 Samuli Seppänen : > >> On 13/07/2017 09:05, Antonio Quartulli wrote: >>> On 13/07/17 14:02, Илья Шипицин wrote: Should we add --disable-multi to some travis-ci build ? >>> >>> Might be a good idea. It was actually broken si

Re: [Openvpn-devel] [PATCH] fix compilation for --disable-multi

2017-07-12 Thread Илья Шипицин
2017-07-13 11:16 GMT+05:00 Samuli Seppänen : > On 13/07/2017 09:05, Antonio Quartulli wrote: > > On 13/07/17 14:02, Илья Шипицин wrote: > >> Should we add --disable-multi to some travis-ci build ? > > > > Might be a good idea. It was actually broken since 2013, therefore it > > seems like not many

Re: [Openvpn-devel] [PATCH] fix compilation for --disable-multi

2017-07-12 Thread Samuli Seppänen
On 13/07/2017 09:05, Antonio Quartulli wrote: > On 13/07/17 14:02, Илья Шипицин wrote: >> Should we add --disable-multi to some travis-ci build ? > > Might be a good idea. It was actually broken since 2013, therefore it > seems like not many people are using iteither we drop it or yes, we > sh

Re: [Openvpn-devel] [PATCH] fix compilation for --disable-multi

2017-07-12 Thread Antonio Quartulli
On 13/07/17 14:02, Илья Шипицин wrote: > Should we add --disable-multi to some travis-ci build ? Might be a good idea. It was actually broken since 2013, therefore it seems like not many people are using iteither we drop it or yes, we should have some automated test. Cheers, -- Antonio Qua

Re: [Openvpn-devel] [PATCH] fix compilation for --disable-multi

2017-07-12 Thread Илья Шипицин
Should we add --disable-multi to some travis-ci build ? 13 июл. 2017 г. 8:41 пользователь "Antonio Quartulli" написал: > Due to the introduction of the options.pull attribute and the > ncp logic, various parts of the code try to access members > that are not available when --disable-multi is sel

[Openvpn-devel] [PATCH] fix compilation for --disable-multi

2017-07-12 Thread Antonio Quartulli
Due to the introduction of the options.pull attribute and the ncp logic, various parts of the code try to access members that are not available when --disable-multi is selected. Avoid such issue by placing several "#if P2MP" around the faulty code. Introduced-by: 598e03f0e7bc ("Always push basic

Re: [Openvpn-devel] [PATCH] win32 build: check for ENETUNREACH

2017-07-12 Thread Илья Шипицин
2017-07-12 20:06 GMT+05:00 Selva Nair : > > On Wed, Jul 12, 2017 at 10:45 AM, Илья Шипицин > wrote: > >> 2017-07-12 18:54 GMT+05:00 Selva Nair : >> >>> >>> On Wed, Jul 12, 2017 at 4:46 AM, Илья Шипицин >>> wrote: >>> No interest ? 9 июл. 2017 г. 19:46 пользователь "Ilya Shipitsin"

Re: [Openvpn-devel] [PATCH] win32 build: check for ENETUNREACH

2017-07-12 Thread Selva Nair
On Wed, Jul 12, 2017 at 10:45 AM, Илья Шипицин wrote: > 2017-07-12 18:54 GMT+05:00 Selva Nair : > >> >> On Wed, Jul 12, 2017 at 4:46 AM, Илья Шипицин >> wrote: >> >>> No interest ? >>> >>> 9 июл. 2017 г. 19:46 пользователь "Ilya Shipitsin" >>> написал: >>> Currently, we do not check for mi

Re: [Openvpn-devel] [PATCH] win32 build: check for ENETUNREACH

2017-07-12 Thread Илья Шипицин
2017-07-12 13:59 GMT+05:00 Arne Schwabe : > Am 12.07.17 um 10:46 schrieb Илья Шипицин: > > No interest ? > > > > We are slow, you should know that by now. The code looks code so from > that it looks good. If we get an ACK from someone who testedthis I think > then it is safe to merge. > I tested

Re: [Openvpn-devel] [PATCH] win32 build: check for ENETUNREACH

2017-07-12 Thread Arne Schwabe
Am 12.07.17 um 10:46 schrieb Илья Шипицин: > No interest ? > We are slow, you should know that by now. The code looks code so from that it looks good. If we get an ACK from someone who testedthis I think then it is safe to merge. Arne ---

Re: [Openvpn-devel] [PATCH] win32 build: check for ENETUNREACH

2017-07-12 Thread Илья Шипицин
No interest ? 9 июл. 2017 г. 19:46 пользователь "Ilya Shipitsin" написал: > Currently, we do not check for mingw-gcc version. For example, > Debian 7 is shipped with 4.6.3, which does not know about ENETUNREACH > --- > > this is for 2.4 and HEAD branches > > configure.ac | 14 ++ >