Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Antonio Quartulli
On 25/08/17 04:21, David Sommerseth wrote: > On 24/08/17 21:18, Gert Doering wrote: >> (gen-release-tarballs.sh only needs to work on FreeBSD and Linux, and >> FreeBSD's /bin/sh is sufficiently modern so so it's likely to work >> - but the test scripts need to run robustly everywhere a user

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread David Sommerseth
On 24/08/17 21:18, Gert Doering wrote: > (gen-release-tarballs.sh only needs to work on FreeBSD and Linux, and > FreeBSD's /bin/sh is sufficiently modern so so it's likely to work > - but the test scripts need to run robustly everywhere a user builds, > so never assume "because bash says so!" is

Re: [Openvpn-devel] [PATCH v2] bash: substitute legacy `` with modern $()

2017-08-24 Thread Gert Doering
Hi, On Thu, Aug 24, 2017 at 09:38:45PM +0800, Antonio Quartulli wrote: > The backquotes for command substitution in bash are > considered old-style in favour of the more modern $() [1]. > Substitute them. > >

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Gert Doering
Hi, On Thu, Aug 24, 2017 at 09:33:05PM +0800, Antonio Quartulli wrote: > The backquotes for command substitution in bash are > considered old-style in favour of the more modern $() [1]. > Substitute them. > >

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread Christian Hesse
David Sommerseth on Thu, 2017/08/24 20:16: > On 24/08/17 09:57, Antonio Quartulli wrote: > > My effort in writing the commit message has been quite poor. > > > > The assignment is useless because 'ret' is re-assigned a few lines later > > without ever being

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread Christian Hesse
David Sommerseth on Thu, 2017/08/24 20:51: > On 24/08/17 20:40, Antonio Quartulli wrote: > > > > > > On 25/08/17 02:40, Christian Hesse wrote: > >> David Sommerseth on Thu, 2017/08/24 > >> 20:16: > >>> On 24/08/17 09:57,

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Antonio Quartulli
On 25/08/17 02:06, David Sommerseth wrote: > On 24/08/17 16:42, Antonio Quartulli wrote: >> dev-tools/gen-release-tarballs.sh is only for devs, while >> tests/t_cltsrv.sh is for running some tests, but I am not sure sure how >> the latter would interact with non-linux systems. >> >> Maybe Gert

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread David Sommerseth
On 24/08/17 20:40, Antonio Quartulli wrote: > > > On 25/08/17 02:40, Christian Hesse wrote: >> David Sommerseth on Thu, 2017/08/24 >> 20:16: >>> On 24/08/17 09:57, Antonio Quartulli wrote: My effort in writing the commit message has been quite poor.

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread Antonio Quartulli
On 25/08/17 02:40, Christian Hesse wrote: > David Sommerseth on Thu, 2017/08/24 20:16: >> On 24/08/17 09:57, Antonio Quartulli wrote: >>> My effort in writing the commit message has been quite poor. >>> >>> The assignment is useless because 'ret' is

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread David Sommerseth
On 24/08/17 09:57, Antonio Quartulli wrote: > My effort in writing the commit message has been quite poor. > > The assignment is useless because 'ret' is re-assigned a few lines later > without ever being read. Hmmm. I'm not convinced of this change. But I'm also weird in these cases :) I

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread David Sommerseth
On 24/08/17 16:42, Antonio Quartulli wrote: > dev-tools/gen-release-tarballs.sh is only for devs, while > tests/t_cltsrv.sh is for running some tests, but I am not sure sure how > the latter would interact with non-linux systems. > > Maybe Gert knows(?) Tried running them through ksh or dash?

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Antonio Quartulli
dev-tools/gen-release-tarballs.sh is only for devs, while tests/t_cltsrv.sh is for running some tests, but I am not sure sure how the latter would interact with non-linux systems. Maybe Gert knows(?) Cheers, On 24/08/17 22:37, Илья Шипицин wrote: > openvpn is also built on many non bash

Re: [Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Илья Шипицин
openvpn is also built on many non bash systems. what about them? 24 авг. 2017 г. 18:34 пользователь "Antonio Quartulli" написал: The backquotes for command substitution in bash are considered old-style in favour of the more modern $() [1]. Substitute them.

[Openvpn-devel] [PATCH v2] bash: substitute legacy `` with modern $()

2017-08-24 Thread Antonio Quartulli
The backquotes for command substitution in bash are considered old-style in favour of the more modern $() [1]. Substitute them. [1]https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html#Command-Substitution Signed-off-by: Antonio Quartulli --- v2: added

[Openvpn-devel] [PATCH] bash: substitute legacy `` with modern $()

2017-08-24 Thread Antonio Quartulli
The backquotes for command substitution in bash are considered old-style in favour of the more modern $() [1]. Substitute them. [1]https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html#Command-Substitution Signed-off-by: Antonio Quartulli --- note: I

Re: [Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread Antonio Quartulli
My effort in writing the commit message has been quite poor. The assignment is useless because 'ret' is re-assigned a few lines later without ever being read. Cheers, On 24/08/17 15:53, Antonio Quartulli wrote: > Signed-off-by: Antonio Quartulli > --- > src/openvpn/multi.h |

[Openvpn-devel] [PATCH] fragment.c: simplify boolean expression

2017-08-24 Thread Antonio Quartulli
!A || (A && B) is equivalent to the simpler !A || B therefore it is preferable to use the second version as it is simpler to parse while reading the code. Signed-off-by: Antonio Quartulli --- src/openvpn/fragment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Openvpn-devel] [PATCH] avoid useless assignment

2017-08-24 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli --- src/openvpn/multi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/multi.h b/src/openvpn/multi.h index 5892ac07..6cdb0110 100644 --- a/src/openvpn/multi.h +++ b/src/openvpn/multi.h @@ -633,7 +633,7 @@