Re: [Openvpn-devel] [PATCH v3] Add per session pseudo-random jitter to --reneg-sec intervals

Hi Steffan, While running your v3 version of the patch I found an issue with the modified logging. It gives the following error while building gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include -I../../src/compat -DPLUGIN_LIBDIR=\"/usr/lib64/openvpn/plugins\" -O2 -g -pipe

Re: [Openvpn-devel] [PATCH] Implement "status 4" (JSON) for management interface

On 14/11/17 12:02, Gert Doering wrote: > JSON is very trivial to produce (unlike XML, or netlink). The escaping > rules on producing are also very easy - basically, encode things in double > quotes, and escape the set of { BS, FF, NL, CR, Tab, Backslash, Quote } > with a single backslash before

Re: [Openvpn-devel] [PATCH] Implement "status 4" (JSON) for management interface

Hi, On Tue, Nov 14, 2017 at 3:31 AM, Gert Doering wrote: > Hi, > > On Mon, Nov 13, 2017 at 01:16:46PM +0100, David Sommerseth wrote: >> But we should consider if we want to make use of a JSON library >> producing the JSON streams. The reason is to ensure the output is >>

Re: [Openvpn-devel] [PATCH] Implement "status 4" (JSON) for management interface

Hi, On Tue, Nov 14, 2017 at 11:56:10AM +0100, David Sommerseth wrote: > And to me this feels like it actually contradicts our netlink discussion > on the Hackathon, where you initially wanted to use an external library > ... ;-) It's a matter of complexity. Netlink is binary, complex, and hard

Re: [Openvpn-devel] [PATCH] Implement "status 4" (JSON) for management interface

On 14/11/17 09:31, Gert Doering wrote: > Hi, > > On Mon, Nov 13, 2017 at 01:16:46PM +0100, David Sommerseth wrote: >> But we should consider if we want to make use of a JSON library >> producing the JSON streams. The reason is to ensure the output is >> according to the specification and that

Re: [Openvpn-devel] [PATCH] Implement "status 4" (JSON) for management interface

Hi, On 14/11/17 16:31, Gert Doering wrote: > Hi, > > On Mon, Nov 13, 2017 at 01:16:46PM +0100, David Sommerseth wrote: >> But we should consider if we want to make use of a JSON library >> producing the JSON streams. The reason is to ensure the output is >> according to the specification and

Re: [Openvpn-devel] [PATCH] Implement "status 4" (JSON) for management interface

Hi, On Mon, Nov 13, 2017 at 01:16:46PM +0100, David Sommerseth wrote: > But we should consider if we want to make use of a JSON library > producing the JSON streams. The reason is to ensure the output is > according to the specification and that escaping if contents is > consistent and proper.