[Openvpn-devel] [PATCH applied] Re: Prompt for signature using '>PK_SIGN' if the client supports it

2018-01-29 Thread Gert Doering
Your patch has been applied to the master branch. commit e7995f3c62597eb963483b96db619f3e5cd4cf13 Author: Selva Nair Date: Thu Jan 25 14:41:01 2018 -0500 Prompt for signature using '>PK_SIGN' if the client supports it Signed-off-by: Selva Nair Acked-by:

[Openvpn-devel] [PATCH applied] Re: Add management client version

2018-01-29 Thread Gert Doering
Your patch has been applied to the master branch. commit 686fe9ce54c6913f638b80dd7c28d393aa0cadb1 Author: Selva Nair Date: Thu Jan 25 14:41:00 2018 -0500 Add management client version Signed-off-by: Selva Nair Acked-by: Arne Schwabe

Re: [Openvpn-devel] PATCH v3 1/2] openssl: add engine method for loading the key

2018-01-29 Thread James Bottomley
On Mon, 2018-01-29 at 08:43 +0100, Arne Schwabe wrote: > Am 26.01.18 um 21:30 schrieb James Bottomley: > > > > As well as doing crypto acceleration, engines can also be used to > > load key files.  If the engine is set, and the private key loading > > fails for bio methods, this patch makes

Re: [Openvpn-devel] [PATCH v3 2/3] Allow external EC key through --management-external-key

2018-01-29 Thread Selva Nair
Hi, Thanks for the review and ACK. On Mon, Jan 29, 2018 at 5:18 AM, Arne Schwabe wrote: > Am 25.01.18 um 20:45 schrieb selva.n...@gmail.com: >> From: Selva Nair >> >> - This automatically supports EC certificates through >> --management-external-cert

Re: [Openvpn-devel] patch for openvpn-auth-pam plugin to pass PAM_RHOST variable

2018-01-29 Thread Selva Nair
Hi, Thanks for the patch. But its mangled by the mailer with extra line breaks -- please resend using git-send-email. Anyway, some quick comments On Mon, Jan 29, 2018 at 6:30 AM, Martin T wrote: > Hi! > > Currently openvpn-auth-pam plugin does not set PAM_RHOST(requesting >

Re: [Openvpn-devel] [PATCH 1/1] Update copyright notes

2018-01-29 Thread Selva Nair
Hi, On Mon, Jan 29, 2018 at 3:43 AM, Christian Hesse wrote: > From: Christian Hesse > > Now that the first release in 2018 is imminent let's update > the copyright notes. I think this is a pointless exercise. Copyright starts from the point of creation.

Re: [Openvpn-devel] [PATCH 2/2] Prompt for signature using '>PK_SIGN' if the client supports it

2018-01-29 Thread Selva Nair
Hi, On Mon, Jan 29, 2018 at 3:25 AM, Gert Doering wrote: > Hi, > > On Thu, Jan 25, 2018 at 02:41:01PM -0500, selva.n...@gmail.com wrote: >> From: Selva Nair >> >> - Increase the management version from 1 to 2 >> - If the client announces support for

[Openvpn-devel] patch for openvpn-auth-pam plugin to pass PAM_RHOST variable

2018-01-29 Thread Martin T
Hi! Currently openvpn-auth-pam plugin does not set PAM_RHOST(requesting host) variable. This is needed when for example pam_access.so plugin is used and based on OpenVPN client network, different authentication methods are desired. Proof of concept patch for PAM_RHOST is following: ---

Re: [Openvpn-devel] [PATCH v3 2/3] Allow external EC key through --management-external-key

2018-01-29 Thread Arne Schwabe
Am 25.01.18 um 20:45 schrieb selva.n...@gmail.com: > From: Selva Nair > > - This automatically supports EC certificates through > --management-external-cert > - EC signature request from management is prompted by > >PK_SIGN if the client supports it (or >RSA_SIGN) >

[Openvpn-devel] [PATCH 1/1] Update copyright notes

2018-01-29 Thread Christian Hesse
From: Christian Hesse Now that the first release in 2018 is imminent let's update the copyright notes. Signed-off-by: Christian Hesse --- COPYING | 2 +- ChangeLog

Re: [Openvpn-devel] [PATCH 2/2] Prompt for signature using '>PK_SIGN' if the client supports it

2018-01-29 Thread Arne Schwabe
Am 29.01.18 um 09:25 schrieb Gert Doering: > Hi, > > On Thu, Jan 25, 2018 at 02:41:01PM -0500, selva.n...@gmail.com wrote: >> From: Selva Nair >> >> - Increase the management version from 1 to 2 >> - If the client announces support for management version > 1 >> prompt for

Re: [Openvpn-devel] [PATCH 2/2] Prompt for signature using '>PK_SIGN' if the client supports it

2018-01-29 Thread Gert Doering
Hi, On Thu, Jan 25, 2018 at 02:41:01PM -0500, selva.n...@gmail.com wrote: > From: Selva Nair > > - Increase the management version from 1 to 2 > - If the client announces support for management version > 1 > prompt for signature using >PK_SIGN to which the client >

Re: [Openvpn-devel] [PATCH 2/2] Prompt for signature using '>PK_SIGN' if the client supports it

2018-01-29 Thread Arne Schwabe
Am 25.01.18 um 20:41 schrieb selva.n...@gmail.com: > From: Selva Nair > > - Increase the management version from 1 to 2 > - If the client announces support for management version > 1 > prompt for signature using >PK_SIGN to which the client > responds using 'pk-sig' >