[Openvpn-devel] [PATCHv3] openssl: Fix compilation without deprecated OpenSSL 1.1 APIs

2019-07-12 Thread Rosen Penev
EVP_CIPHER_CTX_init and _cleanup were deprecated in 1.1 and both were replaced with _reset. Also removed initialization with OpenSSL 1.1 as it is no longer needed and causes compilation errors when disabling deprecated APIs. Signed-off-by: Rosen Penev --- v2: Squashed previous patches together.

Re: [Openvpn-devel] [PATCHv2] openssl: Fix compilation without deprecated OpenSSL 1.1 APIs

2019-07-12 Thread Rosen Penev
On Fri, Jun 14, 2019 at 3:38 AM Arne Schwabe wrote: > > Am 04.04.19 um 00:56 schrieb Rosen Penev: > > EVP_CIPHER_CTX_init and _cleanup were deprecated in 1.1 and both were > > replaced with _reset. > > > > Also removed initialization with OpenSSL 1.1 as it is no longer needed and > > causes compil

Re: [Openvpn-devel] RFC: release/2.4 (OpenVPN 2.4.7) patch for building with LibreSSL

2019-07-12 Thread Arne Schwabe
Am 12.07.19 um 18:38 schrieb Matthias Andree: > Am 07.06.19 um 20:26 schrieb Matthias Andree: >> Greetings, >> >> FreeBSD has received a patch contribution to enable OpenVPN 2.4.x to be >> built with LibreSSL. I'm seeking comments, and yes I am aware of >> master's a47508606be2c6359d4b27c3b65b72dfe

Re: [Openvpn-devel] [PATCHv2] openssl: Fix compilation without deprecated OpenSSL 1.1 APIs

2019-07-12 Thread Gert Doering
Hi, On Fri, Jul 12, 2019 at 06:44:06PM +0200, Arne Schwabe wrote: > Looks "wrong" in the sense that it does not match the style we want to > have in openvpn. Indeed. I have seen and used "# cpp-thing" in other projects, but OpenVPN seems to have decided to not use space-indenting for nested #i

Re: [Openvpn-devel] [PATCHv2] openssl: Fix compilation without deprecated OpenSSL 1.1 APIs

2019-07-12 Thread Arne Schwabe
Am 12.07.19 um 18:37 schrieb Matthias Andree: > Am 14.06.19 um 12:38 schrieb Arne Schwabe: >> >>> -#ifndef ENABLE_SMALL >>> +# ifndef ENABLE_SMALL >> The space between # and ifndef looks wrong. > > It's standard C. (Chapter 3.8 in the 1989/1990 standard, chapter 6.10 in > recent editions, I checke

Re: [Openvpn-devel] RFC: release/2.4 (OpenVPN 2.4.7) patch for building with LibreSSL

2019-07-12 Thread Matthias Andree
Am 07.06.19 um 20:26 schrieb Matthias Andree: > Greetings, > > FreeBSD has received a patch contribution to enable OpenVPN 2.4.x to be > built with LibreSSL. I'm seeking comments, and yes I am aware of > master's a47508606be2c6359d4b27c3b65b72dfe4786222 commit description > that claims LibreSSL isn

Re: [Openvpn-devel] [PATCHv2] openssl: Fix compilation without deprecated OpenSSL 1.1 APIs

2019-07-12 Thread Matthias Andree
Am 14.06.19 um 12:38 schrieb Arne Schwabe: > >> -#ifndef ENABLE_SMALL >> +# ifndef ENABLE_SMALL > The space between # and ifndef looks wrong. It's standard C. (Chapter 3.8 in the 1989/1990 standard, chapter 6.10 in recent editions, I checked 1999 and 2017/2018, although worded in a quite convolute