Re: [Openvpn-devel] [PATCH 1/7] Visual Studio: upgrade project files to VS2019

2019-09-18 Thread Lev Stipakov
Hi, Turns out that our build script for windows-nsis/generic doesn't specify any optimization flags. I added -O2 and got 400Mbit/s with mingw, which is better than 340 but worse than VS's 425. Haven't yet checked which flags are used for openssl build. Also adding "-O2" to CFLAGS breaks rc

Re: [Openvpn-devel] [PATCH v7 7/7] Implement unit tests for auth-gen-token

2019-09-18 Thread David Sommerseth
On 17/09/2019 14:33, Arne Schwabe wrote: > From: Arne Schwabe > > The unit test is breaking the 80 char limit in some places > but the remaining lines it breaks the limit I feel > forcing the 80 char limit will impair readibility > > Patch V2: adapt unit tests to other V2 patches > Patch V4:

Re: [Openvpn-devel] [PATCH v7 6/7] Sent indication that a session is expired to clients

2019-09-18 Thread David Sommerseth
On 17/09/2019 14:11, Arne Schwabe wrote: > From: Arne Schwabe > > This allows OpenVPN 3 core to fall back to the original authentication > method. > > This commit changes man_def_auth_set_client_reason to > auth_set_client_reason since it now used in more contexts. > > Also remove a FIXME

[Openvpn-devel] [PATCH applied] Re: tun.h: remove TUN_PASS_BUFFER define

2019-09-18 Thread Gert Doering
Your patch has been applied to the master branch. Not sure if it increades readability very much, given that the functions are still called "..._buffered()", and what they really do is "..._win32_special_asyncio_using_packet_buffer_from_event_loop()" (if I read tun.h/tun.c right). But it's

[Openvpn-devel] [PATCH applied] Re: Fix regression, reinstate LibreSSL support.

2019-09-18 Thread Gert Doering
Your patch has been applied to the release/2.4 branch. Sorry for the delay. Vacation, and too many distractions. Lightly tested on an OpenSSL 1.1, a mbedTLS build and an LibreSSL 2.7.2 on OpenBSD 6.3 - with OpenSSL and mbedTLS, it builds and passes all tests. With LibreSSL 2.7.2, it fails

[Openvpn-devel] [PATCH applied] Re: tun.h: change tun_set() return value type to void

2019-09-18 Thread Gert Doering
Your patch has been applied to the master branch. commit 3d52205097bee3106de9776dae8bcc93eca7ab72 Author: Lev Stipakov Date: Fri Sep 6 18:40:37 2019 +0300 tun.h: change tun_set() return value type to void Signed-off-by: Lev Stipakov Acked-by: Antonio Quartulli Acked-by:

Re: [Openvpn-devel] Removing --disable-server option from OpenVPN

2019-09-18 Thread Jonathan K. Bullard
Oops. On Wed, Sep 18, 2019 at 6:54 AM Jonathan K. Bullard wrote: > > Hi, > > On Wed, Sep 18, 2019 at 6:38 AM Samuli Seppänen wrote: > > > > Hi, > > > > We are considering removing the --disable-server option from OpenVPN in 2.5. > > > > Do you use (and need) it, or know of somebody using (and

Re: [Openvpn-devel] Removing --disable-server option from OpenVPN

2019-09-18 Thread Jonathan K. Bullard
Hi, On Wed, Sep 18, 2019 at 6:38 AM Samuli Seppänen wrote: > > Hi, > > We are considering removing the --disable-server option from OpenVPN in 2.5. > > Do you use (and need) it, or know of somebody using (and needing) it? As far as I know, it is not used by any Tunnelblick users. Also, note

[Openvpn-devel] Summary of the community meeting (18th September 2019)

2019-09-18 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Wednesday 18th September 2019 Time: 11:30 CEST (9:30 UTC) Planned meeting topics for this meeting were here: Your

[Openvpn-devel] Removing --disable-server option from OpenVPN

2019-09-18 Thread Samuli Seppänen
Hi, We are considering removing the --disable-server option from OpenVPN in 2.5. Do you use (and need) it, or know of somebody using (and needing) it? Samuli signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing list