Re: [Openvpn-devel] [PATCH 1/4] Only announce IV_NCP=2 when we are willing to support these ciphers

2020-01-06 Thread Steffan Karger
Hi, Finally found some time to start looking at this patch set. On 17-11-2019 19:12, Arne Schwabe wrote: > We currently always announce IV_NCP=2 when we support these ciphers even > when we do not accept them. This lead to a server pushing a AES-GCM-128 > cipher to clients and the client then

[Openvpn-devel] Community meetings in January 2020

2020-01-06 Thread Samuli Seppänen
Hi, Our community meetings will alternate between Wed 11:30 CET and Thu 20:00 CET. Next meetings have been scheduled to - Wed 8th January 11:30 CET - Thu 16th January 20:00 CET - Wed 22nd January 11:30 CET - Thu 30th January 20:00 CET The place is #openvpn-meeting IRC channel at Freenode.

Re: [Openvpn-devel] [PATCH 1/1] configure.ac: replace set with env

2020-01-06 Thread Christian Hesse
Tom Yan on Mon, 2020/01/06 08:48: > How about printenv (without grep)? The variables are not known in advance. This needs to match all variables starting with "enable_" and "with_". -- main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH" "CX:;",b;for(a/*Best regards

Re: [Openvpn-devel] [PATCH 1/1] configure.ac: replace set with env

2020-01-06 Thread Gert Doering
Hi, On Mon, Jan 06, 2020 at 08:48:00AM +, Tom Yan wrote: > How about printenv (without grep)? Portability. "env |grep" is POSIX standardized so should work everywhere. printenv is a BSD invention, which not all unix variants are required to have. (Besides, printenv on its own cannot do

Re: [Openvpn-devel] [PATCH 1/1] configure.ac: replace set with env

2020-01-06 Thread Tom Yan
How about printenv (without grep)? From: Christian Hesse Sent: Monday, January 6, 2020 4:04:26 PM To: OpenVPN Development Cc: Christian Hesse Subject: [Openvpn-devel] [PATCH 1/1] configure.ac: replace set with env From: Christian Hesse The shell builtin `set`

[Openvpn-devel] [PATCH 1/1] configure.ac: replace set with env

2020-01-06 Thread Christian Hesse
From: Christian Hesse The shell builtin `set` produces different output for different shells: bash$ set | grep '^TERM=' TERM=xterm dash$ set | grep '^TERM=' TERM='xterm' This may break reproducible builds depending on what shell is used. Let's replace `set` with `env`, which is a real command