Re: [Openvpn-devel] Possible memory alignment Problem in 2.4 ?

2020-03-23 Thread Michael Kress
Hi, Unfortunatelly it seems, we are stuck to LZO for now, because it has been configured in the clients, which run 2.3. Most of these clients are offline most of the time, so reconfiguring or upgrading all of them before updating the server will become difficult. You are completely right: One

Re: [Openvpn-devel] Possible memory alignment Problem in 2.4 ?

2020-03-23 Thread Илья Шипицин
thank you for wonderful investigation. however, are there reasons for using lzo ? it consumes too much cpu (comparing to lz4). also, it highly depends on traffic itself, many application already compress their bytes themselves. if you are stick to lzo, because it is propagated to all configs,

[Openvpn-devel] Possible memory alignment Problem in 2.4 ?

2020-03-23 Thread Michael Kress
Hello list, There seems to be some kind of alignment problem in OpenVPN 2.4 versions on ARMv4 based machines (32 bit), especially when lzo compression kicks in. History: We run OpenVPN 2.3 happily on a ARMv4 machine. Now we want to upgrade to 2.4 because of automatically

Re: [Openvpn-devel] [PATCH 09/12] openvpnmsica: Extend to support arbitrary HWID network adapters

2020-03-23 Thread Lev Stipakov
Stared at the code, compiled with msvc. Looks reasonable. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 08/12] openvpnmsica: "TAP" => "TUN/TAP"

2020-03-23 Thread Lev Stipakov
Started at code, compiled with msvc. No functional changes, only renamings. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 07/12] openvpnmsica, tapctl: "interface" => "adapter"

2020-03-23 Thread Lev Stipakov
Stared at code, compiled with msvc. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 06/12] openvpnmsica: Simplify static function names

2020-03-23 Thread Lev Stipakov
Stared and the code, compiled with MSVC. Change makes sense. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 05/12] openvpnmsica: Revise MSI custom actions interop

2020-03-23 Thread Lev Stipakov
Hi, I must say I am not super familiar with this component nor MSI in general. Stared at the code, compiled with MSVC and tested some exported functions with rundll32. This has removed lots of code, so it makes sense, assuming that all required functionality is still in place. It would be nice

[Openvpn-devel] [PATCH applied] Re: tapctl: Add functions for enabling/disabling adapters

2020-03-23 Thread Gert Doering
Your patch has been applied to the master branch. Test built on MinGW. No further review. commit d15bc3ad1be515ed83baf87d025845c9ab8ccc57 Author: Simon Rozman Date: Mon Mar 9 14:17:20 2020 +0100 tapctl: Add functions for enabling/disabling adapters Signed-off-by: Simon Rozman

Re: [Openvpn-devel] [PATCH 04/12] tapctl: Add functions for enabling/disabling adapters

2020-03-23 Thread Lev Stipakov
Stared at the patch, compiled with msvc and smoke-tested (tapctl delete {guid}). New layering (like tap_enable_interface/enable_device/change_device_state/) makes code easy to follow. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list

Re: [Openvpn-devel] OpenVPN git master builds for Fedora/RHEL/CentOS

2020-03-23 Thread Samuli Seppänen
Il 22/03/20 16:38, David Sommerseth ha scritto: > > Hi, > > I've put together a Fedora Copr repository which contains builds of the > OpenVPN 2.x git master; which will contains what will arrive in the next major > release. > > >