Re: [Openvpn-devel] [PATCH v2 1/3] Refactor key_state_export_keying_material functions

2020-08-12 Thread Steffan Karger
Hi, On 12-08-2020 16:01, Arne Schwabe wrote: > This refactors the common code between mbed SSL and OpenSSL into > export_user_keying_material and also prepares the backend functions > to export more than one key. > > Also fix checking the return value of SSL_export_keying_material > only 1 is a s

Re: [Openvpn-devel] [PATCH v2 3/3] Implement generating data channel keys via EKM/RFC 5705

2020-08-12 Thread tincanteksup
typos/grammar On 12/08/2020 15:01, Arne Schwabe wrote: OpenVPN currently uses its own (based on TLS 1.0) key derivation mechansim to generate the 256 bytes key data in key2 struct that mechansim -> mechanism are then used used to generate encryption/hmac/iv vectors. While this mechanism is

Re: [Openvpn-devel] [PATCH v2 1/3] Refactor key_state_export_keying_material functions

2020-08-12 Thread tincanteksup
typo On 12/08/2020 15:01, Arne Schwabe wrote: This refactors the common code between mbed SSL and OpenSSL into export_user_keying_material and also prepares the backend functions to export more than one key. Also fix checking the return value of SSL_export_keying_material only 1 is a sucess, -1

[Openvpn-devel] [PATCH v2 3/3] Implement generating data channel keys via EKM/RFC 5705

2020-08-12 Thread Arne Schwabe
OpenVPN currently uses its own (based on TLS 1.0) key derivation mechansim to generate the 256 bytes key data in key2 struct that are then used used to generate encryption/hmac/iv vectors. While this mechanism is still secure, it is not state of the art. Instead of modernisating our own approach,

[Openvpn-devel] [PATCH v2 2/3] Move openvpn specific key expansion into its own function

2020-08-12 Thread Arne Schwabe
This moves the OpenVPN specific PRF into its own function also simplifies the code a bit by passing tls_session directly instead of 5 of its fields. Signed-off-by: Arne Schwabe Patch V2: Rebase --- src/openvpn/ssl.c | 109 +- 1 file changed, 69 insert

[Openvpn-devel] [PATCH v2 1/3] Refactor key_state_export_keying_material functions

2020-08-12 Thread Arne Schwabe
This refactors the common code between mbed SSL and OpenSSL into export_user_keying_material and also prepares the backend functions to export more than one key. Also fix checking the return value of SSL_export_keying_material only 1 is a sucess, -1 is also an error. Signed-off-by: Arne Schwabe

Re: [Openvpn-devel] [PATCH 1/3] Refactor key_state_export_keying_material functions

2020-08-12 Thread Steffan Karger
Hi, Couldn't resist giving this a quick look. Feature-ACK on the patch set, but some comments on the approach: On 12-08-2020 10:55, Arne Schwabe wrote: > This refactors the common code between mbed SSL and OpenSSL into > export_user_keying_material and also prepares the backend functions > to ex

[Openvpn-devel] [PATCH applied] Re: Improve sections about older OpenVPN clients in cipher-negotiation.rst

2020-08-12 Thread Gert Doering
Acked-by: Gert Doering Good work, Richard and Arne, thanks! Your patch has been applied to the master branch. commit 9262f1454d78157226f20b15a374f3c750e19cdd Author: Arne Schwabe Date: Wed Aug 12 10:54:12 2020 +0200 Improve sections about older OpenVPN clients in cipher-negotiation.rst

Re: [Openvpn-devel] [PATCH] Workaround FreeBSD 12+ race condition on tun/tap open with IPv6.

2020-08-12 Thread Arne Schwabe
Am 23.07.20 um 14:19 schrieb Gert Doering: > On FreeBSD 12 (tested and verified on 12.1-RELEASE-p2), after "ifconfig > inet6" for a tun/tap interface, there sometimes is a race condition > where the "IFDISABLED" flag shows up after a short time frame, under > a second, and never clears itself. Thi

[Openvpn-devel] [PATCH] Improve sections about older OpenVPN clients in cipher-negotiation.rst

2020-08-12 Thread Arne Schwabe
- Explain the IV_NCP=2 client situation in 2.4 a bit better. - Make more clear what exact versions are meant in the old client section - add a missing - in a heading Thanks to Richard Bohnhomme for initial proof reading. Signed-off-by: Arne Schwabe --- doc/man-sections/cipher-negotiation.rst

[Openvpn-devel] [PATCH 2/3] Move openvpn specific key expansion into its own function

2020-08-12 Thread Arne Schwabe
This moves the OpenVPN specific PRF into its own function also simplifies the code a bit by passing tls_session directly instead of 5 of its fields. Signed-off-by: Arne Schwabe --- src/openvpn/ssl.c | 109 +- 1 file changed, 69 insertions(+), 40 deleti

[Openvpn-devel] [PATCH 3/3] Implement generating data channel keys via EKM/RFC 5705

2020-08-12 Thread Arne Schwabe
OpenVPN currently uses its own (based on TLS 1.0) key derivation mechansim to generate the 256 bytes key data in key2 struct that are then used used to generate encryption/hmac/iv vectors. While this mechanism is still secure, it is not state of the art. Instead of modernisating our own approach,

[Openvpn-devel] [PATCH 1/3] Refactor key_state_export_keying_material functions

2020-08-12 Thread Arne Schwabe
This refactors the common code between mbed SSL and OpenSSL into export_user_keying_material and also prepares the backend functions to export more than one key. Also fix checking the return value of SSL_export_keying_material only 1 is a sucess, -1 is also an error. Signed-off-by: Arne Schwabe