[Openvpn-devel] [PATCH applied] Re: openvpnmsica: make adapter renaming non-fatal

[Gert Doering]

Your patch has been applied to the master and release/2.5 branch.

Thanks for coming up with the solution & testing & reviewing it!

The comment line is a bit long... uncrustify will catch it next time.

I have not tested anything, trusting Lev and Simon here :-)  (but
from a cursory glance, the change looks nice and reasonable)

commit b341b1c596931f8a1f77f054ba505b5c1e3547be (master)
commit 567e277f1cbaa8059319a8feea4c08edf77b6a5a (release/2.5)
Author: Lev Stipakov
Date:   Thu Sep 3 00:36:43 2020 +0300

 openvpnmsica: make adapter renaming non-fatal

 Signed-off-by: Lev Stipakov 
 Acked-by: Simon Rozman 
 Message-Id: <20200902213643.401-1-lstipa...@gmail.com>
 URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20875.html
 Signed-off-by: Gert Doering 


--
kind regards,

Gert Doering



___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] New man-section pages format

[tincanteksup]

On 04/09/2020 14:36, David Sommerseth wrote:

On 04/09/2020 15:21, tincanteksup wrote:

Hi,

this is just something to chew-over..

See:
https://github.com/OpenVPN/openvpn/blob/master/doc/man-sections/generic-options.rst


I noticed that generally the option names, eg: --auth-nocache, wrap and the
result is unpleasant.

However, further down that same page --daemon progname does not wrap and looks
much nicer.

I know which format I prefer, perhaps this can be changed..


Do you mean the wrapping in the HTML rendering on GitHub?  That can only be
changed by changing the number of characters in the option.  It's not
something we control, it's the GitHub .rst rendering.

$ echo -n "--daemon progname" | wc -c
17
$ echo -n "--auth-nocache" | wc -c
14

IIRC, the limit is more than 16 characters, and the option gets a cell on a
single line.

Now, if you find a setting we can tweak (even a .. notation in the .rst files)
where we can reduce this limit to 2 character (which means all options gets
its own line - which will be consistent all over), I'm open to consider that.
  I haven't had time to dig into it.

But I agree, the wrapping is not nice at all.  That said, we have had more
focus on ensuring the man/*roff rendering looks nice and reasonable more than
the HTML rendering on GitHub - in addition files which are more easy to edit
in a text editor.  After all, the HTML rendering was just a bonus over the .8
rendering [1] on GitHub before the .rst conversion.

[1] 




Thanks David, I'll see what, if anything, can be done to wrestle github 
into submission ;-)





___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel




___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: In tap.c use DiInstallDevice to install the driver on a new adapter

[Gert Doering]

Your patch has been applied to the master and release/2.5 branch.

Minor typo in commit message ("instalaltion") fixed.

(I have not tested anything, fully trusting you and Lev here - thanks!)

commit f3f09541dcff3f0b307067bdf5dcaabc530db4c7 (master)
commit 87b43ded380af06129ea59744d27684e36635c74 (release/2.5)
Author: Selva Nair
Date:   Thu Sep 3 19:56:44 2020 -0400

 In tap.c use DiInstallDevice to install the driver on a new adapter

 Signed-off-by: Selva Nair 
 Acked-by: Lev Stipakov 
 Message-Id: <1599177404-29996-1-git-send-email-selva.n...@gmail.com>
 URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20880.html
 Signed-off-by: Gert Doering 


--
kind regards,

Gert Doering



___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] New man-section pages format

[David Sommerseth]

On 04/09/2020 15:21, tincanteksup wrote:
> Hi,
> 
> this is just something to chew-over..
> 
> See:
> https://github.com/OpenVPN/openvpn/blob/master/doc/man-sections/generic-options.rst
> 
> 
> I noticed that generally the option names, eg: --auth-nocache, wrap and the
> result is unpleasant.
> 
> However, further down that same page --daemon progname does not wrap and looks
> much nicer.
> 
> I know which format I prefer, perhaps this can be changed..

Do you mean the wrapping in the HTML rendering on GitHub?  That can only be
changed by changing the number of characters in the option.  It's not
something we control, it's the GitHub .rst rendering.

$ echo -n "--daemon progname" | wc -c
17
$ echo -n "--auth-nocache" | wc -c
14

IIRC, the limit is more than 16 characters, and the option gets a cell on a
single line.

Now, if you find a setting we can tweak (even a .. notation in the .rst files)
where we can reduce this limit to 2 character (which means all options gets
its own line - which will be consistent all over), I'm open to consider that.
 I haven't had time to dig into it.

But I agree, the wrapping is not nice at all.  That said, we have had more
focus on ensuring the man/*roff rendering looks nice and reasonable more than
the HTML rendering on GitHub - in addition files which are more easy to edit
in a text editor.  After all, the HTML rendering was just a bonus over the .8
rendering [1] on GitHub before the .rst conversion.

[1] 


-- 
kind regards,

David Sommerseth
OpenVPN Inc




signature.asc
Description: OpenPGP digital signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] New man-section pages format

[Илья Шипицин]

I thought of using autogen. No time yet

On Fri, Sep 4, 2020, 4:23 PM tincanteksup  wrote:

> Hi,
>
> this is just something to chew-over..
>
> See:
>
> https://github.com/OpenVPN/openvpn/blob/master/doc/man-sections/generic-options.rst
>
> I noticed that generally the option names, eg: --auth-nocache, wrap and
> the result is unpleasant.
>
> However, further down that same page --daemon progname does not wrap and
> looks much nicer.
>
> I know which format I prefer, perhaps this can be changed..
>
> BR
> Richard
>
>
> ___
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] New man-section pages format

[tincanteksup]

Hi,

this is just something to chew-over..

See: 
https://github.com/OpenVPN/openvpn/blob/master/doc/man-sections/generic-options.rst


I noticed that generally the option names, eg: --auth-nocache, wrap and 
the result is unpleasant.


However, further down that same page --daemon progname does not wrap and 
looks much nicer.


I know which format I prefer, perhaps this can be changed..

BR
Richard


___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] In tap.c use DiInstallDevice to install the driver on a new adapter

[Lev Stipakov]

Hi,

> +HMODULE libnewdev = NULL;

I think we are moving to C99 so this could be defined closer to actual usage.

Tested with MSVC and mingw - compiled, built installer - installed -
tested that tapctl creates
adapters which then can be used by non-admin users.

Acked-by: Lev Stipakov 

--
-Lev


___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel