Re: [Openvpn-devel] [PATCH applied] Re: platform: Retain CAP_NET_ADMIN when dropping privileges

2022-08-16 Thread Steffan Karger
Hi, On Mon, 15 Aug 2022 at 12:50, Gert Doering wrote: > On Mon, Aug 15, 2022 at 12:40:55PM +0200, Timo Rothenpieler wrote: > > or don't even try to retain capabilities, since > > they're not needed either way. I'd prefer the later, since fewer > > capabilities is generally better. > > I could

Re: [Openvpn-devel] [PATCH applied] Re: platform: Retain CAP_NET_ADMIN when dropping privileges

2022-08-16 Thread Gert Doering
Hi, On Tue, Aug 16, 2022 at 11:16:50AM +0200, Steffan Karger wrote: > So I'm really not in favour of retaining CAP_NET_ADMIN "just in case". > I would even like to be able to not retain it at all. I hear what you say, and I support that line of thought. Alas, with current Linux-DCO, we need

Re: [Openvpn-devel] [PATCH applied] Re: platform: Retain CAP_NET_ADMIN when dropping privileges

2022-08-16 Thread Gert Doering
Hi, On Mon, Aug 15, 2022 at 11:54:21AM +0200, Gert Doering wrote: > [..] > > commit 2e359a088226ab1e5ee41fbab27d38d8a8d192ac > > Author: Timo Rothenpieler > > Date: Sat May 14 12:37:17 2022 +0200 > > > > platform: Retain CAP_NET_ADMIN when dropping privileges > > Unfortunately, it seems

Re: [Openvpn-devel] [PATCH v3] Add example script demonstrating TOTP via auth-pending

2022-08-16 Thread Heiko Hund
On Donnerstag, 4. März 2021 12:40:18 CEST Arne Schwabe wrote: > + For a sample script that implement TOTP (RFC 6238) based two-factor > + authentication, see :code:`sample-scripts/totp.py`. This filename doesn't match with below. > diff --git a/sample/sample-scripts/totpauth.py >

[Openvpn-devel] [PATCH applied] Re: tun: properly handle device interface list

2022-08-16 Thread Gert Doering
Did a bit of "staring at the code", all looks quite reasonable. My Ubuntu 18/mingw test rig exploded after commit 2e359a088226a (for the "make dist" part, it requires libpcap-ng-dev, but apt refuses to install that...) so I could not compile-test. Commit message extended with "use