[Openvpn-devel] [PATCH applied] Re: documentation: avoid recommending --user nobody

2022-12-01 Thread Gert Doering
Acked-by: Gert Doering "This is the new style nobody, so yes" We might have a word with package maintainers to ensure that a user "openvpn" is actually created... this is something inside our repo, but actual talking to actual people ;-) Your patch has been applied to the master branch.

[Openvpn-devel] [PATCH applied] Re: dco: disable dco on Windows if --remote is not defined

2022-12-01 Thread Gert Doering
Acked-by: Gert Doering "DCO WIN wants to do outgoing stuff", no server, no no-remote - so yes, makes sense. Your patch has been applied to the master branch. commit fd1c460ccfa38ca03e40e05524e2627917c58647 Author: Lev Stipakov Date: Thu Dec 1 14:59:02 2022 +0200 dco: disable dco on

[Openvpn-devel] [PATCH applied] Re: Allow reconnecting in p2p mode work under FreeBSD

2022-12-01 Thread Gert Doering
Acked-by: Gert Doering Indeed, that fixes the p2p dco reconnect problem we had with FreeBSD, and with "verb 6" debugging one can nicely see what happens: 14:28:55 P2P mode NCP negotiation result: TLS_export=1, DATA_v2=1, peer-id 10167064, cipher=AES-256-GCM reconnect, then 14:29:17 P2P mode

Re: [Openvpn-devel] [PATCH v14] Add DNS SRV remote host discovery support

2022-12-01 Thread Frank Lichtenheld
Smaller nitpicks: On Wed, Nov 30, 2022 at 09:57:18PM +0100, Gert Doering wrote: > From: Vladislav Grishenko [...] > diff --git a/src/openvpn/init.c b/src/openvpn/init.c > index c2154b8d..3a70748e 100644 > --- a/src/openvpn/init.c > +++ b/src/openvpn/init.c > @@ -350,7 +350,12 @@

Re: [Openvpn-devel] [PATCH applied openvpn3-linux] tests: platforminfo: skip DBus test if hostname service isn't available

2022-12-01 Thread Frans Klaver
On Thu, Dec 1, 2022 at 1:44 PM David Sommerseth wrote: > > From: David Sommerseth > > Thanks a lot! This patch was a by the book in every possible way, so > this was really easy to review and apply. > > Acked-by: David Sommerseth The submission instructions were pretty clear. That helps.

Re: [Openvpn-devel] [PATCH v14] Add DNS SRV remote host discovery support

2022-12-01 Thread Frank Lichtenheld
server --comp-lzo --verb 3 --dev tun --proto tcp4 --r\ emote-srv lichtenheld.net --writepid ../tests/t_client-flichtenheld-TUXEDO-InfinityBook-S-15-17-Gen7\ -20221201-141818/openvpn-1.pid --setenv TESTNUM 1 --setenv TOP_BUILDDIR .. --script-security 2 --up \ ./update_t_client_ips.sh 2022-12-01 14

[Openvpn-devel] [PATCH] dco: disable dco on Windows if --remote is not defined

2022-12-01 Thread Lev Stipakov
From: Lev Stipakov At the moment Windows driver requires remote to work. Signed-off-by: Lev Stipakov --- src/openvpn/dco.c | 8 1 file changed, 8 insertions(+) diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index 47fb0003..19a449ba 100644 --- a/src/openvpn/dco.c +++

Re: [Openvpn-devel] [PATCH applied openvpn3-linux] tests: platforminfo: skip DBus test if hostname service isn't available

2022-12-01 Thread David Sommerseth
From: David Sommerseth Thanks a lot! This patch was a by the book in every possible way, so this was really easy to review and apply. Acked-by: David Sommerseth - Your patch has been applied commit

[Openvpn-devel] [PATCH] Allow reconnecting in p2p mode work under FreeBSD

2022-12-01 Thread Arne Schwabe
This commit consists of two parts. - explicitly removing an existing peer in p2p mode - ignoring the ping timeout notification that is generated by the first part Signed-off-by: Arne Schwabe --- src/openvpn/dco.c | 9 + src/openvpn/dco_freebsd.c | 2 ++ src/openvpn/forward.c