Patch looks good, makes sense, thanks for that.
Interesting enough, the old code had weird formatting ("msg( M_INFO")
which led to weird indenting of the *next* lines - this patch changed
the msg() call to have no leading blank, and uncrustify complained that
now the successive lines had
Hi,
On Fri, Jan 05, 2024 at 02:57:42PM +0100, Steffan Karger wrote:
> We have D_ROUTE for route addition/deletion messages, which prints at
> loglevel 3. Use that for IPv6, like we do for IPv4 to reduce terminal
> spam for non-legacy-networking setups. Prvious code would print the
> messages at
We have D_ROUTE for route addition/deletion messages, which prints at
loglevel 3. Use that for IPv6, like we do for IPv4 to reduce terminal
spam for non-legacy-networking setups. Prvious code would print the
messages at --verb 1.
Signed-off-by: Steffan Karger
---
src/openvpn/route.c | 6 +++---
cron2 has uploaded a new patch set (#3) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/488?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Clarify that the tls-crypt-v2-verify has a very limited
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/488?usp=email )
Change subject: Clarify that the tls-crypt-v2-verify has a very limited env set
..
Clarify that the tls-crypt-v2-verify has a very limited
More clear documentation helps avoid user frustration...
Your patch has been applied to the master and release/2.6 branch.
commit a9fe012ca64d81af37a08666d3e4e74250113db2 (master)
commit 322b11ab47763e0d062576cdc907351c700ef371 (release/2.6)
Author: Arne Schwabe
Date: Fri Jan 5 15:24:32 2024
cron2 has uploaded a new patch set (#6) to the change originally created by
plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/465?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by ordex
Change subject: Make it more explicit and visible when pkg-config is not
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/465?usp=email )
Change subject: Make it more explicit and visible when pkg-config is not found
..
Make it more explicit and visible when pkg-config is not
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )
Change subject: GHA: increase verbosity for make check
..
GHA: increase verbosity for make check
Make sure we get to see the
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: GHA: increase verbosity for make check
serial-tests change is only in master, so this only goes to master (for now).
Your patch has been applied to the master branch.
commit 55c734d7c02f9778321af550a9e0d12638fe12a0
Author: Frank Lichtenheld
Date: Fri Jan 5 15:23:39 2024 +0100
GHA: increase verbosity for make check
This should be really helping clearing up user confusion, which our
current messages don't do ("but I do have all the libraries, why is
it still failing?"). Thanks, Antonio, for testing and ACKing.
I have not explicitly tested anything, just pushed to GHA and buildbot,
to be sure it's not
From: Arne Schwabe
Change-Id: Ida4d22455c51773b6713caf94a4b4fbe136a6ded
Signed-off-by: Arne Schwabe
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/488
From: Frank Lichtenheld
Make sure we get to see the test-suite.log on
failure.
Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Signed-off-by: Frank Lichtenheld
Acked-by: Arne Schwabe
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )
Change subject: GHA: increase verbosity for make check
..
Patch Set 1:
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/488?usp=email )
Change subject: Clarify that the tls-crypt-v2-verify has a very limited env set
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: GHA: increase verbosity for make check
From: Arne Schwabe
Users seem to struggle to read the full error message. This adds an
indication if pkg-config is actually found to the warning/error message
that use pkg-config.
On platforms that do not require pkg-config and for optional libraries,
the existence of pkg-config is mentioned as
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/457?usp=email )
Change subject: Implement generating TLS 1.0 PRF using new OpenSSL 3.0 APIs
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/457?usp=email
to look at the new patch set (#8).
Change subject: Implement generating TLS 1.0 PRF using new OpenSSL 3.0 APIs
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )
Change subject: GHA: increase verbosity for make check
..
Patch Set 1:
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/465?usp=email )
Change subject: Make it more explicit and visible when pkg-config is not found
Attention is currently required from: cron2, flichtenheld, ordex.
Hello cron2, flichtenheld, ordex,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/465?usp=email
to look at the new patch set (#5).
Change subject: Make it more explicit and visible
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
Hello cron2, flichtenheld, ordex,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/465?usp=email
to look at the new patch set (#4).
The following approvals got outdated and
Attention is currently required from: cron2, flichtenheld, ordex.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/465?usp=email )
Change subject: Make it more explicit and visible when pkg-config is not found
25 matches
Mail list logo
