Fixes issues with UTF8 in Files (user_pass UT test).
For added fanciness, could set charset header in resulting mail, so
"git send-email" wouldn't have to ask... but that's less nuisance than
"python explodes because UTF8" :-)
Your patch has been applied to the master branch.
commit
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/508?usp=email )
Change subject: gerrit-send-mail: Make output consistent across systems
..
gerrit-send-mail: Make output consistent across systems
When
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/508?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: gerrit-send-mail: Make output consistent across
From: Frank Lichtenheld
When writing the file specify encoding and newline, so that
the local settings (like locale) do not change the output.
Change-Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40
Signed-off-by: Frank Lichtenheld
Acked-by: Arne Schwabe
---
This change was reviewed on Gerrit
From: Frank Lichtenheld
Change-Id: I8b5570f6314e917f92dce072279efe415d79b22a
Signed-off-by: Frank Lichtenheld
Acked-by: Arne Schwabe
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL:
cron2 has uploaded a new patch set (#7) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/473?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2, Code-Review+2 by plaisthos
Change subject: test_user_pass: Add UTs
Tested locally and with GHA. I expect the UTF8 codes in our source to
create issues at some point (because software is so... helpful), but
it's only the test code, and if that happens, we can move to \xbb\xa4
(etc.) in the strings...
Your patch has been applied to the master branch.
commit
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/473?usp=email )
Change subject: test_user_pass: Add UTs for character filtering
..
test_user_pass: Add UTs for character filtering
For simplicity I
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/446?usp=email
to look at the new patch set (#3).
Change subject: Turn dead list test code into unit test
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/509?usp=email
to review the following change.
Change subject: [CMake] Allow unit tests to fall back to hard coded location
Attention is currently required from: cron2, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/508?usp=email )
Change subject: gerrit-send-mail: Make output consistent across systems
From: Frank Lichtenheld
For simplicity I implemented them only with the
inline method, but they actually apply to all methods.
Change-Id: Ie8d2d5f6f58679baaf5eb817a7e2ca1afcb8c4db
Signed-off-by: Frank Lichtenheld
Acked-by: Arne Schwabe
Acked-by: Gert Doering
---
This change was reviewed on
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/508?usp=email
to review the following change.
Change subject: gerrit-send-mail: Make output consistent across systems
Attention is currently required from: flichtenheld.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/473?usp=email )
Change subject: test_user_pass: Add UTs for character filtering
..
Patch
cron2 has uploaded a new patch set (#9) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/468?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: test_user_pass: new UT for get_user_pass
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/468?usp=email )
Change subject: test_user_pass: new UT for get_user_pass
..
test_user_pass: new UT for get_user_pass
UTs for basic functionality, without
Local tests & GHA are now happy. Ship it :-)
Your patch has been applied to the master branch.
commit b9696ff387c1754d057a3611531b681d14de9105
Author: Frank Lichtenheld
Date: Sat Jan 27 21:07:16 2024 +0100
test_user_pass: new UT for get_user_pass
Signed-off-by: Frank Lichtenheld
17 matches
Mail list logo
