Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-07 Thread Olivier W
, I fortgot to add a link to my pull request on Github: https://github.com/OpenVPN/openvpn/pull/82 Best Regards. 2017-02-07 5:14 GMT+01:00 Antonio Quartulli <a...@unstable.cc>: > On Mon, Feb 06, 2017 at 08:18:01PM +0100, Olivier W wrote: >> Should be compatible with all vers

[Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-06 Thread Olivier W
Should be compatible with all versions of OpenSSL and LibreSSL. Similar to what is done in curl: https://github.com/curl/curl/blob/028391df5d84d9fae3433afdee9261d565900355/lib/vtls/openssl.c#L603-L619 Error while compiling was: "ssl_openssl.c:512:30: error: no member named 'cert' in 'struct

Re: [Openvpn-devel] [PATCH applied] Re: Fix building with LibreSSL 2.5.1 by cleaning a hack. Similar to what is done in curl: https://github.com/curl/curl/blob/028391df5d84d9fae3433afdee9261d565900355

2017-02-17 Thread Olivier W
Hello Gert, 2017-02-16 8:47 GMT+01:00 Gert Doering : > Your patch has been applied to the master and release/2.4 branch. > > Not sure if it is something we want in release/2.3, but it wouldn't apply > with "git cherry-pick" - too much formatting changes, so one would need >

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-09 Thread Olivier W
_FATAL, "SSL_new failed"); +} +pkey = SSL_get_privatekey(ssl); +SSL_free(ssl); +#endif msg(D_TLS_DEBUG, "Extracting ECDH curve from private key"); 2017-02-08 23:39 GMT+01:00 Steffan Karger <stef...@karger.me>: > Hi, > > On 06-02-17 20:18, Olivier W w

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-13 Thread Olivier W
Hello David, 2017-02-13 20:37 GMT+01:00 David Sommerseth : > > smtpsslcertpath needs to point at a CA certificate which issued the SMTP > server certificate. You can easily verify that things are correct by > grabbing the server certificate using openssl: > >

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-13 Thread Olivier W
Hello Selva, 2017-02-13 22:34 GMT+01:00 Selva Nair : > On Debian jessie, the following .gitconfig works fo me. > > [sendemail] > smtpEncryption = tls > smtpServer = smtp.gmail.com > smtpUser = user.n...@gmail.com > smtpServerPort = 587

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-14 Thread Olivier W
Hello, So, finally I've been able to use "git-send-email" with TLS. The problem was a patch used by FreeBSD. If there are any FreeBSD users on this list or for the curious, you can find more information on FreeBSD's bugtracker: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214335#c10 Or if

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-14 Thread Olivier W
Hey :-) 2017-02-14 21:00 GMT+01:00 Gert Doering : > Funny enough, I was already subscribed to that bug... :) :-) > I find it a bit weird that this not addressed upstream in git itself, > but is burdened on the operating system maintainers... but most likely, > I'm missing

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-12 Thread Olivier W
Hello Steffan, 2017-02-10 22:20 GMT+01:00 Steffan Karger : > > The code change looks good to me, so ACK to that. Thanks! > The commit does need a better commit message though, and somewhere in > the process the newlines got mangled. I think the commit message of > your

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-13 Thread Olivier W
Hello Gert, 2017-02-13 9:31 GMT+01:00 Gert Doering : > Look at "git rebase --interactive", which will enable you to squash > three commits into a single one. Then you can use "git commit --amend" > to work on the (combined) commit message until you're happy with it. Thanks

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-13 Thread Olivier W
Hey :-) 2017-02-13 18:50 GMT+01:00 Gert Doering : > That's a not exactly helpful error message... :( - I tend to just turn > off SSL on stuff that goes to public mailing lists anyway if it causes > issues... Thanks. I also tried without SSL, but then I had messages about git

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-09 Thread Olivier W
Hello, 2017-02-08 23:39 GMT+01:00 Steffan Karger : > > The code change looks good, and passes my (manual) tests. I'd like to > keep the comment though, because this still is a hack/workaround to get > the private key from the SSL_CTX object, it just does so a little nicer > at

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack. Similar to what is done in curl: https://github.com/curl/curl/blob/028391df5d84d9fae3433afdee9261d565900355/lib/vtls/op

2017-02-15 Thread Olivier W
Hello Steffan, 2017-02-14 23:00 GMT+01:00 Steffan Karger : > Code still looks good, patch looks a lot better (applies cleanly now), > but could use an extra newline in the subject. But that doesn't warrant > an extra patch iteration, so ACK. Great, thanks! Yes, I don't know