Re: [Openvpn-devel] OpenVPN 2.5-rc1 released unable to redirect IPv4 default gateway under Windows

2020-10-19 Thread Gert Doering
it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature _

[Openvpn-devel] [PATCH applied] Re: Avoid passing NULL to argv_printf_cat() in temp_file error case.

2020-10-15 Thread Gert Doering
what instance'"). commit bbcada8abb410d077f7bc13b8157198b4bf6a3d1 (master) commit 20965a18e52e60966ed754e6171e08ebe67432d6 (release/2.5) Author: Gert Doering Date: Tue Oct 13 22:47:58 2020 +0200 Avoid passing NULL to argv_printf_cat() in temp_file error case. Signed-off-by: Gert Doering

[Openvpn-devel] [PATCH] Avoid passing NULL to argv_printf_cat() in temp_file error case.

2020-10-13 Thread Gert Doering
ut modified the code enough so that the static analyzer in gcc 9.2.0 *now* noticed and issued a warning. ssl_verify.c:1132:5: warning: '%s' directive argument is null 1132 | argv_printf_cat(, "%s", tmp_file); Signed-off-by: Gert Doering --- src/openvpn/ssl_verify.c | 9 +

Re: [Openvpn-devel] [PATCH applied] Re: Fix redirecting of IPv4 default gateway if connecting over IPv6.

2020-10-12 Thread Gert Doering
Hi, On Sun, Oct 04, 2020 at 06:02:58PM +0200, Gert Doering wrote: > Patch has been applied to the master and release/2.5 branch. > > commit 23e11e591347080efa3b933beca7f620dd059d5c (master) > commit 7b4f53095c761bde8c6b39cf645cade4c1c0c5d4 (release/2.5) > Author: Gert Doering >

[Openvpn-devel] [PATCH applied] Re: Add function for common env setting of verify user/pass calls

2020-10-11 Thread Gert Doering
Acked-by: Gert Doering I have stared at the code (with and without "-w"). Looks good. Removal of duplicated code is always good, as well as reduced indentation levels. And if it fixes a bug, even better. As a side note: "retval" in verify_user_pass_management() got silli

[Openvpn-devel] [PATCH applied] Re: Ignore deprecation warning for daemon on macOS

2020-10-11 Thread Gert Doering
Acked-by: Gert Doering "unavoidable warnings are less useful than no warnings at all" - so as a temporary measure, this makes sense. Longterm, one could see whether a "platform_daemon()" call makes sense... (From how I read the posix_spawn(3) manpage, it latter is more

[Openvpn-devel] [PATCH applied] Re: Fix compilation on pre-EKM mbedTLS libraries.

2020-10-10 Thread Gert Doering
Patch has been applied to the master branch. commit 14bd92b7e4a698678200f439ddda1ee321bb8ee8 Author: Gert Doering Date: Sat Oct 10 10:14:35 2020 +0200 Fix compilation on pre-EKM mbedTLS libraries. Signed-off-by: Gert Doering Acked-by: Steffan Karger Message-Id

[Openvpn-devel] [PATCH v2] Fix compilation on pre-EKM mbedTLS libraries.

2020-10-10 Thread Gert Doering
commit f0734e49956217 simplified key_state_export_keying_material(), changing the function prototype. For older mbedTLS versions, there is an "always fail" dummy function which was overlooked in that change. Fix prototype. v2: also adjust function return (NULL -> false) Signed

[Openvpn-devel] [PATCH] Fix compilation on pre-EKM mbedTLS libraries.

2020-10-09 Thread Gert Doering
commit f0734e49956217 simplified key_state_export_keying_material(), changing the function prototype. For older mbedTLS versions, there is "always fail" dummy function which was overlooked in that change. Fix prototype. Signed-off-by: Gert Doering --- src/openvpn/ssl_mbedtls.c |

[Openvpn-devel] [PATCH applied] Re: Simplify key material exporter backend API

2020-10-09 Thread Gert Doering
Acked-by: Arne Schwabe Message-Id: <20201009144755.39719-1-stef...@karger.me> URL: https://www.mail-archive.com/search?l=mid=20201009144755.39719-1-stef...@karger.me Signed-off-by: Gert Doering -- kind regards, Gert Doering ___

[Openvpn-devel] [PATCH applied] Re: Implement generating data channel keys via EKM/RFC 5705

2020-10-09 Thread Gert Doering
f-by: Arne Schwabe Acked-by: Steffan Karger Message-Id: <20201009115453.4279-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21187.html Signed-off-by: Gert Doering -- kind regard

[Openvpn-devel] [PATCH applied] Re: networking_iproute2: fix memory leak in net_iface_mtu_set()

2020-10-09 Thread Gert Doering
w.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21189.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Allow 'none' cipher being specified in --data-ciphers

2020-10-08 Thread Gert Doering
Acked-by: Gert Doering I have added two new cases to my server test suite: client with "--data-ciphers none" and "--ncp-disable --cipher none", against a server instance that permits "none" as part of its data-ciphers. The first case failed on the client si

Re: [Openvpn-devel] [PATCH applied] Re: Speedup TCP remote hosts connections

2020-10-05 Thread Gert Doering
that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering -

[Openvpn-devel] [PATCH applied] Re: Support X509 field list to be username

2020-10-05 Thread Gert Doering
s://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21168.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Move openvpn specific key expansion into its own function

2020-10-05 Thread Gert Doering
pansion into its own function Signed-off-by: Arne Schwabe Acked-by: Steffan Karger Message-Id: <20200825073643.15920-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20815.html Signed-off-by: Gert Doering -- k

Re: [Openvpn-devel] OpenVPN 2.5-rc1 released unable to redirect IPv4 default gateway under Windows

2020-10-04 Thread Gert Doering
oubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Des

Re: [Openvpn-devel] with IPv6 VPN connection, IPv4 traffic does not get router over VPN

2020-10-04 Thread Gert Doering
puter with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-d

[Openvpn-devel] [PATCH applied] Re: Fix redirecting of IPv4 default gateway if connecting over IPv6.

2020-10-04 Thread Gert Doering
Patch has been applied to the master and release/2.5 branch. commit 23e11e591347080efa3b933beca7f620dd059d5c (master) commit 7b4f53095c761bde8c6b39cf645cade4c1c0c5d4 (release/2.5) Author: Gert Doering Date: Fri Oct 2 19:57:36 2020 +0200 Fix redirecting of IPv4 default gateway

Re: [Openvpn-devel] [PATCH] Allow 'none' cipher being specified in --data-ciphers

2020-10-04 Thread Gert Doering
Hi, On Sun, Oct 04, 2020 at 03:14:57PM +0200, Gert Doering wrote: > "Wat?" Also, the unit test fails for me (on Linux): [ RUN ] test_poor_man [ ERROR ] --- Test failed with exception: Segmentation fault(11) gert -- "If was one thing all people took for grant

[Openvpn-devel] [PATCH applied] Re: Added environment variable for IPv6 route metric.

2020-10-04 Thread Gert Doering
Acked-by: Gert Doering I have not actually tested this (I have no testbed with IPv6 route metrics, and I do not feel like creating one). So I have only test- compiled this, and "stared at code", which looks good. Your patch has been applied to the master and release/2.5 branc

Re: [Openvpn-devel] [PATCH] Allow 'none' cipher being specified in --data-ciphers

2020-10-04 Thread Gert Doering
ed it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature _

[Openvpn-devel] [PATCH applied] Re: Speedup TCP remote hosts connections

2020-10-04 Thread Gert Doering
hosts connections Signed-off-by: Vladislav Grishenko Acked-by: Arne Schwabe Message-Id: <20201001225319.25125-1-themi...@yandex-team.ru> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21139.html Signed-off-by: Gert Doeri

[Openvpn-devel] [PATCH applied] Re: Selectively reformat too long lines

2020-10-02 Thread Gert Doering
ormat too long lines Signed-off-by: Vladislav Grishenko Acked-by: Arne Schwabe Message-Id: <20200924091004.29065-1-themi...@yandex-team.ru> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21083.html Signed-off-by: Gert Doering -- kind regards, Ge

[Openvpn-devel] [PATCH] Fix redirecting of IPv4 default gateway if connecting over IPv6.

2020-10-02 Thread Gert Doering
id above, the "remote_host" field is not well-defined unless RTSA_REMOTE_HOST is set. So, change the condition to check that. Reported-By: François Kooman Reported-By: Thomas Schäfer Trac: #1332 Signed-off-by: Gert Doering --- src/openvpn/route.c | 9 +++-- 1 file changed, 3 inserti

Re: [Openvpn-devel] with IPv6 VPN connection, IPv4 traffic does not get router over VPN

2020-10-02 Thread Gert Doering
rt -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistres

Re: [Openvpn-devel] with IPv6 VPN connection, IPv4 traffic does not get router over VPN

2020-10-02 Thread Gert Doering
omputer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature

Re: [Openvpn-devel] with IPv6 VPN connection, IPv4 traffic does not get router over VPN

2020-10-02 Thread Gert Doering
Hi, On Fri, Oct 02, 2020 at 05:05:33PM +0200, Gert Doering wrote: > I'll open a "blocker" ticket in trac... https://community.openvpn.net/openvpn/ticket/1332 JFTR gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into

Re: [Openvpn-devel] with IPv6 VPN connection, IPv4 traffic does not get router over VPN

2020-10-02 Thread Gert Doering
met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list

[Openvpn-devel] [PATCH applied] Re: compat/lz4: Update to v1.9.2

2020-10-02 Thread Gert Doering
: <20201001154658.9798-1-dav...@openvpn.net> URL: https://www.mail-archive.com/search?l=mid=20201001154658.9798-1-dav...@openvpn.net Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourcefor

[Openvpn-devel] [PATCH applied] Re: Improve error msg when all TAP adapters are in use 'or disabled'

2020-10-01 Thread Gert Doering
are in use 'or disabled' Signed-off-by: Richard Bonhomme Acked-by: Arne Schwabe Message-Id: <20200806190140.9637-1-tincantek...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20651.html Signed-off-by: Gert Doering -- kind r

[Openvpn-devel] [PATCH applied] Re: Fix update_time() and openvpn_gettimeofday() coexistence

2020-09-29 Thread Gert Doering
Acked-by: Gert Doering I think this is a good first patch for the problem at hand, and it might actually fix one of our (old!) open trac tickets, claiming that the shaper is not (always) working correctly on Linux - Trac#91 For master, we should look more closely into always using &quo

[Openvpn-devel] [PATCH applied] Re: Alias ADAPTER_DOMAIN_SUFFIX to DOMAIN

2020-09-29 Thread Gert Doering
Acked-by: Gert Doering I think this is reasonable for AS compatibility, which is desirable. (Otherwise, I do have some reservation on "why do we need to work around uncoordinated actions on the v3/AS side in the v2 source?") I have not tested this besides "stare at sourc

Re: [Openvpn-devel] [PATCH] Alias ADAPTER_DOMAIN_SUFFIX to DOMAIN

2020-09-29 Thread Gert Doering
quot; or so. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Mo

[Openvpn-devel] [PATCH applied] Re: Improve documentation of --username-as-common-name

2020-09-29 Thread Gert Doering
git-send-email-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21098.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn

[Openvpn-devel] [PATCH applied] Re: Set DNS Domain using iservice

2020-09-28 Thread Gert Doering
ve.com/openvpn-devel@lists.sourceforge.net/msg21097.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: Simplify find_adapters() to void return

2020-09-24 Thread Gert Doering
ge.net/msg21077.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: netsh: Delete WINS servers on TUN close

2020-09-24 Thread Gert Doering
om/openvpn-devel@lists.sourceforge.net/msg21075.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: netsh: Clear existing IPv6 DNS servers before configuring new ones

2020-09-24 Thread Gert Doering
Date: Thu Sep 24 08:44:51 2020 +0200 netsh: Clear existing IPv6 DNS servers before configuring new ones Signed-off-by: Simon Rozman Acked-by: Lev Stipakov Message-Id: <20200924064452.1001-2-si...@rozman.si> URL: https://www.mail-archive.com/openvpn-devel@lists.source

[Openvpn-devel] [PATCH applied] Re: netsh: Specify interfaces by index rather than name

2020-09-24 Thread Gert Doering
rather than name Signed-off-by: Simon Rozman Acked-by: Lev Stipakov Message-Id: <20200924064452.1001-1-si...@rozman.si> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21076.html Signed-off-by: Gert Doering -- kind regards, Gert Doering

Re: [Openvpn-devel] [PATCH] Added environment variable for IPv6 route metric.

2020-09-23 Thread Gert Doering
also, with our move towards C99, new code is encouraged to declare variables where first needed, not "at the top of the function") gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Neve

Re: [Openvpn-devel] OpenVPN 2.5-rc1 released unable to redirect IPv4 default gateway under Linux

2020-09-22 Thread Gert Doering
gures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature

Re: [Openvpn-devel] OpenVPN 2.5-rc1 released unable to redirect IPv4 default gateway under Windows

2020-09-22 Thread Gert Doering
ll people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Ger

Re: [Openvpn-devel] [PATCH] Fix line number reporting on config file errors after segments

2020-09-21 Thread Gert Doering
o a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Descriptio

[Openvpn-devel] [PATCH] Fix line number reporting on config file errors after segments

2020-09-20 Thread Gert Doering
e block". Trac: #1325 Signed-off-by: Gert Doering --- src/openvpn/options.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index f370a2bb..af517bab 100644 --- a/src/openvpn/options.c +++ b/s

[Openvpn-devel] [PATCH applied] Re: Fix combination of --dev tap and --topology subnet across multiple platforms.

2020-09-18 Thread Gert Doering
19be (master) commit a5964e34057bd3a2c0cb232f1abc6feeefdf146e (release/2.5) Author: Gert Doering Date: Mon Sep 14 09:08:43 2020 +0200 Fix combination of --dev tap and --topology subnet across multiple platforms. Signed-off-by: Gert Doering Acked-by: Antonio Quartu

[Openvpn-devel] [PATCH applied] Re: Add demo plugin that excercises CLIENT_CONNECT and CLIENT_CONNECT_V2 paths

2020-09-17 Thread Gert Doering
Patch has been applied to the master and release/2.5 branch. commit 94cebf8261d20a55b0260cce61ad892a98bc24d8 (master) commit 44e9f3933e27988193e4a0346559f53e5b876bde (release/2.5) Author: Gert Doering Date: Thu Sep 17 18:19:09 2020 +0200 Add demo plugin that excercises CLIENT_CONNECT

[Openvpn-devel] [PATCH v4] Add demo plugin that excercises "CLIENT_CONNECT" and "CLIENT_CONNECT_V2" paths

2020-09-17 Thread Gert Doering
This is a new "samples" plugin which does not do many useful things, besides - show how a plugin is programmed - how the various messages get dispatched - how to pass back information from a client-connect/v2 plugin - how to do async-cc plugins [not yet implemented] the operation of the

[Openvpn-devel] [PATCH applied] Re: If IPv6 pool specification sets pool start to ::0 address, increment.

2020-09-17 Thread Gert Doering
o not currently plan to backport it. commit 4dff236811a1ec9c97a27ad93182ad4beb12377f (master) commit 611382c16cbac83195cc0fd4825553dad149ff9a (release/2.5) Author: Gert Doering Date: Thu Sep 17 10:59:41 2020 +0200 If IPv6 pool specification sets pool start to ::0 address, increment. Signed-

[Openvpn-devel] [PATCH v2] If IPv6 pool specification sets pool start to ::0 address, increment.

2020-09-17 Thread Gert Doering
it about "we're only talking about the host part here" and "base sees only only 32 bit of the host part" Reported-by: NicolaF_ in Trac Trac: #1282 Signed-off-by: Gert Doering --- doc/man-sections/server-options.rst | 3 ++- src/openvpn/pool.c | 18

Re: [Openvpn-devel] [PATCH applied] Re: Fix fatal error at switching remotes (#629)

2020-09-17 Thread Gert Doering
all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doerin

[Openvpn-devel] [PATCH applied] Re: Fix fatal error at switching remotes (#629)

2020-09-17 Thread Gert Doering
tal error at switching remotes (#629) Signed-off-by: Vladislav Grishenko Acked-by: Lev Stipakov Message-Id: <20200916141755.1923-1-themi...@yandex-team.ru> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21019.html Signed-off-by: Gert Doeri

Re: [Openvpn-devel] [PATCH] If IPv6 pool specification sets pool start to ::0 address, increment.

2020-09-17 Thread Gert Doering
one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Har

Re: [Openvpn-devel] [PATCH] Added client-ip to NAT config

2020-09-16 Thread Gert Doering
sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing

[Openvpn-devel] [PATCH applied] Re: build: Fix make distclean/distcheck

2020-09-16 Thread Gert Doering
Acked-by: Gert Doering I haven't tested this (my "distcheck capable" machine is still down), but it looks reasonable. Your patch has been applied to the master and release/2.5 branch. commit 6345cea86bde14b22a8024cad5026a7d302db25c (master) commit 55f4fe3a0d04b35f0e817c5a34246d

[Openvpn-devel] [PATCH applied] Re: sample-plugins: Partially autotoolize the sample-plugins build

2020-09-16 Thread Gert Doering
Acked-by: Gert Doering Works for in-tree and out-of-tree builds now, both "just gmake" and "gmake simple/simple.so". The gmake requirement is well documented and "good enough" for this dusty corner where people very rarely need to build stuff. (It might be solv

Re: [Openvpn-devel] [PATCH v3] sample-plugins: Partially autotoolize the sample-plugins build

2020-09-16 Thread Gert Doering
yself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___

[Openvpn-devel] [PATCH applied] Re: Fix netbits setting (in TAP mode) for IPv6 on Windows.

2020-09-15 Thread Gert Doering
859952560aff6d4442cdfa0c41ced494e9dc397e (release/2.5) Author: Gert Doering Date: Tue Sep 15 11:41:01 2020 +0200 Fix netbits setting (in TAP mode) for IPv6 on Windows. Signed-off-by: Gert Doering Acked-by: Lev Stipakov Message-Id: <20200915094101.86470-1-g...@greenie.muc.de> URL:

Re: [Openvpn-devel] [PATCH v2] sample-plugins: Partially autotoolize the sample-plugins build

2020-09-15 Thread Gert Doering
into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: P

[Openvpn-devel] [PATCH v2] Fix netbits setting (in TAP mode) for IPv6 on Windows.

2020-09-15 Thread Gert Doering
dress_service() to actually log both IPv4 and IPv6 addresses requested via it. Tested on Win10/64. v2: - change logging to use D_IFCONFIG - fix whitespace on "?" operator Reported-By: Laurent Fasnacht Reported-By: Klara Mall Trac: #1054 Signed-off-by: Gert Doering ---

[Openvpn-devel] [PATCH applied] Re: Allow --dhcp-option in config file when windows-driver is wintun

2020-09-15 Thread Gert Doering
.sourceforge.net/msg21005.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH] Fix netbits setting (in TAP mode) for IPv6 on Windows.

2020-09-14 Thread Gert Doering
dress_service() to actually log both IPv4 and IPv6 addresses requested via it. Tested on Win10/64. Reported-By: Laurent Fasnacht Reported-By: Klara Mall Trac: #1054 Signed-off-by: Gert Doering --- src/openvpn/tun.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletion

Re: [Openvpn-devel] [PATCH] Fix IPv6 configuration on Windows using netsh

2020-09-14 Thread Gert Doering
gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moo

[Openvpn-devel] [PATCH applied] Re: man: Improve --remote entry

2020-09-14 Thread Gert Doering
Acked-by: Gert Doering I've compared this to the 2.4 man page, and it is indeed easier to read and less unclear this way. As written already, one day we need to go through the man pages and throw out all NOTEs that refer to --secret mode, or clarify what "running without --remote" re

Re: [Openvpn-devel] [PATCH] man: Improve --remote entry

2020-09-14 Thread Gert Doering
these notes. All these notes. One day. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Rober

[Openvpn-devel] [PATCH applied] Re: socks.c: fix alen for DOMAIN type addresses, bump up buffer sizes

2020-09-14 Thread Gert Doering
Thanks for the review. Patch has been applied to many branches (bugfix)... commit eebeaa02367d247fc2549df3edf8e598c58c3572 (master) commit c7f0d7b95bff05b0a5ddab15318cd53fcc91d60a (release/2.5) commit 64a76533b676ad441ca20bab0c8b2e387bd56ebe (release/2.4) Author: Gert Doering Date: Wed Sep 9

[Openvpn-devel] [PATCH applied] Re: msvc: better support for 32bit architecture

2020-09-14 Thread Gert Doering
Acked-by: Gert Doering I won't claim to understand all the intricacies, but the change looks like it would do what the text says - and you're the MSVC master anyway. Your patch has been applied to the master and release/2.5 branch. commit fb94fbc31f9d6e434af465bf8a345763f89fddc9 (master

Re: [Openvpn-devel] [PATCH] If IPv6 pool specification sets pool start to ::0 address, increment.

2020-09-14 Thread Gert Doering
hi', or do "full 128 bit on 16 uint8_t" stuff...). Yes, this can be done, but I was way too lazy and went for a less intrusive fix instead... gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures c

[Openvpn-devel] [PATCH applied] Re: Fix --show-gateway for IPv6 on NetBSD/i386.

2020-09-14 Thread Gert Doering
Patch has been applied to many branches... (bugfix). commit 37aab49b083a9e385970e3ab2dd727ea1a95ff35 (master) commit 9a695902402faafa343783c38761c4c0ccbb2b83 (HEAD -> release/2.5) commit 9e9fd488d7d939ac9992f8bd4c7394a39b73d7e4 (HEAD -> release/2.4) Author: Gert Doering Date: Sun Sep 13

[Openvpn-devel] [PATCH] Fix combination of --dev tap and --topology subnet across multiple platforms.

2020-09-14 Thread Gert Doering
) blocks more nicely... which has not happened yet, so this patch is basically applying exactly the same changes to context that has changed too much for git to be able to do this automatically. Trac: #1085 Signed-off-by: Gert Doering --- src/openvpn/tun.c | 20 ++-- 1 file chan

[Openvpn-devel] [PATCH] Fix --show-gateway for IPv6 on NetBSD/i386.

2020-09-13 Thread Gert Doering
ominous "GDG6: problem writing to routing socket" error message to differenciate between "EINVAL" and other errors. Trac: #734 Signed-off-by: Gert Doering --- src/openvpn/route.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/op

Re: [Openvpn-devel] [PATCH v2] Add demo plugin that excercises "CLIENT_CONNECT" and "CLIENT_CONNECT_V2" paths

2020-09-11 Thread Gert Doering
Hi, thanks for the review. On Fri, Sep 11, 2020 at 09:03:43PM +0200, David Sommerseth wrote: > On 11/08/2020 12:44, Gert Doering wrote: > > This is a new "samples" plugin which does not do many useful things, > > besides [..] > > +sample-client-con

[Openvpn-devel] [PATCH v3] Add demo plugin that excercises "CLIENT_CONNECT" and "CLIENT_CONNECT_V2" paths

2020-09-11 Thread Gert Doering
This is a new "samples" plugin which does not do many useful things, besides - show how a plugin is programmed - how the various messages get dispatched - how to pass back information from a client-connect/v2 plugin - how to do async-cc plugins [not yet implemented] the operation of the

[Openvpn-devel] [PATCH applied] Re: Handle NULL returns from calloc() in sample plugins.

2020-09-11 Thread Gert Doering
Patch has been applied to the master, release/2.5 and release/2.4 branch. commit a61c08a2c80d95dcc2bc30ddcb9a54a462e565ed (master) commit 5382bdbfbfb9ac26c7c75bc967af86db352b54b3 (release/2.5) commit 2b8dda69115e1e048ff685bc366705156781548c (release/2.4) Author: Gert Doering Date: Wed Sep 9 12

[Openvpn-devel] [PATCH applied] Re: man: Add missing --server-ipv6

2020-09-11 Thread Gert Doering
Acked-by: Gert Doering Thanks :) I have removed one line + This is only accepted if ``--mode server`` or ``--server`` is set. as this is no longer correct after merging of Antonio's ipv6-only patch set (but the corresponding doc change might have gotten lost in between). Your patch has

[Openvpn-devel] OpenSolaris / OpenIndiana help sought

2020-09-11 Thread Gert Doering
s into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.

[Openvpn-devel] [PATCH applied] Re: Fix description of --client-disconnect calling convention in manpage.

2020-09-11 Thread Gert Doering
9481cca682112b502f83afe537164fcdb0606e55 (release/2.4) Author: Gert Doering Date: Wed Sep 9 14:29:26 2020 +0200 Fix description of --client-disconnect calling convention in manpage. Signed-off-by: Gert Doering Acked-by: Antonio Quartulli Message-Id: <20200909122926.9523-1-g...@greenie.muc.de>

[Openvpn-devel] [PATCH] If IPv6 pool specification sets pool start to ::0 address, increment.

2020-09-11 Thread Gert Doering
Trac: #1282 Signed-off-by: Gert Doering --- doc/man-sections/server-options.rst | 3 ++- src/openvpn/pool.c | 15 +++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/doc/man-sections/server-options.rst b/doc/man-sections/server-options.rst inde

[Openvpn-devel] [PATCH applied] Re: Replace 'echo -n' with 'printf' in tests/t_lpback.sh

2020-09-11 Thread Gert Doering
Patch has been applied to the master and release/2.5 branch. commit 81f9bb3a2ff9a3b0f5a1bdbac1d0daf38747ae7b (master) commit d17eb65d144f157942a1675bdb25f89f15aff839 (release/2.5) Author: Gert Doering Date: Wed Sep 9 15:00:24 2020 +0200 Replace 'echo -n' with 'printf' in tests/t_lpback.sh

[Openvpn-devel] [PATCH applied] Re: Add a remark on dropping privileges when --mlock is used

2020-09-11 Thread Gert Doering
Acked-by: Gert Doering Additional documentation of possible consequences of --mlock + --user is good, and pointers to "what to do about it" are always useful :-) Your patch has been applied to the master and release/2.5 branch. I have not backported it to .8 format for 2.4 - I do

[Openvpn-devel] [PATCH applied] Re: Fix handling of 'route remote_host' for IPv6 transport case.

2020-09-11 Thread Gert Doering
Patch has been applied to lots of branches... :) commit aa34684972eb01bfa5c355d1c8a8a9d384bf0175 (master) commit 78c50eba82fe9bf9a899cb8587e11dcc227c0cdd (release/2.5) commit 09e46c3ca7ead4e7b817fa527302dfb1a2f225d0 (release/2.4) Author: Gert Doering Date: Fri Sep 11 10:59:07 2020 +0200

[Openvpn-devel] [PATCH] Fix handling of 'route remote_host' for IPv6 transport case.

2020-09-11 Thread Gert Doering
heck, not done refactoring for init_route() to see whether I could make it "more pretty". Trac: #1247 Signed-off-by: Gert Doering --- src/openvpn/route.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index f127a90

Re: [Openvpn-devel] problem with beta3 and wintun

2020-09-11 Thread Gert Doering
;If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mi

[Openvpn-devel] [PATCH applied] Re: Fix best gateway selection over netlink

2020-09-10 Thread Gert Doering
dex-team.ru> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20900.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net

[Openvpn-devel] [PATCH applied] Re: Fix TUNSETGROUP compatibility with very old Linux systems.

2020-09-10 Thread Gert Doering
Patch has been applied to the master, release/2.5 and release/2.4 branch. commit a4e0ac0604460ea2431acb7481d6ffb7a3fc6298 (master) commit 43e70c78c34b90b15b6bfdac9c1911853defca10 (release/2.5) commit a1dc800348937d6993f5008140081f66a695026a (release/2.4) Author: Gert Doering Date: Wed Sep 9 17

Re: [Openvpn-devel] problem with beta3 and wintun

2020-09-10 Thread Gert Doering
that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g

[Openvpn-devel] [PATCH] Fix TUNSETGROUP compatibility with very old Linux systems.

2020-09-09 Thread Gert Doering
Our code works on "very old Linux" (Fedora-1), but needs a #define for TUNSETGROUP to compile. Everything else is there. While at it, fix TUNSETGROUP error message. Reported-By: noloader on Trac Trac: #1152 Signed-off-by: Gert Doering --- src/openvpn/tun.c | 7 ++- 1 file

[Openvpn-devel] [PATCH] Replace 'echo -n' with 'printf' in tests/t_lpback.sh

2020-09-09 Thread Gert Doering
"echo -n" is inherently less portable than printf, so the tests look ugly on (at least) OpenSolaris/Illumos on AIX. Add a blank at the end of the tls-crypt-v2 messages, so it has the same look as the cipher messages ("... OK"). Reported-by: mnowak on Trac Trac: #1196 Signed-

[Openvpn-devel] [PATCH] Fix description of --client-disconnect calling convention in manpage.

2020-09-09 Thread Gert Doering
The man page claimed that --client-disconnect "is passed the same pathname as the corresponding --client-connect command", which is not what the code does. Fix. Reported-By: hvenev in Trac Trac: #884 Signed-off-by: Gert Doering --- doc/man-sections/script-options.rst | 5 ++--- 1 fi

[Openvpn-devel] [PATCH v3] socks.c: fix alen for DOMAIN type addresses, bump up buffer sizes

2020-09-09 Thread Gert Doering
to 270, to handle long domain names in queries Reported-By: tpw_rules in Trac Trac: #848 Signed-off-by: Gert Doering --- src/openvpn/socks.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c index 57f0cee2..d43d84a8 100644 --- a/sr

[Openvpn-devel] [PATCH v2] socks.c: fix alen for DOMAIN type addresses

2020-09-09 Thread Gert Doering
ur code totally doesn't use this variant of addresses, but since this has been pointed out by "tpw_rules" in Trac, fix it, so if/when someone works on this again, the foundation is correct. v2: increase buf[] len to be large enough to actually copy a domain name Reported-By: tpw_rules in Trac

[Openvpn-devel] [PATCH] socks.c: fix alen for DOMAIN type addresses

2020-09-09 Thread Gert Doering
ur code totally doesn't use this variant of addresses, but since this has been pointed out by "tpw_rules" in Trac, fix it, so if/when someone works on this again, the foundation is correct. Reported-By: tpw_rules in Trac Trac: #848 Signed-off-by: Gert Doering --- src/openvpn/socks.c | 5

[Openvpn-devel] [PATCH] Handle NULL returns from calloc() in sample plugins.

2020-09-09 Thread Gert Doering
y: Dogbert (in Trac) Signed-off-by: Gert Doering --- sample/sample-plugins/defer/simple.c| 5 + .../keying-material-exporter-demo/keyingmaterialexporter.c | 6 ++ sample/sample-plugins/log/log.c | 5 + sample/sample-plugins/lo

[Openvpn-devel] [PATCH applied] Re: Fix error detection / abort in --inetd corner case.

2020-09-09 Thread Gert Doering
7565f30e02e2246d569 (release/2.5) commit 769c894db29f76f6510569fc20633fb6f0c357f9 (release/2.4) Author: Gert Doering Date: Tue Sep 8 12:51:30 2020 +0200 Fix error detection / abort in --inetd corner case. Signed-off-by: Gert Doering Acked-by: Arne Schwabe Message-Id: <20200908105130.24171-1-g...@

[Openvpn-devel] [PATCH applied] Re: Document that --push-remove is generally more suitable than --push-reset

2020-09-09 Thread Gert Doering
.5) commit d61cbfcde78bf65ec677d164d5d03e00f092befd (release/2.4) Author: Gert Doering Date: Tue Sep 8 13:15:11 2020 +0200 Document that --push-remove is generally more suitable than --push-reset Signed-off-by: Gert Doering Acked-by: Arne Schwabe Acked-by: David Sommerseth

Re: [Openvpn-devel] [PATCH] Document that --push-remove is generally more suitable than --push-reset

2020-09-08 Thread Gert Doering
till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature _

[Openvpn-devel] [PATCH] Document that --push-remove is generally more suitable than --push-reset

2020-09-08 Thread Gert Doering
on overall server config. So just document the fact, and point people towards --push-remove as a more selective tool. Trac: #29 Signed-off-by: Gert Doering --- doc/man-sections/server-options.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/man-sections/server-options.

[Openvpn-devel] [PATCH] Fix error detection / abort in --inetd corner case.

2020-09-08 Thread Gert Doering
ot; ("The argument s is a file, not a socket"). While at it, uncrustify the --bind-dev code (whitespace only). Trac: #350 Signed-off-by: Gert Doering --- src/openvpn/socket.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/openvpn/socket.c b/src/o

Re: [Openvpn-devel] [PATCH] Fix best gateway selection over netlink

2020-09-07 Thread Gert Doering
r, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de si

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: make adapter renaming non-fatal

2020-09-04 Thread Gert Doering
Stipakov Acked-by: Simon Rozman Message-Id: <20200902213643.401-1-lstipa...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20875.html Signed-off-by: Gert Doering -- kind regards,

  1   2   3   4   5   6   7   8   9   10   >