[Openvpn-devel] [PATCH v2] Remove openvpn_snprintf and similar functions

2024-04-08 Thread Gert Doering
From: Arne Schwabe Old Microsoft versions did strange behaviour but according to the newly added unit test and https://stackoverflow.com/questions/7706936/is-snprintf-always-null-terminating this is now standard conforming and we can use the normal snprintf method. Microsoft own documentation

[Openvpn-devel] [PATCH applied] Re: Change default of topology to subnet

2024-04-03 Thread Gert Doering
mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27627.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: forked-test-driver: Show test output always

2024-04-03 Thread Gert Doering
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28133.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: tests: fork default automake test-driver

2024-04-03 Thread Gert Doering
.@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28132.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https

[Openvpn-devel] [PATCH applied] Re: Remove/combine redundant call of EVP_CipherInit before EVP_CipherInit_Ex

2024-04-02 Thread Gert Doering
eaa22b0a803fd74f4 Author: Arne Schwabe Date: Tue Apr 2 15:49:09 2024 +0200 Remove/combine redundant call of EVP_CipherInit before EVP_CipherInit_Ex Signed-off-by: Arne Schwabe Acked-by: Gert Doering Message-Id: <20240402134909.6340-1-g...@greenie.muc.de> URL: https:

[Openvpn-devel] [PATCH v3] Remove/combine redundant call of EVP_CipherInit before EVP_CipherInit_Ex

2024-04-02 Thread Gert Doering
/openssl/blob/openssl-3.2/crypto/evp/evp_enc.c#L450 basically the same as 1.0.2. Just that method names have been changed. Change-Id: I911e25949a8647b567fd4178683534d4404ab469 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one

[Openvpn-devel] [PATCH v2] Remove redundant call of EVP_CipherInit before EVP_CipherInit_Ex

2024-04-02 Thread Gert Doering
basically the same as 1.0.2. Just that method names have been changed. Change-Id: I911e25949a8647b567fd4178683534d4404ab469 Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL

[Openvpn-devel] [PATCH applied] Re: Match ifdef for get_sigtype function with if ifdef of caller

2024-04-02 Thread Gert Doering
) Author: Arne Schwabe Date: Tue Apr 2 08:36:46 2024 +0200 Match ifdef for get_sigtype function with if ifdef of caller Signed-off-by: Arne Schwabe Acked-by: Gert Doering Message-Id: <20240402063646.25490-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/o

[Openvpn-devel] [PATCH v1] Match ifdef for get_sigtype function with if ifdef of caller

2024-04-02 Thread Gert Doering
From: Arne Schwabe These two ifdef needs to be the same otherwise the compiler will break with a undefined function. Change-Id: I5b14bf90bb07935f0bb84373ec4e62352752c03f Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one

[Openvpn-devel] [PATCH applied] Re: crypto_backend: fix type of enc parameter

2024-03-31 Thread Gert Doering
Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240327162621.1792414-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28498.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: misc.c: remove unused code

2024-03-29 Thread Gert Doering
g28503.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH v1] misc.c: remove unused code

2024-03-29 Thread Gert Doering
From: Lev Stipakov Commit 3a4fb1 "Ensure --auth-nocache is handled during renegotiation" has changed the behavior of set_auth_token(), but left unused parameter struct user_pass *up Remove this parameter and amend comments accordingly. Also remove unused function definition from misc.h.

[Openvpn-devel] [PATCH applied] Re: script-options.rst: Update ifconfig_* variables

2024-03-26 Thread Gert Doering
Acked-by: Gert Doering We're so bad at times at updating documentation... verified that the newly documented options exist and do what it says. Confusing code... Your patch has been applied to the master and release/2.6 branch (doc). commit a94226cdc8ed037a6763675aa47e6c821983f174 (master

[Openvpn-devel] [PATCH applied] Re: Add bracket in fingerprint message and do not warn about missing verification

2024-03-26 Thread Gert Doering
g28474.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Fix snprintf/swnprintf related compiler warnings

2024-03-26 Thread Gert Doering
Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20240326104101.531291-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28475.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: phase2_tcp_server: fix Coverity issue 'Dereference after null check'

2024-03-25 Thread Gert Doering
.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28452.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourc

[Openvpn-devel] [PATCH applied] Re: Use snprintf instead of sprintf for get_ssl_library_version

2024-03-25 Thread Gert Doering
y: Frank Lichtenheld Message-Id: <20240325125052.14135-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28458.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___

[Openvpn-devel] [PATCH applied] Re: documentation: make section levels consistent

2024-03-25 Thread Gert Doering
consistent Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240325071520.12513-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28453.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: samples: Update sample configurations

2024-03-25 Thread Gert Doering
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28451.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net

[Openvpn-devel] [PATCH v1] Use snprintf instead of sprintf for get_ssl_library_version

2024-03-25 Thread Gert Doering
From: Arne Schwabe This is avoid a warning/error (when using -Werror) under current macOS of sprintf: __deprecated_msg("This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use

[Openvpn-devel] [PATCH v1] Remove openvpn_snprintf and similar functions

2024-03-25 Thread Gert Doering
From: Arne Schwabe Old Microsoft versions did strange behaviour but according to the newly added unit test and https://stackoverflow.com/questions/7706936/is-snprintf-always-null-terminating this is now standard conforming and we can use the normal snprintf method. Microsoft own documentation

[Openvpn-devel] [PATCH v2] documentation: make section levels consistent

2024-03-25 Thread Gert Doering
From: Frank Lichtenheld Previously the sections "Encryption Options" and "Data channel cipher negotiation" were on the same level as "OPTIONS", which makes no sense. Instead move them and their subsections one level down. Use ` since that was already in use in section "Virtual Routing and

[Openvpn-devel] [PATCH v2] phase2_tcp_server: fix Coverity issue "Dereference after null check"

2024-03-25 Thread Gert Doering
From: Frank Lichtenheld As Coverity says: Either the check against null is unnecessary, or there may be a null pointer dereference. In phase2_tcp_server: Pointer is checked against null but then dereferenced anyway There is only one caller (link_socket_init_phase2) and it already has an

[Openvpn-devel] [PATCH v4] samples: Update sample configurations

2024-03-25 Thread Gert Doering
From: Frank Lichtenheld - Remove compression settings. Not recommended anymore. - Remove old cipher setting. Replaced by data-ciphers negotiation. - Add comment how to set data-ciphers for very old clients. - Remove/reword some old comments. e.g. no need to reference OpenVPN 1.x anymore. -

Re: [Openvpn-devel] [PATCH v2] Implement server_poll_timeout for socks

2024-03-20 Thread Gert Doering
er doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature _

[Openvpn-devel] [PATCH applied] Re: interactive.c: Fix potential stack overflow issue

2024-03-20 Thread Gert Doering
Acked-by: Gert Doering Verified that this is the same conceptual patch as we have in master and release/2.6, just the lines look a bit different because the 2.5 code is different - the union has less members, and there is ring_buffer related stuff in the context that was changed for 2.6 Test

[Openvpn-devel] [PATCH applied] Re: Disable DCO if proxy is set via management

2024-03-19 Thread Gert Doering
w.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28415.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/o

[Openvpn-devel] [PATCH applied] Re: interactive.c: Fix potential stack overflow issue

2024-03-19 Thread Gert Doering
Fix potential stack overflow issue Signed-off-by: Lev Stipakov Acked-by: Heiko Hund Message-Id: <20240319152803.1801-2-...@openvpn.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28420.html

[Openvpn-devel] [PATCH applied] Re: interactive.c: Fix potential stack overflow issue

2024-03-19 Thread Gert Doering
Fix potential stack overflow issue Signed-off-by: Lev Stipakov Acked-by: Heiko Hund Message-Id: <20240319152803.1801-2-...@openvpn.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28420.html

[Openvpn-devel] [PATCH applied] Re: interactive.c: disable remote access to the service pipe

2024-03-19 Thread Gert Doering
...@openvpn.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28419.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.so

[Openvpn-devel] [PATCH applied] Re: GHA: general update March 2024

2024-03-19 Thread Gert Doering
0319154456.2967716-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28422.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@l

[Openvpn-devel] [PATCH applied] Re: win32: Enforce loading of plugins from a trusted directory

2024-03-19 Thread Gert Doering
e/2.5) Author: Lev Stipakov Date: Tue Mar 19 15:53:45 2024 +0200 win32: Enforce loading of plugins from a trusted directory Signed-off-by: Lev Stipakov Acked-by: Selva Nair Message-Id: <20240319135355.1279-2-...@openvpn.net> URL: https://www.mail-archive.com/openvpn-d

[Openvpn-devel] [PATCH v1] Disable DCO if proxy is set via management

2024-03-18 Thread Gert Doering
From: Lev Stipakov Commit 45a1cb2a ("Disable DCO if proxy is set via management") attempted to disable DCO when proxy is set via management interface. However, at least on Windows this doesn't work, since: - setting tuntap_options->disable_dco to true is not enough to disable DCO - at

[Openvpn-devel] [PATCH applied] Re: Update Copyright statements to 2024

2024-03-18 Thread Gert Doering
Acked-by: Gert Doering Like Christmas... happens every year :-) - verified that this, indeed, only affects copyright lines ("git show -I '^ \* Copyright') - I guess it was produced by update-copyright.sh anyway, but review is what I do... The only actual code change is the msg() in opti

[Openvpn-devel] [PATCH applied] Re: Remove license warning from README.mbedtls

2024-03-15 Thread Gert Doering
README.mbedtls Signed-off-by: Max Fillinger Acked-by: Gert Doering Message-Id: <20240314185527.26803-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28400.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH v1] Remove license warning from README.mbedtls

2024-03-14 Thread Gert Doering
From: Max Fillinger The licenses are compatible now, so we can remove the warning. Change-Id: I1879c893ed19b165fd086728fb97951eac251681 Signed-off-by: Max Fillinger Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge

Re: [Openvpn-devel] [PATCH applied] Re: t_client.sh: Allow to skip tests

2024-03-11 Thread Gert Doering
Hi, On Mon, Mar 11, 2024 at 12:44:20PM +0100, Frank Lichtenheld wrote: > On Fri, Mar 08, 2024 at 12:51:33PM +0100, Gert Doering wrote: > [...] > > Your patch has been applied to the master branch. > > Could we please cherry-pick this to release/2.6 as well? > > Would ma

[Openvpn-devel] [PATCH applied] Re: Update documentation references in systemd unit files

2024-03-08 Thread Gert Doering
unit files Signed-off-by: Christoph Schug Acked-by: Frank Lichtenheld Message-Id: <20240308140346.4058419-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28369.html Signed-off-by: Gert Doering -- kind regards,

[Openvpn-devel] [PATCH applied] Re: remove repetitive words in documentation and comments

2024-03-08 Thread Gert Doering
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28368.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.ne

[Openvpn-devel] [PATCH applied] Re: gerrit-send-mail: add missing Signed-off-by

2024-03-08 Thread Gert Doering
Your patch has been applied to the master branch. commit bea088cf8ae3382aeed420da2a39f2a9f52df4cd Author: Frank Lichtenheld Date: Fri Mar 8 13:05:57 2024 +0100 gerrit-send-mail: add missing Signed-off-by Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id

[Openvpn-devel] [PATCH v1] gerrit-send-mail: add missing Signed-off-by

2024-03-08 Thread Gert Doering
From: Frank Lichtenheld Our development documentation says we add this automatically when it is missing. So let's do that here as well. Change-Id: If9cb7d66f079fe1c87fcb5b4e59bc887533d77fa Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit

[Openvpn-devel] [PATCH applied] Re: t_client.sh: Allow to skip tests

2024-03-08 Thread Gert Doering
hit users) Your patch has been applied to the master branch. commit 0c7cf0694ee6f878168330e9a084c255c51a9e8b Author: Frank Lichtenheld Date: Fri Mar 8 11:28:18 2024 +0100 t_client.sh: Allow to skip tests Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: &l

[Openvpn-devel] [PATCH applied] Re: Minor fix to process_ip_header

2024-03-08 Thread Gert Doering
/openvpn-devel@lists.sourceforge.net/msg28345.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: check_compression_settings_valid: Do not test for LZ4 in LZO check

2024-03-08 Thread Gert Doering
Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH v5] t_client.sh: Allow to skip tests

2024-03-08 Thread Gert Doering
-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/521 This mail reflects revision 5 of this Change. Acked-by according to Gerrit

[Openvpn-devel] [PATCH applied] Re: Persist-key: enable persist-key option by default

2024-03-07 Thread Gert Doering
Message-Id: <20240307140355.32644-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28347.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing li

[Openvpn-devel] [PATCH v5] Persist-key: enable persist-key option by default

2024-03-07 Thread Gert Doering
From: Gianmarco De Gregori Change the default behavior of the OpenVPN configuration by enabling the persist-key option by default. This means that all the keys will be kept in memory across restart. Fixes: Trac #1405 Change-Id: I57f1c2ed42bd9dfd43577238749a9b7f4c1419ff Signed-off-by: Gianmarco

[Openvpn-devel] [PATCH v5] Minor fix to process_ip_header

2024-03-07 Thread Gert Doering
From: Gianmarco De Gregori Removed if-guard checking if any feature is enabled before performing per-feature check. It doesn't save us much but instead introduces uneeded complexity. While at it, fixed a typo IMCP -> ICMP for defined PIPV6_ICMP_NOHOST_CLIENT and PIPV6_ICMP_NOHOST_SERVER macros.

[Openvpn-devel] [PATCH v3] Persist-key: enable persist-key option by default

2024-03-06 Thread Gert Doering
From: itsGiaan Change the default behavior of the OpenVPN configuration by enabling the persist-key option by default. This means that all the keys will be kept in memory across restart. Fixes: Trac #1405 Change-Id: I57f1c2ed42bd9dfd43577238749a9b7f4c1419ff Signed-off-by: Gianmarco De Gregori

[Openvpn-devel] [PATCH applied] Re: openvpn-[client|server].service: Remove syslog.target

2024-03-06 Thread Gert Doering
Signed-off-by: Frank Lichtenheld Message-Id: <20240304163313.2326923-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28318.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___

[Openvpn-devel] [PATCH applied] Re: samples: Remove tls-*.conf

2024-03-05 Thread Gert Doering
com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28316.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourcefor

[Openvpn-devel] [PATCH applied] Re: Fix typo --data-cipher-fallback

2024-03-05 Thread Gert Doering
Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH v1] Fix typo --data-cipher-fallback

2024-03-05 Thread Gert Doering
From: Frank Lichtenheld Change-Id: I38e70cb74c10848ab2981efc4c4c8863c5c8785d Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL:

[Openvpn-devel] [PATCH applied] Re: Document that auth-user-pass may be inlined

2024-02-23 Thread Gert Doering
4.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Document that auth-user-pass may be inlined

2024-02-20 Thread Gert Doering
ver doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature _

Re: [Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-19 Thread Gert Doering
Hi, On Mon, Feb 19, 2024 at 02:23:08PM +0100, Antonio Quartulli wrote: > On 19/02/2024 14:12, Gert Doering wrote: > > Maybe that would be a more reasonable approach here... get rid of the > > umbrella if(), and check individual bits inside. It seems to be a > > mic

Re: [Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-19 Thread Gert Doering
Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://l

Re: [Openvpn-devel] IRC community meeting summary (Feb 14th)

2024-02-17 Thread Gert Doering
-- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is

Re: [Openvpn-devel] [S] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-15 Thread Gert Doering
ubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature __

[Openvpn-devel] [PATCH applied] Re: Change include order for tests

2024-02-12 Thread Gert Doering
Message-Id: <20240212132522.125903-1-juli...@wolfssl.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28229.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailin

Re: [Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-12 Thread Gert Doering
hing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert

[Openvpn-devel] [PATCH applied] Re: Turn dead list test code into unit test

2024-02-10 Thread Gert Doering
rne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20240209105902.14506-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28201.html Signed-off-by: Gert Doering -- kind regards, Ger

[Openvpn-devel] [PATCH applied] Re: Implement generating TLS 1.0 PRF using new OpenSSL 3.0 APIs

2024-02-10 Thread Gert Doering
new OpenSSL 3.0 APIs Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <20240209110629.15364-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28203.html Signed-off-by: Gert Doering -- kind r

Re: [Openvpn-devel] [PATCH] wolfssl: include "ssl.h" by "src/openvpn/ssl.h"

2024-02-09 Thread Gert Doering
" Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sou

[Openvpn-devel] [PATCH applied] Re: Print SSL peer signature information in handshake debug details

2024-02-09 Thread Gert Doering
-devel@lists.sourceforge.net/msg28206.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: Add unit test for encrypting/decrypting data channel

2024-02-08 Thread Gert Doering
Add unit test for encrypting/decrypting data channel Acked-by: Frank Lichtenheld Message-Id: <20240208085749.869-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28195.html Signed-off-by: Gert Doering -- kind regards,

[Openvpn-devel] [PATCH v3] Add unit test for encrypting/decrypting data channel

2024-02-08 Thread Gert Doering
From: Arne Schwabe This test is reusing code from --test-crypto but is modified to not rely on the static key functionality and also only tests the most common algorithm. So it does not yet completely replace --test-crypto Change-Id: Ifa5ae96165d17b3cae4afc53e844bb34d1610e58 Acked-by: Frank

[Openvpn-devel] [PATCH applied] Re: test_user_pass: add basic tests for static/dynamic challenges

2024-02-08 Thread Gert Doering
-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240207171239.86730-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28191.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: dco-freebsd: dynamically re-allocate buffer if it's too small

2024-02-07 Thread Gert Doering
Acked-by: Gert Doering Stare-at-code looks good :-) - there's one possible catch should realloc() return NULL - in that case we'd pass drv.ifd_data = NULL to the kernel - but I'm reasonably sure the kernel will then not crash but return EINVAL. I do not have a sufficient number of clients

[Openvpn-devel] [PATCH applied] Re: documentation: Fixes for previous fixes to --push-peer-info

2024-02-06 Thread Gert Doering
to --push-peer-info Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240206174745.74828-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28184.html Signed-off-by: Gert Doering -- kind regards,

Re: [Openvpn-devel] [PATCH] dco-freebsd: dynamically re-allocate buffer if it's too small

2024-02-06 Thread Gert Doering
if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc

Re: [Openvpn-devel] [PATCH applied] Re: documentation: Update and fix documentation for --push-peer-info

2024-02-06 Thread Gert Doering
Hi, On Tue, Feb 06, 2024 at 04:33:44PM +0100, Gert Doering wrote: > Your patch has been applied to the master branch. > > commit b66d545ce25689588c4dbd1fb525204c78871ed0 (master) > commit 18fb30f7ad292f166805138c0ec3c2c920090364 (release/2.6) > Author: Frank Lichtenheld > Date:

[Openvpn-devel] [PATCH applied] Re: documentation: Update and fix documentation for --push-peer-info

2024-02-06 Thread Gert Doering
-peer-info Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240206141057.46249-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28178.html Signed-off-by: Gert Doering -- kind regards, Gert D

Re: [Openvpn-devel] [PATCH applied] Re: README.cmake.md: Document minimum required CMake version for --preset

2024-02-02 Thread Gert Doering
Hi, On Fri, Feb 02, 2024 at 12:27:19PM +0100, Frank Lichtenheld wrote: > On Thu, Feb 01, 2024 at 08:28:21PM +0100, Gert Doering wrote: > > Makes sense (I did read the GH issue). > > > > Your patch has been applied to the master branch. > > I think it would make sen

[Openvpn-devel] [PATCH applied] Re: README.cmake.md: Document minimum required CMake version for --preset

2024-02-01 Thread Gert Doering
-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20240201123039.174176-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28160.html Signed-off-by: Gert Doering -- kind regards, Gert D

[Openvpn-devel] [PATCH applied] Re: Allow unit tests to fall back to hard coded location

2024-02-01 Thread Gert Doering
Lichtenheld Message-Id: <20240201144817.14-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28161.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn

[Openvpn-devel] [PATCH applied] Re: gerrit-send-mail: Make output consistent across systems

2024-01-29 Thread Gert Doering
reenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28153.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://l

[Openvpn-devel] [PATCH v1] gerrit-send-mail: Make output consistent across systems

2024-01-29 Thread Gert Doering
From: Frank Lichtenheld When writing the file specify encoding and newline, so that the local settings (like locale) do not change the output. Change-Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit

[Openvpn-devel] [PATCH v7] test_user_pass: add basic tests for static/dynamic challenges

2024-01-29 Thread Gert Doering
From: Frank Lichtenheld Change-Id: I8b5570f6314e917f92dce072279efe415d79b22a Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL:

[Openvpn-devel] [PATCH applied] Re: test_user_pass: Add UTs for character filtering

2024-01-29 Thread Gert Doering
55418bf62eaff1c4323d206181cd8a5f88e7c6c7 Author: Frank Lichtenheld Date: Mon Jan 29 11:53:57 2024 +0100 test_user_pass: Add UTs for character filtering Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Acked-by: Gert Doering Message-Id: <20240129105358.11161-

[Openvpn-devel] [PATCH v6] test_user_pass: Add UTs for character filtering

2024-01-29 Thread Gert Doering
From: Frank Lichtenheld For simplicity I implemented them only with the inline method, but they actually apply to all methods. Change-Id: Ie8d2d5f6f58679baaf5eb817a7e2ca1afcb8c4db Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Acked-by: Gert Doering --- This change was reviewed

[Openvpn-devel] [PATCH applied] Re: test_user_pass: new UT for get_user_pass

2024-01-29 Thread Gert Doering
held Acked-by: Arne Schwabe Message-Id: <20240127200716.10255-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28138.html Signed-off-by: Gert Doering -- kind regards, Ge

[Openvpn-devel] [PATCH v8] test_user_pass: new UT for get_user_pass

2024-01-27 Thread Gert Doering
From: Frank Lichtenheld UTs for basic functionality, without management functions. v2: - add CMake support - add GHA support for both MSVC and mingw v3: - fix distcheck by adding input/ directory to dist Change-Id: I193aef06912f01426dd4ac298aadfab97dd75a35 Signed-off-by: Frank Lichtenheld

[Openvpn-devel] [PATCH applied] Re: Ensure that all unit tests use unbuffered stdout and stderr

2024-01-23 Thread Gert Doering
-archive.com/openvpn-devel@lists.sourceforge.net/msg28122.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH v3] Ensure that all unit tests use unbuffered stdout and stderr

2024-01-22 Thread Gert Doering
From: Arne Schwabe stderr is normally always unbuffered but stdout can be buffered. Especially, when stdout is redirected it will become buffered while it is normally unbuffered when connected to a terminal. This mean that if the unit exits prematurely, the output in the buffered output will be

[Openvpn-devel] [PATCH applied] Re: Fix ssl unit tests on OpenSSL 1.0.2

2024-01-22 Thread Gert Doering
Fix ssl unit tests on OpenSSL 1.0.2 Acked-by: Frank Lichtenheld Message-Id: <20240122130909.10706-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28112.html Signed-off-by: Gert Doering -- kind regard

[Openvpn-devel] [PATCH v1] Fix ssl unit tests on OpenSSL 1.0.2

2024-01-22 Thread Gert Doering
From: Arne Schwabe OpenSSL 1.1.1 will initialise itself using clever linker magic. For OpenSSL 1.0.2 we need to manually initialise the library. For other unit tests just doing the OpenSSL_add_all_algorithms is enough but this unit test needs a more complete initialisation. Change-Id:

[Openvpn-devel] [PATCH applied] Re: --http-proxy-user-pass: allow to specify in either order with --http-proxy

2024-01-22 Thread Gert Doering
4 +0100 --http-proxy-user-pass: allow to specify in either order with --http-proxy Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20240122092122.8591-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28099

[Openvpn-devel] [PATCH v1] --http-proxy-user-pass: allow to specify in either order with --http-proxy

2024-01-22 Thread Gert Doering
Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/499 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above

[Openvpn-devel] [PATCH applied] Re: buf_string_match_head_str: Fix Coverity issue 'Unsigned compared against 0'

2024-01-19 Thread Gert Doering
g28093.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH v1] buf_string_match_head_str: Fix Coverity issue "Unsigned compared against 0"

2024-01-19 Thread Gert Doering
From: Frank Lichtenheld As Coverity says: An unsigned value can never be negative, so this test will always evaluate the same way. Was changed from int to size_t in commit 7fc608da4ec388c9209bd009cd5053ac0ff7df38 which triggered warning, but the check did not make sense before, either.

[Openvpn-devel] [PATCH applied] Re: NTLM: when NTLMv1 is requested, try NTLMv2 instead

2024-01-18 Thread Gert Doering
://www.mail-archive.com/search?l=mid=20240118151242.12169-1-g...@greenie.muc.de Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH applied] Re: proxy-options.rst: Add proper documentation for --http-proxy-user-pass

2024-01-18 Thread Gert Doering
ichtenheld Date: Thu Jan 18 17:49:03 2024 +0100 proxy-options.rst: Add proper documentation for --http-proxy-user-pass Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20240118164903.22519-1-g...@greenie.muc.de> URL: https://www.mail-archive.c

[Openvpn-devel] [PATCH v1] proxy-options.rst: Add proper documentation for --http-proxy-user-pass

2024-01-18 Thread Gert Doering
From: Frank Lichtenheld And extend examples section for authenticated HTTP proxies because is was misleading. Change-Id: I7a754d0b4a76a9227bf922f65176cd9ec4d7670c Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one

[Openvpn-devel] [PATCH v1] NTLM: when NTLMv1 is requested, try NTLMv2 instead

2024-01-18 Thread Gert Doering
From: Frank Lichtenheld Commit 21910ebc2ee8a6138eb2af8d38056d2b94e59f9c removed support for NTLMv1 authentication. This adjusts the behavior for existing configurations that specify "ntlm" keyword. Do not error out hard, instead just try to upgrade. This should work fine in many cases and will

[Openvpn-devel] [PATCH applied] Re: Remove conditional text for Apache2 linking exception

2024-01-18 Thread Gert Doering
ed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH v1] Remove conditional text for Apache2 linking exception

2024-01-18 Thread Gert Doering
From: Arne Schwabe With the reimplementation of the tls-export feature and removal/approval or being trivial of the rest of the code, now all the code falls under new license. Remove the conditional text of the license to be only valid for parts of OpenVPN. Change-Id:

[Openvpn-devel] [PATCH v7] test_user_pass: new UT for get_user_pass

2024-01-17 Thread Gert Doering
From: Frank Lichtenheld UTs for basic functionality, without management functions. v2: - add CMake support - add GHA support for both MSVC and mingw v3: - fix distcheck by adding input/ directory to dist Change-Id: I193aef06912f01426dd4ac298aadfab97dd75a35 Signed-off-by: Frank Lichtenheld

Re: [Openvpn-devel] [L] Change in openvpn[release/2.6]: Backport mbed TLS 3 support to OpenVPN 2.6

2024-01-17 Thread Gert Doering
hing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Do

[Openvpn-devel] [PATCH applied] Re: Fix various 'Uninitialized scalar variable' warnings from Coverity

2024-01-17 Thread Gert Doering
chtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27157.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists

  1   2   3   4   5   6   7   8   9   10   >