Re: [Openvpn-devel] [PATCH] Add support for tls-ciphersuites for TLS 1.3

2018-09-28 Thread David Sommerseth
On 27/09/18 22:20, Matthias Andree wrote: [...] >> + msg(M_WARN, "mbed TLS does not support setting tls-ciphersuites. Ignoring >> TLS 1.3 cipher list: %s", ciphers); >> +} >> + > > Is the blank between mbed and TLS right? Looks so, when seeing what they do on the official web pages:

Re: [Openvpn-devel] [PATCH] Add support for tls-ciphersuites for TLS 1.3

2018-09-27 Thread Matthias Andree
Hi Arne, I haven't looked at the code, only at strings for now, and I'd like to pick a few nits. Am 26.09.18 um 15:44 schrieb Arne Schwabe: > OpenSSL 1.1.1 introduces a seperate list for TLS 1.3 ciphers. As these > interfaces are meant to be user facing or not exposed at all and we > expose the

[Openvpn-devel] [PATCH] Add support for tls-ciphersuites for TLS 1.3

2018-09-26 Thread Arne Schwabe
OpenSSL 1.1.1 introduces a seperate list for TLS 1.3 ciphers. As these interfaces are meant to be user facing or not exposed at all and we expose the tls-cipher interface, we should also expose tls-cipherlist. Combining both settings into tls-cipher would add a lot of glue logic that needs to be m