Re: [Openvpn-devel] [PATCH] Change float log message to include common name, if available.

[Lev Stipakov]

ACK

2015-03-07 18:23 GMT+02:00 Steffan Karger :
> Makes it a lot easier to see which client is floating.
>
> Signed-off-by: Steffan Karger 
> ---
>  src/openvpn/multi.c | 7 +--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
> index 4412491..b0f66ca 100644
> --- a/src/openvpn/multi.c
> +++ b/src/openvpn/multi.c
> @@ -2151,8 +2151,11 @@ void multi_process_float (struct multi_context* m, 
> struct multi_instance* mi)
>multi_close_instance(m, ex_mi, false);
>  }
>
> -msg (D_MULTI_MEDIUM, "peer %" PRIu32 " floated from %s to %s", 
> mi->context.c2.tls_multi->peer_id,
> -mroute_addr_print (>real, ), print_link_socket_actual 
> (>top.c2.from, ));
> +msg (D_MULTI_MEDIUM, "peer %" PRIu32 " (%s) floated from %s to %s",
> +   mi->context.c2.tls_multi->peer_id,
> +   tls_common_name (mi->context.c2.tls_multi, false),
> +   mroute_addr_print (>real, ),
> +   print_link_socket_actual (>top.c2.from, ));
>
>  ASSERT (hash_remove(m->hash, >real));
>  ASSERT (hash_remove(m->iter, >real));
> --
> 2.1.0
>
>
> --
> Dive into the World of Parallel Programming The Go Parallel Website, sponsored
> by Intel and developed in partnership with Slashdot Media, is your hub for all
> things parallel software development, from weekly thought leadership blogs to
> news, videos, case studies, tutorials and more. Take a look and join the
> conversation now. http://goparallel.sourceforge.net/
> ___
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel



-- 
-Lev

[Openvpn-devel] [PATCH] Change float log message to include common name, if available.

[Steffan Karger]

Makes it a lot easier to see which client is floating.

Signed-off-by: Steffan Karger 
---
 src/openvpn/multi.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
index 4412491..b0f66ca 100644
--- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c
@@ -2151,8 +2151,11 @@ void multi_process_float (struct multi_context* m, 
struct multi_instance* mi)
   multi_close_instance(m, ex_mi, false);
 }

-msg (D_MULTI_MEDIUM, "peer %" PRIu32 " floated from %s to %s", 
mi->context.c2.tls_multi->peer_id,
-mroute_addr_print (>real, ), print_link_socket_actual 
(>top.c2.from, ));
+msg (D_MULTI_MEDIUM, "peer %" PRIu32 " (%s) floated from %s to %s",
+   mi->context.c2.tls_multi->peer_id,
+   tls_common_name (mi->context.c2.tls_multi, false),
+   mroute_addr_print (>real, ),
+   print_link_socket_actual (>top.c2.from, ));

 ASSERT (hash_remove(m->hash, >real));
 ASSERT (hash_remove(m->iter, >real));
-- 
2.1.0