Hi,
On 17/09/2020 09:01, Gert Doering wrote:
> We look at "base", which is only the host part, but "at most 32 bits of
> the host part".
>
> (This is *your* code...!)
(self-shaming dance mode=ON)
Riiight, then drop this comment. The patch looks good, except for the
comment that needs more verbo
Hi,
On Thu, Sep 17, 2020 at 08:55:07AM +0200, Antonio Quartulli wrote:
> > }
> >
> > pool->ipv6.base = ipv6_base;
> > +
> > +/* if a pool starts at ::0, that first IPv6 address is not usable
>
> can we reword a bit this comment? I.e.: "if the starting address of a
> po
Hi,
On 11/09/2020 13:59, Gert Doering wrote:
> The first IPv6 address in a subnet is not usable (IPv6 anycast address),
> but our pool code ignored this.
>
> Instead of assigning an unusable address or erroring out, just log the
> fact, and increment the pool start to ::1
>
> NOTE: this is a bit
Hi,
On Mon, Sep 14, 2020 at 10:56:59AM +0200, Antonio Quartulli wrote:
> > pool->ipv6.base = ipv6_base;
> > +
> > +/* if a pool starts at ::0, that first IPv6 address is not usable
> > + * first clients (subnet anycast address). Start with 1, then.
> > + * NOTE: t
Hi,
On 11/09/2020 13:59, Gert Doering wrote:
> index 1f74ac57..2814ff46 100644
> --- a/src/openvpn/pool.c
> +++ b/src/openvpn/pool.c
> @@ -224,6 +224,21 @@ ifconfig_pool_init(const bool ipv4_pool, enum pool_type
> type, in_addr_t start,
> }
>
> pool->ipv6.base = ipv6_base;
> +
The first IPv6 address in a subnet is not usable (IPv6 anycast address),
but our pool code ignored this.
Instead of assigning an unusable address or erroring out, just log the
fact, and increment the pool start to ::1
NOTE: this is a bit simplistic. A pool that is larger than /96 and
has non-0 b
