Re: [Openvpn-devel] [PATCH] Remove warning on pushed tun-ipv6 option.

2017-11-11 Thread Gert Doering
Hi, On Sat, Nov 11, 2017 at 03:16:13PM +0100, Steffan Karger wrote: > (I'll leave review of the correctness of the change to someone who > actually understands what tun-ipv6 exactly does.) "exactly and absolutely nothing" :-) (It *used* to be a flag to tell openvpn "switch the tun interface

Re: [Openvpn-devel] [PATCH] Remove warning on pushed tun-ipv6 option.

2017-11-11 Thread Steffan Karger
Hi, On 11-11-17 14:36, Gert Doering wrote: > tun-ipv6 is a no-op nowadays, and we print a warning to let users know - > which is not helpful for server-pushed tun-ipv6 (which might be the > result of --server-ipv6 automatically pushing this). So, remove the > warning if parsing pushed options. >

[Openvpn-devel] [PATCH] Remove warning on pushed tun-ipv6 option.

2017-11-11 Thread Gert Doering
tun-ipv6 is a no-op nowadays, and we print a warning to let users know - which is not helpful for server-pushed tun-ipv6 (which might be the result of --server-ipv6 automatically pushing this). So, remove the warning if parsing pushed options. Also, remove the VERIFY_PERMISSION() call here which