Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

> Samuli Seppänen wrote: > >> here's the next version of the patch; >> > > Functionally fine! > > > >> def main(config): >> + >> +# Do a signed build by default >> +unsignedBuild=False >> > > Maybe name the option signedBuild instead? :) > > > >> +# Check if the

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

Hi Peter, Fair points. Me fix and resend. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Samuli Seppänen wrote: > >> here's the next version of the patch; >> > > Functionally fine! > > > >> def main(config): >> + >> +# Do a signed

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

Samuli Seppänen wrote: > here's the next version of the patch; Functionally fine! > def main(config): > + > +# Do a signed build by default > +unsignedBuild=False Maybe name the option signedBuild instead? :) > +# Check if the SignTool module is present. This avoids ImportErrors

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

>> I agree that there should be no way one could make an unsigned build by >> mistake. I think dazo's suggestion about having a command-line switch >> ("force unsigned build") is a good one. The SIGNTOOL variable could then >> be used to just locate signtool.exe and nothing else. This would make

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

Hello, This again, raises the modulation of openvpn project. *NOBODY* wants/needs to modify the driver, most people lacks the skills and interest. Usually people wants to patch openvpn userspace components. The driver should come in its own .msi signed (msi + driver). OpenVPN installation

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

Hi, On Fri, Nov 12, 2010 at 05:50:19PM +0100, David Sommerseth wrote: > If I've understood it correctly, this is related to signing the Windows > TUN/TAP driver. So if you don't have a signing key/tool available, it > is still possible to build the rest of OpenVPN. You might even manage > to

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

Samuli Seppänen wrote: > Peter: settings.in is stored in git. Ok. > I agree that there should be no way one could make an unsigned build by > mistake. I think dazo's suggestion about having a command-line switch > ("force unsigned build") is a good one. The SIGNTOOL variable could then > be

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

> > What if build_all.py did this: > > > - Check if SIGNTOOL is enabled in settings.in: > > - Yes: fail if can't import "sign" module > > - No: don't fail if can't import "sign" module > > > I think existence of the SIGNTOOL variable gives a good clue of user's > > intentions. Note that the

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/11/10 18:11, Samuli Seppänen wrote: > >> On 12/11/10 17:55, Peter Stuge wrote: >>> David Sommerseth wrote: >> Modified win/build_all.py so that build does not fail even if >> the optional signtool python class is not available. >

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

Samuli Seppänen wrote: > What if build_all.py did this: > > - Check if SIGNTOOL is enabled in settings.in: > - Yes: fail if can't import "sign" module > - No: don't fail if can't import "sign" module This also sounds good. (Who typically creates settings.in? Is one in git?) //Peter

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/11/10 17:55, Peter Stuge wrote: > David Sommerseth wrote: Modified win/build_all.py so that build does not fail even if the optional signtool python class is not available. >>> >>> What is it needed for? Is it really *always* optional?

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

David Sommerseth wrote: > >> Modified win/build_all.py so that build does not fail even if > >> the optional signtool python class is not available. > > > > What is it needed for? Is it really *always* optional? > > If I've understood it correctly, this is related to signing the Windows >

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

> Samuli Seppänen wrote: > >> From 57b983dc2a1f4a31d3b7c0e2f6de7f778d234b2e Mon Sep 17 00:00:00 2001 >> From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= >> Date: Fri, 12 Nov 2010 17:32:19 +0200 >> Subject: [PATCH] Removed hardcoded signtool dependency from win/build_all.py >> >>

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/11/10 17:36, Peter Stuge wrote: > Samuli Seppänen wrote: >> From 57b983dc2a1f4a31d3b7c0e2f6de7f778d234b2e Mon Sep 17 00:00:00 2001 >> From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= >> Date: Fri, 12 Nov 2010 17:32:19 +0200 >>

Re: [Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

Samuli Seppänen wrote: > From 57b983dc2a1f4a31d3b7c0e2f6de7f778d234b2e Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= > Date: Fri, 12 Nov 2010 17:32:19 +0200 > Subject: [PATCH] Removed hardcoded signtool dependency from win/build_all.py > > Modified

[Openvpn-devel] [PATCH] Removed hardcoded signtool dependency from win/build_all.py

From 57b983dc2a1f4a31d3b7c0e2f6de7f778d234b2e Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Samuli=20Sepp=C3=A4nen?= Date: Fri, 12 Nov 2010 17:32:19 +0200 Subject: [PATCH] Removed hardcoded signtool dependency from win/build_all.py Modified win/build_all.py so that build does not