Re: [Openvpn-devel] [PATCH] autoconf: Fix engine checks for openssl 1.1

[Steffan Karger]

Hi,

On 29-10-17 16:34, James Bottomley wrote:
> In openssl 1.1, ENGINE_cleanup became a #define instead of a function
> (because it's no longer needed as engines are self cleaning).  Update
> the autoconf.ac script to check for ENGINE_cleanup as a declaration to
> avoid falsely underfinig HAVE_OPENSSL_ENGINE in openssl 1.1+

Typo in "underfinig", but that should be fixable when applying the patch.

> Signed-off-by: James Bottomley 
> ---
>  configure.ac | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 6f59baef..45aa5017 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -899,6 +899,13 @@ if test "${enable_crypto}" = "yes" -a 
> "${with_crypto_library}" = "openssl"; then
>   ,
>   [have_openssl_engine="no"; break]
>   )
> + if test "${have_openssl_engine}" = "no"; then
> + AC_CHECK_DECL( [ENGINE_cleanup], [have_openssl_engine="yes"],,
> + [[
> + #include 
> + ]]
> + )
> + fi
>   if test "${have_openssl_engine}" = "yes"; then
>   AC_DEFINE([HAVE_OPENSSL_ENGINE], [1], [OpenSSL engine support 
> available])
>   fi
> 

Change looks good, and does what it says on the tin.  ACK.

-Steffan

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH] autoconf: Fix engine checks for openssl 1.1

[James Bottomley]

In openssl 1.1, ENGINE_cleanup became a #define instead of a function
(because it's no longer needed as engines are self cleaning).  Update
the autoconf.ac script to check for ENGINE_cleanup as a declaration to
avoid falsely underfinig HAVE_OPENSSL_ENGINE in openssl 1.1+

Signed-off-by: James Bottomley 
---
 configure.ac | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/configure.ac b/configure.ac
index 6f59baef..45aa5017 100644
--- a/configure.ac
+++ b/configure.ac
@@ -899,6 +899,13 @@ if test "${enable_crypto}" = "yes" -a 
"${with_crypto_library}" = "openssl"; then
,
[have_openssl_engine="no"; break]
)
+   if test "${have_openssl_engine}" = "no"; then
+   AC_CHECK_DECL( [ENGINE_cleanup], [have_openssl_engine="yes"],,
+   [[
+   #include 
+   ]]
+   )
+   fi
if test "${have_openssl_engine}" = "yes"; then
AC_DEFINE([HAVE_OPENSSL_ENGINE], [1], [OpenSSL engine support 
available])
fi
-- 
2.12.3

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel