Re: [Openvpn-devel] [PATCH] cert_data: fix memory leak

2015-05-28 Thread Gert Doering
Hi, On Thu, May 28, 2015 at 04:14:12PM +0200, Yegor Yefremov wrote: > > Looks reasonable to me, and if Vasily as the primary author acks it, > > fine to me. I'll merge it ASAP, though it would make my life easier > > if I had the original mail (on the openvpn-devel list) to feed into > > "git

Re: [Openvpn-devel] [PATCH] cert_data: fix memory leak

2015-05-28 Thread Yegor Yefremov
On Thu, May 28, 2015 at 4:00 PM, Gert Doering wrote: > Hi, > > On Thu, May 28, 2015 at 02:21:44PM +0200, Yegor Yefremov wrote: >> On Tue, Apr 21, 2015 at 9:58 AM, Vasily Kulikov wrote: >> > On Mon, Apr 20, 2015 at 16:30 +0200, Yegor Yefremov wrote: >> >>

Re: [Openvpn-devel] [PATCH] cert_data: fix memory leak

2015-05-28 Thread Gert Doering
Hi, On Thu, May 28, 2015 at 02:21:44PM +0200, Yegor Yefremov wrote: > On Tue, Apr 21, 2015 at 9:58 AM, Vasily Kulikov wrote: > > On Mon, Apr 20, 2015 at 16:30 +0200, Yegor Yefremov wrote: > >> Release pCertName, if SecCertificateCopyValues() fails. > >> > >> Found via

Re: [Openvpn-devel] [PATCH] cert_data: fix memory leak

2015-05-28 Thread Yegor Yefremov
Hi Gert, On Tue, Apr 21, 2015 at 9:58 AM, Vasily Kulikov wrote: > On Mon, Apr 20, 2015 at 16:30 +0200, Yegor Yefremov wrote: >> Release pCertName, if SecCertificateCopyValues() fails. >> >> Found via cppcheck. >> >> Signed-off-by: Yegor Yefremov

Re: [Openvpn-devel] [PATCH] cert_data: fix memory leak

2015-04-21 Thread Vasily Kulikov
On Mon, Apr 20, 2015 at 16:30 +0200, Yegor Yefremov wrote: > Release pCertName, if SecCertificateCopyValues() fails. > > Found via cppcheck. > > Signed-off-by: Yegor Yefremov > Cc: Vasily Kulikov Acked-by: Vasily Kulikov

[Openvpn-devel] [PATCH] cert_data: fix memory leak

2015-04-20 Thread Yegor Yefremov
Release pCertName, if SecCertificateCopyValues() fails. Found via cppcheck. Signed-off-by: Yegor Yefremov Cc: Vasily Kulikov --- contrib/keychain-mcd/cert_data.c | 1 + 1 file changed, 1 insertion(+) diff --git