Re: [Openvpn-devel] [PATCH] implement --session-timeout

2022-09-19 Thread Antonio Quartulli
Hi, On 19/09/2022 09:11, Gert Doering wrote: Hi, On Mon, Sep 19, 2022 at 08:36:21AM +0200, Gert Doering wrote: we don't get here at all, if we have no event object that is timing out. process_coarse_timers() is run once per second, and does not need additional timers to be called. This new

Re: [Openvpn-devel] [PATCH] implement --session-timeout

2022-09-19 Thread Gert Doering
Hi, On Mon, Sep 19, 2022 at 08:36:21AM +0200, Gert Doering wrote: > > we don't get here at all, if we have no event object that is timing out. > > process_coarse_timers() is run once per second, and does not need > additional timers to be called. > > This new check is added to

Re: [Openvpn-devel] [PATCH] implement --session-timeout

2022-09-19 Thread Gert Doering
Hi, On Mon, Sep 19, 2022 at 12:29:20AM +0200, Antonio Quartulli wrote: > On 18/09/2022 12:37, Gert Doering wrote: > > On Sun, Sep 18, 2022 at 01:10:30AM +0200, Antonio Quartulli wrote: > >> From: Dmitry Zelenkovsky > >> > >> Disconnect clients after session-timeout expires. > >> session-timeout

Re: [Openvpn-devel] [PATCH] implement --session-timeout

2022-09-18 Thread Antonio Quartulli
On 18/09/2022 12:37, Gert Doering wrote: HI, On Sun, Sep 18, 2022 at 01:10:30AM +0200, Antonio Quartulli wrote: From: Dmitry Zelenkovsky Disconnect clients after session-timeout expires. session-timeout can be defined in ccd files in order to limit per-user connection time. I find this

Re: [Openvpn-devel] [PATCH] implement --session-timeout

2022-09-18 Thread Gert Doering
HI, On Sun, Sep 18, 2022 at 01:10:30AM +0200, Antonio Quartulli wrote: > From: Dmitry Zelenkovsky > > Disconnect clients after session-timeout expires. > session-timeout can be defined in ccd files in order to limit > per-user connection time. I find this implementation needlessly complicated.

[Openvpn-devel] [PATCH] implement --session-timeout

2022-09-17 Thread Antonio Quartulli
From: Dmitry Zelenkovsky Disconnect clients after session-timeout expires. session-timeout can be defined in ccd files in order to limit per-user connection time. Signed-off-by: Dmitry Zelenkovsky --- src/openvpn/forward.c | 22 ++ src/openvpn/init.c| 7 +++