Re: [Openvpn-devel] [PATCH] networking/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Tom Yan
Btw, is there a particular reason that we don't simply use "broadcast +" and let `ip` handle it? We won't even need to do the prefix length check if we aren't setting the broadcast address explicitly. Regards, On Sun, 3 Nov 2019 at 19:32, Tom Yan wrote: > > Hello Antonio, > > With 31-bit IPv4

Re: [Openvpn-devel] [PATCH] networking/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Tom Yan
Hello Antonio, With 31-bit IPv4 prefix, only two addresses can be provided with the single host bit. Neither the network address nor the broadcast address makes sense anymore in such "subnet", as it's basically for point-to-point link. Assigning such address with a broadcast address will prevent

Re: [Openvpn-devel] [PATCH] networking/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-03 Thread Antonio Quartulli
Hi Tom, first of all, thanks a lot for your contribution! On 03/11/2019 06:30, Tom Yan wrote: > --- > src/openvpn/networking_iproute2.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/openvpn/networking_iproute2.c > b/src/openvpn/networking_iproute2.c >

[Openvpn-devel] [PATCH] networking/iproute2: support 31-bit ipv4 prefix (RFC 3021)

2019-11-02 Thread Tom Yan
--- src/openvpn/networking_iproute2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/openvpn/networking_iproute2.c b/src/openvpn/networking_iproute2.c index 1ddeb5cf..4e2435c1 100644 --- a/src/openvpn/networking_iproute2.c +++ b/src/openvpn/networking_iproute2.c @@