Re: [Openvpn-devel] [PATCH] reload HTTP proxy credentials when moving to the next connection profile

2017-02-01 Thread Selva Nair
On Wed, Feb 1, 2017 at 3:33 AM, Antonio Quartulli wrote: > On Wed, Feb 01, 2017 at 11:04:55AM +0800, Antonio Quartulli wrote: > > > That said, there is one issue with this approach. Looks like SIGUSR1 > > > restarts will now always prompt for proxy password, which is not > proper. > > > > Right!

Re: [Openvpn-devel] [PATCH] reload HTTP proxy credentials when moving to the next connection profile

2017-02-01 Thread Antonio Quartulli
Hi, On Wed, Feb 01, 2017 at 11:04:55AM +0800, Antonio Quartulli wrote: > > That said, there is one issue with this approach. Looks like SIGUSR1 > > restarts will now always prompt for proxy password, which is not proper. > > Right! Thanks for pointing this out! Actually I'd like to understand th

Re: [Openvpn-devel] [PATCH] reload HTTP proxy credentials when moving to the next connection profile

2017-01-31 Thread Antonio Quartulli
Hi Selva, thank you very much for your feedback! On Tue, Jan 31, 2017 at 03:02:33PM -0500, Selva Nair wrote: > Hi, > > On Tue, Jan 31, 2017 at 1:22 PM, Antonio Quartulli wrote: > > > iff --git a/src/openvpn/proxy.c b/src/openvpn/proxy.c > > index b0ed3279..27f34bed 100644 > > --- a/src/openvpn

Re: [Openvpn-devel] [PATCH] reload HTTP proxy credentials when moving to the next connection profile

2017-01-31 Thread Selva Nair
Hi, On Tue, Jan 31, 2017 at 1:22 PM, Antonio Quartulli wrote: > iff --git a/src/openvpn/proxy.c b/src/openvpn/proxy.c > index b0ed3279..27f34bed 100644 > --- a/src/openvpn/proxy.c > +++ b/src/openvpn/proxy.c > @@ -256,7 +256,16 @@ username_password_as_base64(const struct > http_proxy_info *p, >

[Openvpn-devel] [PATCH] reload HTTP proxy credentials when moving to the next connection profile

2017-01-31 Thread Antonio Quartulli
The HTTP proxy credentials are stored in a static variable that is possibly initialized before each connection attempt. However, the variable is never "released" therefore get_user_pass() refuses to overwrite its content and leaves it as it is. Consequently, if the user config contains multiple co