Re: [Openvpn-devel] [PATCH 1/1] fix timeout in non-TLS mode with systemd

2016-12-29 Thread Gert Doering
Hi, On Wed, Dec 28, 2016 at 11:49:24PM +0100, David Sommerseth wrote: > On 28/12/16 22:03, Gert Doering wrote: > > nothing else but a subset of Linux distributions use systemd today, > > If including the "millions" of various Linux distributions on > DistroWatch, you might very well be right. >

Re: [Openvpn-devel] [PATCH 1/1] fix timeout in non-TLS mode with systemd

2016-12-28 Thread David Sommerseth
On 28/12/16 22:03, Gert Doering wrote: > nothing else but a subset of Linux distributions use systemd today, If including the "millions" of various Linux distributions on DistroWatch, you might very well be right. But a far better measuring point would be which Linux distributions the majority

Re: [Openvpn-devel] [PATCH 1/1] fix timeout in non-TLS mode with systemd

2016-12-28 Thread Selva Nair
Hi, On Wed, Dec 28, 2016 at 2:37 PM, Christian Hesse wrote: > > For informational purpose we could add even more calls. That would allow to > set intermediate status message, something like: "Up and running, currently > serving 25 client connections." If the daemon has to send

Re: [Openvpn-devel] [PATCH 1/1] fix timeout in non-TLS mode with systemd

2016-12-28 Thread Gert Doering
Hi, On Wed, Dec 28, 2016 at 08:37:48PM +0100, Christian Hesse wrote: > > We definitely need a better approach than "litter ENABLE_SYSTEMD all > > over the code". > > Well, openvpn supports a number of modes of operation... Some of these have > other requirements than others. This I understand

Re: [Openvpn-devel] [PATCH 1/1] fix timeout in non-TLS mode with systemd

2016-12-28 Thread Christian Hesse
Gert Doering on Wed, 2016/12/28 19:57: > Hi, > > On Wed, Dec 28, 2016 at 02:07:21PM +0100, Christian Hesse wrote: > > @@ -73,6 +77,21 @@ tunnel_point_to_point(struct context *c) > > return; > > } > > > > +#ifdef ENABLE_SYSTEMD > > +/* In non-TLS

Re: [Openvpn-devel] [PATCH 1/1] fix timeout in non-TLS mode with systemd

2016-12-28 Thread Gert Doering
Hi, On Wed, Dec 28, 2016 at 02:07:21PM +0100, Christian Hesse wrote: > @@ -73,6 +77,21 @@ tunnel_point_to_point(struct context *c) > return; > } > > +#ifdef ENABLE_SYSTEMD > +/* In non-TLS configuration we wait for the remote peer to connect > + * before issuing

[Openvpn-devel] [PATCH 1/1] fix timeout in non-TLS mode with systemd

2016-12-28 Thread Christian Hesse
From: Christian Hesse In non-TLS configuration we wait for the remote peer to connect before issuing "Initialization Sequence Completed". So prevent to time out by telling systemd service manager we are ready for now. Status will be "Non-TLS mode, ready for now. Waiting for