Re: [Openvpn-devel] [PATCH 1/2] Skip expired certificates in Windows certificate store

Hi, On 02-04-18 16:58, Selva Nair wrote: > On Mon, Apr 2, 2018 at 8:37 AM, Steffan Karger wrote: >> Also, this looks like a somewhat unrelated fix. I would have personally >> preferred it in a separate patch (so we can e.g. backport it easily even >> if we decide not not

Re: [Openvpn-devel] [PATCH 1/2] Skip expired certificates in Windows certificate store

Hi, One comment based on stare-at-code only: On 12-03-18 02:17, selva.n...@gmail.com wrote: > @@ -636,6 +640,8 @@ find_certificate_in_store(const char *cert_prop, > HCERTSTORE cert_store) > } > if (!*++p) /* unexpected end of string */ > { > +

Re: [Openvpn-devel] [PATCH 1/2] Skip expired certificates in Windows certificate store

Hi Selva, On Sun, Mar 11, 2018 at 09:17:58PM -0400, selva.n...@gmail.com wrote: > From: Selva Nair > > Have the cryptoapicert option find the first matching certificate > in store that is valid at the present time. Currently the first > found item, even if expired, is

[Openvpn-devel] [PATCH 1/2] Skip expired certificates in Windows certificate store

From: Selva Nair Have the cryptoapicert option find the first matching certificate in store that is valid at the present time. Currently the first found item, even if expired, is returned. This makes it possible to update certifiates in store without having to delete old