Re: [Openvpn-devel] [PATCH 1/3] Simplify multi_connection_established.

2020-07-07 Thread Antonio Quartulli
Hi, On 07/07/2020 14:16, Arne Schwabe wrote: > Instead of having the whole function as > > if (x) { func } > > do > >if (!x) func I guess this commit message needs some love? You probably meant: Instead of.. if (x) { func } do if (!x) return; func At

[Openvpn-devel] [PATCH 1/3] Simplify multi_connection_established.

2020-07-07 Thread Arne Schwabe
Instead of having the whole function as if (x) { func } do if (!x) func Due to the whitespace changes in the function body this patch looks very strange. Ignoring whitespace makes the diff look sane. Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 476