Re: [Openvpn-devel] [PATCH 2/2] Fix rand_bytes return value checking

2015-11-28 Thread Arne Schwabe
Am 28.11.15 um 11:38 schrieb Steffan Karger: > This patch is in response to an off-list report by Sebastian Krahmer of > the SuSE security team. Sebastian noticed we do not check the return > value of rand_bytes() in prng_bytes(), which we really should. ACK. Asserting on failed random seem

[Openvpn-devel] [PATCH 2/2] Fix rand_bytes return value checking

2015-11-28 Thread Steffan Karger
This patch is in response to an off-list report by Sebastian Krahmer of the SuSE security team. Sebastian noticed we do not check the return value of rand_bytes() in prng_bytes(), which we really should. Failing to check the return value occurs if no prng is used (i.e. in static key mode, or