Re: [Openvpn-devel] [PATCH 2/2] uncrustify: remove newlines after return type of function prototype

2022-08-24 Thread Frank Lichtenheld
On Fri, Aug 19, 2022 at 12:18:06PM +0200, Gert Doering wrote: > Hi, [...] > It would be cool if uncrustify had a magic flag for that, like "if > return type + function name is < 40 characters, put on a single line, > and if over, split" :-) Pretty sure there is nothing like that. So should we

Re: [Openvpn-devel] [PATCH 2/2] uncrustify: remove newlines after return type of function prototype

2022-08-19 Thread Gert Doering
Hi, On Fri, Aug 19, 2022 at 11:50:04AM +0200, Arne Schwabe wrote: > Am 18.08.22 um 22:43 schrieb Antonio Quartulli: > > yes! This is what we need! > > > > Acked-by: Antonio Quartulli > > I am out of the loop here. Could you two explain why we need this? I.e. > what is wrong with the current

Re: [Openvpn-devel] [PATCH 2/2] uncrustify: remove newlines after return type of function prototype

2022-08-19 Thread Antonio Quartulli
Hi, On 19/08/2022 11:50, Arne Schwabe wrote: Am 18.08.22 um 22:43 schrieb Antonio Quartulli: yes! This is what we need! Acked-by: Antonio Quartulli I am out of the loop here. Could you two explain why we need this? I.e. what is wrong with the current style is and what the plan is to

Re: [Openvpn-devel] [PATCH 2/2] uncrustify: remove newlines after return type of function prototype

2022-08-19 Thread Arne Schwabe
Am 18.08.22 um 22:43 schrieb Antonio Quartulli: yes! This is what we need! Acked-by: Antonio Quartulli I am out of the loop here. Could you two explain why we need this? I.e. what is wrong with the current style is and what the plan is to change? If often struggle to properly format

Re: [Openvpn-devel] [PATCH 2/2] uncrustify: remove newlines after return type of function prototype

2022-08-18 Thread Antonio Quartulli
yes! This is what we need! Acked-by: Antonio Quartulli -- Antonio Quartulli ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH 2/2] uncrustify: remove newlines after return type of function prototype

2022-08-18 Thread Frank Lichtenheld
Signed-off-by: Frank Lichtenheld --- dev-tools/uncrustify.conf | 1 + 1 file changed, 1 insertion(+) diff --git a/dev-tools/uncrustify.conf b/dev-tools/uncrustify.conf index 325f3108..c73fba0c 100644 --- a/dev-tools/uncrustify.conf +++ b/dev-tools/uncrustify.conf @@ -40,6 +40,7 @@