From: Antonio Quartulli <anto...@openvpn.net> In order to improve code readability it is better to unwrap multiple function calls onto multiple lines.
Signed-off-by: Antonio Quartulli <anto...@openvpn.net> --- src/openvpn/ntlm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/openvpn/ntlm.c b/src/openvpn/ntlm.c index c0319287..47ad8959 100644 --- a/src/openvpn/ntlm.c +++ b/src/openvpn/ntlm.c @@ -276,7 +276,8 @@ ntlm_phase_3(const struct http_proxy_info *p, const char *phase_2, int tib_len; /* NTLMv2 hash */ - my_strupr(strcpy(userdomain, username)); + strcpy(userdomain, username) + my_strupr(userdomain); if (strlen(username) + strlen(domain) < sizeof(userdomain)) { strcat(userdomain, domain); -- 2.13.2 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel