Re: [Openvpn-devel] [PATCH 5/5] Prefer TLS libraries TLS PRF function, fix OpenVPN in FIPS mode

2021-02-01 Thread Arne Schwabe
Am 29.01.21 um 15:09 schrieb Antonio Quartulli: > Hi, > > witht his review I want to open a broader discussion about the use of > ASSERT in the OpenVPN code. > > My comments below will get to the point. > > On 07/09/2020 18:22, Arne Schwabe wrote: >> This moves from using our own copy of the TLS

Re: [Openvpn-devel] [PATCH 5/5] Prefer TLS libraries TLS PRF function, fix OpenVPN in FIPS mode

2021-01-29 Thread Antonio Quartulli
Hi, witht his review I want to open a broader discussion about the use of ASSERT in the OpenVPN code. My comments below will get to the point. On 07/09/2020 18:22, Arne Schwabe wrote: > This moves from using our own copy of the TLS1 PRF function to using > TLS library provided function where pos

[Openvpn-devel] [PATCH 5/5] Prefer TLS libraries TLS PRF function, fix OpenVPN in FIPS mode

2020-09-07 Thread Arne Schwabe
This moves from using our own copy of the TLS1 PRF function to using TLS library provided function where possible. This includes currently OpenSSL 1.1.0+ and mbed TLS 2.18+. For the libraries where it is not possible to use the library's own function, we still use our own implementation. mbed TLS