Re: [Openvpn-devel] [PATCH 7/7] Add gc_arena to struct argv to save allocations

On Thursday, November 10, 2016 4:01:20 PM CET David Sommerseth wrote: > On 28/10/16 18:42, Heiko Hund wrote: > > > > + a->gc = gc_new (); > >argv_extend (a, 8); > > } > > Any specific reason we want to keep our own gc_arena on argv? Why not > pass an existing gc_arena pointer to the

Re: [Openvpn-devel] [PATCH 7/7] Add gc_arena to struct argv to save allocations

On 28/10/16 18:42, Heiko Hund wrote: > With the private gc_arena we do not have to allocate the strings > found during parsing again, since we know the arena they are > allocated in is valid as long as the argv vector is. > > Signed-off-by: Heiko Hund > --- >

[Openvpn-devel] [PATCH 7/7] Add gc_arena to struct argv to save allocations

With the private gc_arena we do not have to allocate the strings found during parsing again, since we know the arena they are allocated in is valid as long as the argv vector is. Signed-off-by: Heiko Hund --- src/openvpn/argv.c | 37