Re: [Openvpn-devel] [PATCH applied] Clean up plugin path handling

[Gert Doering]

Hi,

On Wed, Jan 25, 2017 at 10:16:23PM +0100, David Sommerseth wrote:
> ACK.  This have been through enough rounds, and I currently don't
> see a better approach to the openvpn-plugin.h generation either.  If
> we find better ways later on, lets fix it then.

This needs a bit of polishing... as you've undoubtly already seen,
this change broke building on everything that is not Linux or MacOS...

Since we'll see this more often if developers cannot test on "other
platforms", I'm happy to offer accounts on my FreeBSD 10.3 buildslave
to regular contributors that want to test their patches on at least
one BSD system to ensure there is no hidden bashism or GNU Make-ism
(which seems to be the problem here).

Thinking of you and Christian here :-) - so if interested, please mail me 
a ssh pubkey and a static source IPv4/IPv6 network so I can create an 
account and open the ACLs (the buildslaves have fairly restricted network 
access and reachability).

gert


-- 
USENET is *not* the non-clickable part of WWW!
   //www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025g...@net.informatik.tu-muenchen.de


signature.asc
Description: PGP signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH applied] Clean up plugin path handling

[David Sommerseth]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

ACK.  This have been through enough rounds, and I currently don't
see a better approach to the openvpn-plugin.h generation either.  If
we find better ways later on, lets fix it then.

I've tested this using gdb and investigating which code paths are
used in different circumstances (--plugin with and without absolute path)
and the expected plug-ins are loaded.

Your patch has been applied to the following branches

commit 4590c3831d0400096fab08aa1ed7f909da870ced  (master)
commit 05baa0ecf841852fbf29ef39ee9cd1d4cac990cf  (release/2.4)
Author: Christian Hesse
Date:   Wed Jan 25 21:19:47 2017 +0100

 Clean up plugin path handling

 Signed-off-by: Christian Hesse 
 Acked-by: David Sommerseth 
 Message-Id: <20170125201947.17197-1-l...@eworm.de>
 URL: 
http://www.mail-archive.com/search?l=mid=20170125201947.17197-1-l...@eworm.de
 Signed-off-by: David Sommerseth 


- --
kind regards,

David Sommerseth

-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJYiRWlAAoJEIbPlEyWcf3yQGEP/269/VKw/dW5KU/XrLIfwgT+
N5qzzKvalVnvlb8ki2GE4YaMp0dfjElup28iQi7wCbmAfHYiX9inc0KtQK7ggMHQ
6EMzgRnJla0mTVyKnFecSCVNFuDERcLc1a+K/Qq4JeiRUK3eyHbKZCA766xd3C+G
/7x2SMPdXAqpAexuxO74Nz+GWuu7KLBY+F3LHYHAC4GiTHtd84pi2GpDveaod4K2
ttRqvnnZRn5JiuVl89To20faU1iw9RHvqFqZMOZfEq4fkRTK+0tJiMhJ5NcH1khm
OiS/4x/HQtL79GqjrUkOCr3vyjoMRWd13Lz49eK6U4GFlcsivH09IL8toHfcdMjX
DimgaYNHNo0+rxHOV53Jp6ADd97E93580Xe1drk6CUo7Sf0f4C25dtFzQJm67pkV
L/45suNEL6jq2UvqCj/KR9AnawEVaGkhI9ikEkEJsDFgxi2fXWthuhe8SOXNugPA
j+lyViB9vmTb2OVukEJKartAYBiOKd7dcTUUoE3U/XvEbNKMS7IsBMIDTinTUOlt
la9Vu7DucKGXOeEIhbHHYuNV6Mff1eWNr8l7bx42mE1hSDHba5DwF0r0x2oTDZyn
esew8w+R/ALVqeXCMx5bzwtdBngqAY0W90ePeuK2FyNFRsy83lZYbS6DVhmkXplQ
OpS/rxQtFMDJI09cT+wz
=KBA6
-END PGP SIGNATURE-

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel