Re: [Openvpn-devel] [PATCH applied] Re: Do not restart dns client service as a part of --register-dns processing

2016-12-02 Thread Selva Nair
On Fri, Dec 2, 2016 at 6:28 AM, Gert Doering wrote: > On Thu, Dec 01, 2016 at 05:25:49PM -0500, Selva Nair wrote: > > Do we want this in 2.3.14 as well ? If so I'll send a patch with service > > part removed (note to self: remember to include docs and Changes.rst > edits) >

Re: [Openvpn-devel] [PATCH applied] Re: Do not restart dns client service as a part of --register-dns processing

2016-12-02 Thread Gert Doering
Hi, On Thu, Dec 01, 2016 at 05:25:49PM -0500, Selva Nair wrote: > Do we want this in 2.3.14 as well ? If so I'll send a patch with service > part removed (note to self: remember to include docs and Changes.rst edits) My gut feeling is "leave 2.3 as it is, this could actually be *necessary* on

Re: [Openvpn-devel] [PATCH applied] Re: Do not restart dns client service as a part of --register-dns processing

2016-12-01 Thread Selva Nair
Hi, On Thu, Dec 1, 2016 at 3:21 AM, Gert Doering wrote: > ACK, thanks. > > Code looks good, and test compiles. Have not test-run yet but do not > expect any surprises there. > > I have added a Changes.rst entry (someone *might* notice and wonder if > this was intentional

[Openvpn-devel] [PATCH applied] Re: Do not restart dns client service as a part of --register-dns processing

2016-12-01 Thread Gert Doering
ACK, thanks. Code looks good, and test compiles. Have not test-run yet but do not expect any surprises there. I have added a Changes.rst entry (someone *might* notice and wonder if this was intentional :) ) and updated doc/openvpn.8 and the help text in options.c which both used to list all the