Re: [Openvpn-devel] [PATCH applied] Re: Skip expired certificates in Windows certificate store
Hi,
On Wed, Apr 15, 2020 at 02:22:15PM -0400, Selva Nair wrote:
> > is this one and aa6affe6df811db11577847366a569def0a3e314 also material
> > for release/2.4? So "feature" or "bug" category?
>
> Yes it would be good to get this one and aa6affe into 2.4. This one
> will cherry-pick with a minor conflict in cryptoapicert.c, easily
> resolved. aa6affe should cherry-pick with no issues.
That conflict was trivial indeed. I fixed an occurrance of "else {"
while at it (whitespace only).
Test built on Ubuntu/MinGW, not actually tested the resulting binary.
Cursory review of the code also does not reveal anything unexpected.
commit 5f8a9df1eea33c2d6fc267e5e3683449954c986b (HEAD -> release/2.4)
Author: Selva Nair
Date: Wed Feb 12 10:06:07 2020 -0500
Allow unicode search string in --cryptoapicert option
(cherry picked from commit aa6affe6df811db11577847366a569def0a3e314)
commit 4658b3b6f6008eea1819ea26a46fd46df87b1030
Author: Selva Nair
Date: Wed Feb 12 10:06:06 2020 -0500
Skip expired certificates in Windows certificate store
(cherry picked from commit 7b63984d51a2582ba2d406e46a7debb11df7f478)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH applied] Re: Skip expired certificates in Windows certificate store
Hi, > is this one and aa6affe6df811db11577847366a569def0a3e314 also material > for release/2.4? So "feature" or "bug" category? Yes it would be good to get this one and aa6affe into 2.4. This one will cherry-pick with a minor conflict in cryptoapicert.c, easily resolved. aa6affe should cherry-pick with no issues. Selva ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH applied] Re: Skip expired certificates in Windows certificate store
Hi, is this one and aa6affe6df811db11577847366a569def0a3e314 also material for release/2.4? So "feature" or "bug" category? (I've left this sit in my inbox and also in patchwork to remind me that I wanted to clarify this, and then never got around to actually do so) gert On Thu, Feb 13, 2020 at 08:54:18PM +0100, Gert Doering wrote: > Your patch has been applied to the master branch. > > Haven't done any real testing, just test build on MinGW (to have "the > other build environment"). Passes :-) > > commit 7b63984d51a2582ba2d406e46a7debb11df7f478 > Author: Selva Nair > Date: Wed Feb 12 10:06:06 2020 -0500 > > Skip expired certificates in Windows certificate store > > Signed-off-by: Selva Nair > Acked-by: Lev Stipakov > Message-Id: <1581519967-16950-1-git-send-email-selva.n...@gmail.com> > URL: > https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19404.html > Signed-off-by: Gert Doering > > > -- > kind regards, > > Gert Doering > > > > ___ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel > -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: Skip expired certificates in Windows certificate store
Your patch has been applied to the master branch. Haven't done any real testing, just test build on MinGW (to have "the other build environment"). Passes :-) commit 7b63984d51a2582ba2d406e46a7debb11df7f478 Author: Selva Nair Date: Wed Feb 12 10:06:06 2020 -0500 Skip expired certificates in Windows certificate store Signed-off-by: Selva Nair Acked-by: Lev Stipakov Message-Id: <1581519967-16950-1-git-send-email-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19404.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
